[jira] [Commented] (TS-1760) use linux native aio
[ https://issues.apache.org/jira/browse/TS-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638767#comment-13638767 ] James Peach commented on TS-1760: - This is committed to master. Shall we close this out and file new tickets for any remaining issues? use linux native aio Key: TS-1760 URL: https://issues.apache.org/jira/browse/TS-1760 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: weijin Assignee: weijin Fix For: 3.3.3 Attachments: native_aio.patch add a feature that use linux native aio -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1760) use linux native aio
[ https://issues.apache.org/jira/browse/TS-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13622427#comment-13622427 ] weijin commented on TS-1760: the timeout of io_getevents is 0, so it is never blocked. use linux native aio Key: TS-1760 URL: https://issues.apache.org/jira/browse/TS-1760 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: weijin Assignee: weijin Fix For: 3.3.2 Attachments: native_aio.patch add a feature that use linux native aio -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1760) use linux native aio
[ https://issues.apache.org/jira/browse/TS-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620700#comment-13620700 ] ASF subversion and git services commented on TS-1760: - Commit c95298dfcc6336cc04f172713f5d41e023d19d51 in branch refs/heads/master from Zhao Yongming ming@gmail.com [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=c95298d ] TS-1760: Option to use Linux native AIO to enable the Linux Native AIO, be sure to check Linux kernel AIO supporting and use '--use_linux_native_aio' configure directive. in the Linux Native AIO, all the IO is managed by system, so proxy.config.cache.threads_per_disk have no meaning anymore. use linux native aio Key: TS-1760 URL: https://issues.apache.org/jira/browse/TS-1760 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: weijin Assignee: weijin Fix For: 3.3.2 Attachments: native_aio.patch add a feature that use linux native aio -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1760) use linux native aio
[ https://issues.apache.org/jira/browse/TS-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621067#comment-13621067 ] ASF subversion and git services commented on TS-1760: - Commit 12c478a2a71faf8bc70ea52469532c2947fde922 in branch refs/heads/master from James Peach jpe...@apache.org [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=12c478a ] TS-1760: clean up and fix --enable-linux-native-aio Tidy the --enable-linux-native-aio to conform with autoconf conventions. Use the correct TS_USE_LINUX_NATIVE_AIO macro to enable Linux AIO support. use linux native aio Key: TS-1760 URL: https://issues.apache.org/jira/browse/TS-1760 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: weijin Assignee: weijin Fix For: 3.3.2 Attachments: native_aio.patch add a feature that use linux native aio -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1760) use linux native aio
[ https://issues.apache.org/jira/browse/TS-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621157#comment-13621157 ] John Plevyak commented on TS-1760: -- This patch seems to have a latency issues and a busy wait issue.The timeout on io_getevents is 4msec which is below the threshold on some systems for busy waiting which is often 10msec. Second, it queues the events onto a handler in the same thread rather than doing the io_submit itself. Third, if the handler which calls io_getevents on an EThread, there is already another call to epoll() which is blocking the same thread. Having two calls on the same thread blocking the thread is not a good idea: they will conflict with one blocking while the other has ready data (i.e. from the net or from the disk). If io_submit is thread safe while there is an currently waiting io_getevents on another thread, then linux aio might be viable for traffic server. If io_getevents played well with epoll() then linux aio might be viable. Really, to get this to work Linux would need to have an integrated async completion API. use linux native aio Key: TS-1760 URL: https://issues.apache.org/jira/browse/TS-1760 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: weijin Assignee: weijin Fix For: 3.3.2 Attachments: native_aio.patch add a feature that use linux native aio -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1760) use linux native aio
[ https://issues.apache.org/jira/browse/TS-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619022#comment-13619022 ] James Peach commented on TS-1760: - I added the AIO unit tests to the build. They might be helpful in validating this change. It would be great to add more AIO test scripts. use linux native aio Key: TS-1760 URL: https://issues.apache.org/jira/browse/TS-1760 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: weijin Assignee: weijin Fix For: 3.3.2 Attachments: native_aio.patch add a feature that use linux native aio -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1760) use linux native aio
[ https://issues.apache.org/jira/browse/TS-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607699#comment-13607699 ] Leif Hedstrom commented on TS-1760: --- Unless there's a serious performance win, or need for this, I'd much prefer to either wait with this until v3.4.0 is released, or alternatively, make it disabled by default and configure --enable-posix-aio or some such. use linux native aio Key: TS-1760 URL: https://issues.apache.org/jira/browse/TS-1760 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: weijin Attachments: native_aio.patch add a feature that use linux native aio -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1760) use linux native aio
[ https://issues.apache.org/jira/browse/TS-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607702#comment-13607702 ] Leif Hedstrom commented on TS-1760: --- Also, why is this linux specific? Is it not standard Posix AIO ? If it is, lets refer to this as posix aio. use linux native aio Key: TS-1760 URL: https://issues.apache.org/jira/browse/TS-1760 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: weijin Attachments: native_aio.patch add a feature that use linux native aio -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1760) use linux native aio
[ https://issues.apache.org/jira/browse/TS-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607916#comment-13607916 ] Zhao Yongming commented on TS-1760: --- 1, it is a configure option: +# If the OS is linux, we can use '--use_linux_native_aio' option to +# replace the aio thread mode. Effective only on the linux system. +# 2, I think that is because that glibc aio is a user thread implement like our own AIO, and we need some performance improvement in this patch, in our testing, the cpu usage may get 5% less than origin threading AIO, and the disk hit response time may get into 5-10ms, that is much better than before. Weijin should post some more data here :D use linux native aio Key: TS-1760 URL: https://issues.apache.org/jira/browse/TS-1760 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: weijin Attachments: native_aio.patch add a feature that use linux native aio -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1760) use linux native aio
[ https://issues.apache.org/jira/browse/TS-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13608005#comment-13608005 ] Leif Hedstrom commented on TS-1760: --- Cool. Unless it's truly Linux specific, I'd prefer a different name on that config option. For example, if it's a glibc only thing, it'd be much better to call it --use-glibc-aio. If it's Posix AIO under the hood, then --use-posix-aio (you get the idea ;). Platform specific options should be avoided unless absolutely necessary IMO. use linux native aio Key: TS-1760 URL: https://issues.apache.org/jira/browse/TS-1760 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: weijin Attachments: native_aio.patch add a feature that use linux native aio -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1760) use linux native aio
[ https://issues.apache.org/jira/browse/TS-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607196#comment-13607196 ] weijin commented on TS-1760: @John, please take a time to review and test it. use linux native aio Key: TS-1760 URL: https://issues.apache.org/jira/browse/TS-1760 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: weijin Attachments: native_aio.patch add a feature that use linux native aio -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira