[jira] [Commented] (TS-1786) only enable -Werror for debug builds
[ https://issues.apache.org/jira/browse/TS-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830866#comment-13830866 ] Leif Hedstrom commented on TS-1786: --- Would it be possible to check if it's a) building in a git repo and b) the branch is named "master" ? That has the nice benefit of turning it off during e.g. a git bisect too. > only enable -Werror for debug builds > > > Key: TS-1786 > URL: https://issues.apache.org/jira/browse/TS-1786 > Project: Traffic Server > Issue Type: Bug > Components: Build >Reporter: James Peach >Assignee: James Peach > Fix For: 3.3.5 > > > It's very difficult to always build with -Werror on every platform we > support. -Werror is only valuable to developers, not so much for users. We > should consider only enabling -Werror if the build was configured with > --enable-debug. This probably involves adding autoconf macros to test whether > the compiler actually supports -Werror. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TS-1786) only enable -Werror for debug builds
[ https://issues.apache.org/jira/browse/TS-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830864#comment-13830864 ] ASF subversion and git services commented on TS-1786: - Commit a037f786111cdfc4604879e37d9bc87f1e3db82a in branch refs/heads/master from [~jpe...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=a037f78 ] Re-enable -Werror for developer builds -Werror is supposed to be enabled by default during the development cycle (see TS-1786). --enable--werror defaults to enabled if the version ends in "-dev", but the "-dev" suffix was lost during the last release cycle. > only enable -Werror for debug builds > > > Key: TS-1786 > URL: https://issues.apache.org/jira/browse/TS-1786 > Project: Traffic Server > Issue Type: Bug > Components: Build >Reporter: James Peach >Assignee: James Peach > Fix For: 3.3.5 > > > It's very difficult to always build with -Werror on every platform we > support. -Werror is only valuable to developers, not so much for users. We > should consider only enabling -Werror if the build was configured with > --enable-debug. This probably involves adding autoconf macros to test whether > the compiler actually supports -Werror. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TS-1786) only enable -Werror for debug builds
[ https://issues.apache.org/jira/browse/TS-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13692560#comment-13692560 ] ASF subversion and git services commented on TS-1786: - Commit f42c64a7d983df86ef5bfcc033220bd6dc984337 in branch refs/heads/master from [~jpe...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=f42c64a ] TS-1786: build fix for 128-bit atomics TS_TRY_COMPILE_NO_WARNING() forces us to re-add the 128-bit atomic compiler flags after we restore the saved flags. > only enable -Werror for debug builds > > > Key: TS-1786 > URL: https://issues.apache.org/jira/browse/TS-1786 > Project: Traffic Server > Issue Type: Bug > Components: Build >Reporter: James Peach >Assignee: James Peach > Fix For: 3.3.5 > > > It's very difficult to always build with -Werror on every platform we > support. -Werror is only valuable to developers, not so much for users. We > should consider only enabling -Werror if the build was configured with > --enable-debug. This probably involves adding autoconf macros to test whether > the compiler actually supports -Werror. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1786) only enable -Werror for debug builds
[ https://issues.apache.org/jira/browse/TS-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13692452#comment-13692452 ] ASF subversion and git services commented on TS-1786: - Commit 125f9d32737ef919c323ad14d5c8b73b9dbba39d in branch refs/heads/master from [~jpe...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=125f9d3 ] TS-1786: only enable -Werror for development builds Enable -Werror by default for development builds, but disable it by default for release builds. This saves users from build breakage due to platform differences and compiler changes but preserves developer discipline. > only enable -Werror for debug builds > > > Key: TS-1786 > URL: https://issues.apache.org/jira/browse/TS-1786 > Project: Traffic Server > Issue Type: Bug > Components: Build >Reporter: James Peach >Assignee: James Peach > Fix For: 3.3.5 > > > It's very difficult to always build with -Werror on every platform we > support. -Werror is only valuable to developers, not so much for users. We > should consider only enabling -Werror if the build was configured with > --enable-debug. This probably involves adding autoconf macros to test whether > the compiler actually supports -Werror. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1786) only enable -Werror for debug builds
[ https://issues.apache.org/jira/browse/TS-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689401#comment-13689401 ] James Peach commented on TS-1786: - I have a patch for this. > only enable -Werror for debug builds > > > Key: TS-1786 > URL: https://issues.apache.org/jira/browse/TS-1786 > Project: Traffic Server > Issue Type: Bug > Components: Build >Reporter: James Peach >Assignee: James Peach > Fix For: 3.3.5 > > > It's very difficult to always build with -Werror on every platform we > support. -Werror is only valuable to developers, not so much for users. We > should consider only enabling -Werror if the build was configured with > --enable-debug. This probably involves adding autoconf macros to test whether > the compiler actually supports -Werror. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1786) only enable -Werror for debug builds
[ https://issues.apache.org/jira/browse/TS-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662189#comment-13662189 ] Uri Shachar commented on TS-1786: - +1 for turning it off in the release tarball -- good idea. > only enable -Werror for debug builds > > > Key: TS-1786 > URL: https://issues.apache.org/jira/browse/TS-1786 > Project: Traffic Server > Issue Type: Bug > Components: Build >Reporter: James Peach > Fix For: 3.3.4 > > > It's very difficult to always build with -Werror on every platform we > support. -Werror is only valuable to developers, not so much for users. We > should consider only enabling -Werror if the build was configured with > --enable-debug. This probably involves adding autoconf macros to test whether > the compiler actually supports -Werror. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1786) only enable -Werror for debug builds
[ https://issues.apache.org/jira/browse/TS-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662152#comment-13662152 ] Bryan Call commented on TS-1786: I would like to see -Werror kept on for all builds in the source tree and turn it off in the release tarball (like James said). Most people don't do debug builds. I myself haven't done one in awhile. > only enable -Werror for debug builds > > > Key: TS-1786 > URL: https://issues.apache.org/jira/browse/TS-1786 > Project: Traffic Server > Issue Type: Bug > Components: Build >Reporter: James Peach > Fix For: 3.3.4 > > > It's very difficult to always build with -Werror on every platform we > support. -Werror is only valuable to developers, not so much for users. We > should consider only enabling -Werror if the build was configured with > --enable-debug. This probably involves adding autoconf macros to test whether > the compiler actually supports -Werror. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1786) only enable -Werror for debug builds
[ https://issues.apache.org/jira/browse/TS-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662073#comment-13662073 ] James Peach commented on TS-1786: - Here's another idea. Leave -Werror on in the source tree, but always turn it off in the release tarballs. This protects the majority of casual users from spurious build failures. > only enable -Werror for debug builds > > > Key: TS-1786 > URL: https://issues.apache.org/jira/browse/TS-1786 > Project: Traffic Server > Issue Type: Bug > Components: Build >Reporter: James Peach > Fix For: 3.3.4 > > > It's very difficult to always build with -Werror on every platform we > support. -Werror is only valuable to developers, not so much for users. We > should consider only enabling -Werror if the build was configured with > --enable-debug. This probably involves adding autoconf macros to test whether > the compiler actually supports -Werror. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1786) only enable -Werror for debug builds
[ https://issues.apache.org/jira/browse/TS-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616574#comment-13616574 ] Uri Shachar commented on TS-1786: - I'm concerned that this will make it too easy to miss/ignore problems -- how many people build with _--enable-debug_ before each commit? Out of the rest, how many would notice that the debug buildbot is failing. I'd suggest adding a configure.ac option to disable -Werror (something like _\--disable-werror_) - that way *all* of our buildbots will still be sensitive to compilation warnings, but users will be able to override if it causes breakage on their system. > only enable -Werror for debug builds > > > Key: TS-1786 > URL: https://issues.apache.org/jira/browse/TS-1786 > Project: Traffic Server > Issue Type: Bug > Components: Build >Reporter: James Peach > Fix For: 3.3.3 > > > It's very difficult to always build with -Werror on every platform we > support. -Werror is only valuable to developers, not so much for users. We > should consider only enabling -Werror if the build was configured with > --enable-debug. This probably involves adding autoconf macros to test whether > the compiler actually supports -Werror. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
