[jira] [Commented] (TS-2176) TSHttpTxnCacheLookupSkip doesn't work
[ https://issues.apache.org/jira/browse/TS-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13762398#comment-13762398 ] ASF subversion and git services commented on TS-2176: - Commit b1845c4be987a2d0ba331b46839c01e0f17d7666 in branch refs/heads/master from [~dennovin] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=b1845c4 ] TS-2176: do not reset value of api_skip_cache_lookup when reading it When is_request_cache_lookupable reads the value of api_skip_cache_lookup it also resets the value to false. Since the function is called from HandleRequest, the flag set by the API call will be ignored by DecideCacheLookup. TSHttpTxnCacheLookupSkip doesn't work - Key: TS-2176 URL: https://issues.apache.org/jira/browse/TS-2176 Project: Traffic Server Issue Type: Bug Components: TS API Reporter: Corey Cossentino Assignee: James Peach Fix For: 4.1.0 Attachments: ts2176_api_skip_cache_lookup.patch When {{is_request_cache_lookupable}} reads the value of {{api_skip_cache_lookup}} it also resets the value to false. Since the function is called from {{HandleRequest}}, the flag set by the API call will be ignored by {{DecideCacheLookup}}. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-2176) TSHttpTxnCacheLookupSkip doesn't work
[ https://issues.apache.org/jira/browse/TS-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13762429#comment-13762429 ] James Peach commented on TS-2176: - [~dennovin] please note that I've deprecated this API, though it will remain (and be fixed by your commit) for the duration of the 4.x release cycle. TSHttpTxnCacheLookupSkip doesn't work - Key: TS-2176 URL: https://issues.apache.org/jira/browse/TS-2176 Project: Traffic Server Issue Type: Bug Components: TS API Reporter: Corey Cossentino Assignee: James Peach Fix For: 4.1.0 Attachments: ts2176_api_skip_cache_lookup.patch When {{is_request_cache_lookupable}} reads the value of {{api_skip_cache_lookup}} it also resets the value to false. Since the function is called from {{HandleRequest}}, the flag set by the API call will be ignored by {{DecideCacheLookup}}. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-2176) TSHttpTxnCacheLookupSkip doesn't work
[ https://issues.apache.org/jira/browse/TS-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13761171#comment-13761171 ] James Peach commented on TS-2176: - I actually use TSHttpTxnConfigIntSet(TS_CONFIG_HTTP_CACHE_HTTP) to turn off the cache lookup. I will review and commit this change though. TSHttpTxnCacheLookupSkip doesn't work - Key: TS-2176 URL: https://issues.apache.org/jira/browse/TS-2176 Project: Traffic Server Issue Type: Bug Components: TS API Reporter: Corey Cossentino Assignee: James Peach Fix For: 4.1.0 Attachments: ts2176_api_skip_cache_lookup.patch When {{is_request_cache_lookupable}} reads the value of {{api_skip_cache_lookup}} it also resets the value to false. Since the function is called from {{HandleRequest}}, the flag set by the API call will be ignored by {{DecideCacheLookup}}. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-2176) TSHttpTxnCacheLookupSkip doesn't work
[ https://issues.apache.org/jira/browse/TS-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13761180#comment-13761180 ] Leif Hedstrom commented on TS-2176: --- Turning off the cache entirely (early in the state machine) is actually the most efficient way of doing this. It avoids a potential cache lookup entirely, *and* subsequent locking of cache objects. So if you know a request should never be cached, do what James does. :) TSHttpTxnCacheLookupSkip doesn't work - Key: TS-2176 URL: https://issues.apache.org/jira/browse/TS-2176 Project: Traffic Server Issue Type: Bug Components: TS API Reporter: Corey Cossentino Assignee: James Peach Fix For: 4.1.0 Attachments: ts2176_api_skip_cache_lookup.patch When {{is_request_cache_lookupable}} reads the value of {{api_skip_cache_lookup}} it also resets the value to false. Since the function is called from {{HandleRequest}}, the flag set by the API call will be ignored by {{DecideCacheLookup}}. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira