[jira] [Commented] (TS-2279) proxy.config.exec_thread.affinity's values
[
https://issues.apache.org/jira/browse/TS-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102864#comment-14102864
]
Leif Hedstrom commented on TS-2279:
---
As we discussed a few times, it feels that with the new life cycles in
traffic_server, some of this could move over there. Such as, traffic_server
knows when it's ready to serve requests (proxy), and maybe that should trigger
the start of external health checks and monitoring. A good question was brought
up, in that you don't want a life cycle to be allowed to take arbitrarily long
time, but that can probably be configured and managed in traffic_server itself,
such that it won't allow a certain life cycle to take too long.
Basically, simplify traffic_cop (maybe even eliminate all / most of it), in
favor of using Linux tools, and more intelligence in traffic_server itself.
proxy.config.exec_thread.affinity's values
--
Key: TS-2279
URL: https://issues.apache.org/jira/browse/TS-2279
Project: Traffic Server
Issue Type: Bug
Components: Configuration
Reporter: Igor Galić
Assignee: Phil Sorber
Fix For: 5.1.0
The setting of {{proxy.config.exec_thread.affinity}} only has an affect when
traffic server was compiled with {{\-\-enable-hwloc}}. It has *no* affect at
all, not even a warning about its being ineffectual when setting that value
while trafficserver is *not* configured with {{--enable-hwloc}}.
Further, mgmt/RecordsConfig.cc defines a range of {{[0-1]}}:
{code}
{RECT_CONFIG, proxy.config.exec_thread.affinity, RECD_INT, 0,
RECU_RESTART_TS, RR_NULL, RECC_INT, [0-1], RECA_READ_ONLY}
{code}
but the code uses a range of [0-3]:
{code}
#if TS_USE_HWLOC
if (affinity != 0) {
int logical_ratio;
switch(affinity) {
case 3: // assign threads to logical cores
logical_ratio = 1;
break;
case 2: // assign threads to real cores
logical_ratio = pu / cu;
break;
case 1: // assign threads to sockets
default:
logical_ratio = pu / socket;
}
{code}
And finally, 1 is the default value, rather than issuing a warning about an
incorrect value.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (TS-2279) proxy.config.exec_thread.affinity's values
[
https://issues.apache.org/jira/browse/TS-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102940#comment-14102940
]
ASF subversion and git services commented on TS-2279:
-
Commit 29f6b959c5fa9eb8b5f0340ed7b91fc33d326582 in trafficserver's branch
refs/heads/master from [~psudaemon]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=29f6b95 ]
TS-2279: Update range for proxy.config.exec_thread.affinity
proxy.config.exec_thread.affinity's values
--
Key: TS-2279
URL: https://issues.apache.org/jira/browse/TS-2279
Project: Traffic Server
Issue Type: Bug
Components: Configuration
Reporter: Igor Galić
Assignee: Phil Sorber
Fix For: 5.1.0
The setting of {{proxy.config.exec_thread.affinity}} only has an affect when
traffic server was compiled with {{\-\-enable-hwloc}}. It has *no* affect at
all, not even a warning about its being ineffectual when setting that value
while trafficserver is *not* configured with {{--enable-hwloc}}.
Further, mgmt/RecordsConfig.cc defines a range of {{[0-1]}}:
{code}
{RECT_CONFIG, proxy.config.exec_thread.affinity, RECD_INT, 0,
RECU_RESTART_TS, RR_NULL, RECC_INT, [0-1], RECA_READ_ONLY}
{code}
but the code uses a range of [0-3]:
{code}
#if TS_USE_HWLOC
if (affinity != 0) {
int logical_ratio;
switch(affinity) {
case 3: // assign threads to logical cores
logical_ratio = 1;
break;
case 2: // assign threads to real cores
logical_ratio = pu / cu;
break;
case 1: // assign threads to sockets
default:
logical_ratio = pu / socket;
}
{code}
And finally, 1 is the default value, rather than issuing a warning about an
incorrect value.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (TS-2279) proxy.config.exec_thread.affinity's values
[
https://issues.apache.org/jira/browse/TS-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103207#comment-14103207
]
Brian Rectanus commented on TS-2279:
Used to be that 1 was sockets, but now that changed to 2 and 1 is now NUMA.
This seems to mean I will need to change my config (or something will migrate
it). I would have expected NUMA to be added as a new value (4) as to not
require changes to old configs. Why did all the values shift between 4.2 and
master?
proxy.config.exec_thread.affinity's values
--
Key: TS-2279
URL: https://issues.apache.org/jira/browse/TS-2279
Project: Traffic Server
Issue Type: Bug
Components: Configuration
Reporter: Igor Galić
Assignee: Phil Sorber
Fix For: 5.1.0
The setting of {{proxy.config.exec_thread.affinity}} only has an affect when
traffic server was compiled with {{\-\-enable-hwloc}}. It has *no* affect at
all, not even a warning about its being ineffectual when setting that value
while trafficserver is *not* configured with {{--enable-hwloc}}.
Further, mgmt/RecordsConfig.cc defines a range of {{[0-1]}}:
{code}
{RECT_CONFIG, proxy.config.exec_thread.affinity, RECD_INT, 0,
RECU_RESTART_TS, RR_NULL, RECC_INT, [0-1], RECA_READ_ONLY}
{code}
but the code uses a range of [0-3]:
{code}
#if TS_USE_HWLOC
if (affinity != 0) {
int logical_ratio;
switch(affinity) {
case 3: // assign threads to logical cores
logical_ratio = 1;
break;
case 2: // assign threads to real cores
logical_ratio = pu / cu;
break;
case 1: // assign threads to sockets
default:
logical_ratio = pu / socket;
}
{code}
And finally, 1 is the default value, rather than issuing a warning about an
incorrect value.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (TS-2279) proxy.config.exec_thread.affinity's values
[
https://issues.apache.org/jira/browse/TS-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103239#comment-14103239
]
Phil Sorber commented on TS-2279:
-
[~b1v1r],
Going from 4.2 to 5.0 we are allowed to change things like this. Probably
should have documented it better though.
They are currently ordered like they are because of the hierarchy that they
represent:
One or more NUMA zones in a machine
One or more sockets in a NUMA zone
One or more cores in a socket
One or more threads (processing units) in a core
Most people really wanted NUMA when they pick socket, and on a lot of hardware
they are 1:1 anyway.
Also, in 4.2 HWLOC doesn't really do anything. There was a long standing bug
discovered after it was released and the fix was considered too invasive to
consider a back port.
proxy.config.exec_thread.affinity's values
--
Key: TS-2279
URL: https://issues.apache.org/jira/browse/TS-2279
Project: Traffic Server
Issue Type: Bug
Components: Configuration
Reporter: Igor Galić
Assignee: Phil Sorber
Fix For: 5.1.0
The setting of {{proxy.config.exec_thread.affinity}} only has an affect when
traffic server was compiled with {{\-\-enable-hwloc}}. It has *no* affect at
all, not even a warning about its being ineffectual when setting that value
while trafficserver is *not* configured with {{--enable-hwloc}}.
Further, mgmt/RecordsConfig.cc defines a range of {{[0-1]}}:
{code}
{RECT_CONFIG, proxy.config.exec_thread.affinity, RECD_INT, 0,
RECU_RESTART_TS, RR_NULL, RECC_INT, [0-1], RECA_READ_ONLY}
{code}
but the code uses a range of [0-3]:
{code}
#if TS_USE_HWLOC
if (affinity != 0) {
int logical_ratio;
switch(affinity) {
case 3: // assign threads to logical cores
logical_ratio = 1;
break;
case 2: // assign threads to real cores
logical_ratio = pu / cu;
break;
case 1: // assign threads to sockets
default:
logical_ratio = pu / socket;
}
{code}
And finally, 1 is the default value, rather than issuing a warning about an
incorrect value.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (TS-2279) proxy.config.exec_thread.affinity's values
[
https://issues.apache.org/jira/browse/TS-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096232#comment-14096232
]
Leif Hedstrom commented on TS-2279:
---
[~psudaemon] We should take a look at this before the 5.1.0 branch is frozen.
proxy.config.exec_thread.affinity's values
--
Key: TS-2279
URL: https://issues.apache.org/jira/browse/TS-2279
Project: Traffic Server
Issue Type: Bug
Components: Configuration
Reporter: Igor Galić
Assignee: Phil Sorber
Fix For: 5.1.0
The setting of {{proxy.config.exec_thread.affinity}} only has an affect when
traffic server was compiled with {{\-\-enable-hwloc}}. It has *no* affect at
all, not even a warning about its being ineffectual when setting that value
while trafficserver is *not* configured with {{--enable-hwloc}}.
Further, mgmt/RecordsConfig.cc defines a range of {{[0-1]}}:
{code}
{RECT_CONFIG, proxy.config.exec_thread.affinity, RECD_INT, 0,
RECU_RESTART_TS, RR_NULL, RECC_INT, [0-1], RECA_READ_ONLY}
{code}
but the code uses a range of [0-3]:
{code}
#if TS_USE_HWLOC
if (affinity != 0) {
int logical_ratio;
switch(affinity) {
case 3: // assign threads to logical cores
logical_ratio = 1;
break;
case 2: // assign threads to real cores
logical_ratio = pu / cu;
break;
case 1: // assign threads to sockets
default:
logical_ratio = pu / socket;
}
{code}
And finally, 1 is the default value, rather than issuing a warning about an
incorrect value.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (TS-2279) proxy.config.exec_thread.affinity's values
[
https://issues.apache.org/jira/browse/TS-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096468#comment-14096468
]
Phil Sorber commented on TS-2279:
-
[~zwoop],
I think we can add a warning easily, but this code has changed I think since
this ticket was opened.
We should update the docs.
proxy.config.exec_thread.affinity's values
--
Key: TS-2279
URL: https://issues.apache.org/jira/browse/TS-2279
Project: Traffic Server
Issue Type: Bug
Components: Configuration
Reporter: Igor Galić
Assignee: Phil Sorber
Fix For: 5.1.0
The setting of {{proxy.config.exec_thread.affinity}} only has an affect when
traffic server was compiled with {{\-\-enable-hwloc}}. It has *no* affect at
all, not even a warning about its being ineffectual when setting that value
while trafficserver is *not* configured with {{--enable-hwloc}}.
Further, mgmt/RecordsConfig.cc defines a range of {{[0-1]}}:
{code}
{RECT_CONFIG, proxy.config.exec_thread.affinity, RECD_INT, 0,
RECU_RESTART_TS, RR_NULL, RECC_INT, [0-1], RECA_READ_ONLY}
{code}
but the code uses a range of [0-3]:
{code}
#if TS_USE_HWLOC
if (affinity != 0) {
int logical_ratio;
switch(affinity) {
case 3: // assign threads to logical cores
logical_ratio = 1;
break;
case 2: // assign threads to real cores
logical_ratio = pu / cu;
break;
case 1: // assign threads to sockets
default:
logical_ratio = pu / socket;
}
{code}
And finally, 1 is the default value, rather than issuing a warning about an
incorrect value.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
