[jira] [Commented] (TS-2325) remap.config .include should support directories
[ https://issues.apache.org/jira/browse/TS-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13831102#comment-13831102 ] Leif Hedstrom commented on TS-2325: --- James, you taking this one ? > remap.config .include should support directories > > > Key: TS-2325 > URL: https://issues.apache.org/jira/browse/TS-2325 > Project: Traffic Server > Issue Type: Improvement > Components: Configuration, Core >Reporter: James Peach > Fix For: 4.2.0 > > > The remap.config .include directive should support including a directory. The > implementation for this would be to simply read all the files in the > directory and include each one. > I don't think the files in the directory should be sorted, since that > requires us to read all the names into memory, and there might be a very > large number of them. Typical ordering constraints can be expressed using > multiple directories. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TS-2325) remap.config .include should support directories
[ https://issues.apache.org/jira/browse/TS-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540541#comment-14540541 ] Leif Hedstrom commented on TS-2325: --- Over to [~jpe...@apache.org] again, sorry for the delays. > remap.config .include should support directories > > > Key: TS-2325 > URL: https://issues.apache.org/jira/browse/TS-2325 > Project: Traffic Server > Issue Type: Improvement > Components: Configuration, Core >Reporter: James Peach >Assignee: James Peach > Labels: review > Fix For: 6.0.0 > > Attachments: ts2325.diff > > > The remap.config .include directive should support including a directory. The > implementation for this would be to simply read all the files in the > directory and include each one. > I don't think the files in the directory should be sorted, since that > requires us to read all the names into memory, and there might be a very > large number of them. Typical ordering constraints can be expressed using > multiple directories. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2325) remap.config .include should support directories
[ https://issues.apache.org/jira/browse/TS-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578328#comment-14578328 ] ASF subversion and git services commented on TS-2325: - Commit 3bcdd50225c581bd2e34fdef07f33e04dadd3240 in trafficserver's branch refs/heads/master from [~maskit] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=3bcdd50 ] TS-2325: remap.config .include should support directories > remap.config .include should support directories > > > Key: TS-2325 > URL: https://issues.apache.org/jira/browse/TS-2325 > Project: Traffic Server > Issue Type: Improvement > Components: Configuration, Core >Reporter: James Peach >Assignee: James Peach > Labels: review > Fix For: 6.0.0 > > Attachments: ts2325.diff > > > The remap.config .include directive should support including a directory. The > implementation for this would be to simply read all the files in the > directory and include each one. > I don't think the files in the directory should be sorted, since that > requires us to read all the names into memory, and there might be a very > large number of them. Typical ordering constraints can be expressed using > multiple directories. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2325) remap.config .include should support directories
[ https://issues.apache.org/jira/browse/TS-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352370#comment-14352370 ] Leif Hedstrom commented on TS-2325: --- James, do we want to land this before 5.3.0 branch (imminent) or land for 6.0.0 ? > remap.config .include should support directories > > > Key: TS-2325 > URL: https://issues.apache.org/jira/browse/TS-2325 > Project: Traffic Server > Issue Type: Improvement > Components: Configuration, Core >Reporter: James Peach >Assignee: Leif Hedstrom > Labels: review > Fix For: 6.0.0 > > Attachments: ts2325.diff > > > The remap.config .include directive should support including a directory. The > implementation for this would be to simply read all the files in the > directory and include each one. > I don't think the files in the directory should be sorted, since that > requires us to read all the names into memory, and there might be a very > large number of them. Typical ordering constraints can be expressed using > multiple directories. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2325) remap.config .include should support directories
[ https://issues.apache.org/jira/browse/TS-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14354226#comment-14354226 ] James Peach commented on TS-2325: - I'll review and land this on Friday (please poke me). I would like to add a config option to make the sorting optional (enabled by default) because I guarantee that someone will use this with a foolishly large number entries in a directory. > remap.config .include should support directories > > > Key: TS-2325 > URL: https://issues.apache.org/jira/browse/TS-2325 > Project: Traffic Server > Issue Type: Improvement > Components: Configuration, Core >Reporter: James Peach >Assignee: Leif Hedstrom > Labels: review > Fix For: 6.0.0 > > Attachments: ts2325.diff > > > The remap.config .include directive should support including a directory. The > implementation for this would be to simply read all the files in the > directory and include each one. > I don't think the files in the directory should be sorted, since that > requires us to read all the names into memory, and there might be a very > large number of them. Typical ordering constraints can be expressed using > multiple directories. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2325) remap.config .include should support directories
[ https://issues.apache.org/jira/browse/TS-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170857#comment-14170857 ] Masakazu Kitajo commented on TS-2325: - I chose readdir_r once, but I replaced it with scandir because readdir doesn't guarantee any ordering. How can I get directory entries in typical order? > remap.config .include should support directories > > > Key: TS-2325 > URL: https://issues.apache.org/jira/browse/TS-2325 > Project: Traffic Server > Issue Type: Improvement > Components: Configuration, Core >Reporter: James Peach > Fix For: 5.2.0 > > Attachments: ts2325.diff > > > The remap.config .include directive should support including a directory. The > implementation for this would be to simply read all the files in the > directory and include each one. > I don't think the files in the directory should be sorted, since that > requires us to read all the names into memory, and there might be a very > large number of them. Typical ordering constraints can be expressed using > multiple directories. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2325) remap.config .include should support directories
[ https://issues.apache.org/jira/browse/TS-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170935#comment-14170935 ] Leif Hedstrom commented on TS-2325: --- Couldn't you just use e.g. qsort() manually ? Or, perhaps better, load the names into one of our containers (such as Vec), which has qsort() as member methods. > remap.config .include should support directories > > > Key: TS-2325 > URL: https://issues.apache.org/jira/browse/TS-2325 > Project: Traffic Server > Issue Type: Improvement > Components: Configuration, Core >Reporter: James Peach > Fix For: 5.2.0 > > Attachments: ts2325.diff > > > The remap.config .include directive should support including a directory. The > implementation for this would be to simply read all the files in the > directory and include each one. > I don't think the files in the directory should be sorted, since that > requires us to read all the names into memory, and there might be a very > large number of them. Typical ordering constraints can be expressed using > multiple directories. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2325) remap.config .include should support directories
[ https://issues.apache.org/jira/browse/TS-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171074#comment-14171074 ] Masakazu Kitajo commented on TS-2325: - It seems scandir() uses qsort() internally. alphasort() is just a comparison function passed to qsort(). I don't see a benefit of using qsort() manually. I found some memory leaks. I'll fix them tomorrow. It might be a reason for using Vec. > remap.config .include should support directories > > > Key: TS-2325 > URL: https://issues.apache.org/jira/browse/TS-2325 > Project: Traffic Server > Issue Type: Improvement > Components: Configuration, Core >Reporter: James Peach > Fix For: 5.2.0 > > Attachments: ts2325.diff > > > The remap.config .include directive should support including a directory. The > implementation for this would be to simply read all the files in the > directory and include each one. > I don't think the files in the directory should be sorted, since that > requires us to read all the names into memory, and there might be a very > large number of them. Typical ordering constraints can be expressed using > multiple directories. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2325) remap.config .include should support directories
[ https://issues.apache.org/jira/browse/TS-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171089#comment-14171089 ] Leif Hedstrom commented on TS-2325: --- The issue would be that scandir() might not be available on all platforms. > remap.config .include should support directories > > > Key: TS-2325 > URL: https://issues.apache.org/jira/browse/TS-2325 > Project: Traffic Server > Issue Type: Improvement > Components: Configuration, Core >Reporter: James Peach > Fix For: 5.2.0 > > Attachments: ts2325.diff > > > The remap.config .include directive should support including a directory. The > implementation for this would be to simply read all the files in the > directory and include each one. > I don't think the files in the directory should be sorted, since that > requires us to read all the names into memory, and there might be a very > large number of them. Typical ordering constraints can be expressed using > multiple directories. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2325) remap.config .include should support directories
[ https://issues.apache.org/jira/browse/TS-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173473#comment-14173473 ] Masakazu Kitajo commented on TS-2325: - My question was what the typical ordering constraints is, and I was asking a way to get the entries in the ordering. Now I'm understanding it is alphabetical order. alphasort() and scandir() are specified in POSIX.1-2008, so I believe these are available on all platforms. > remap.config .include should support directories > > > Key: TS-2325 > URL: https://issues.apache.org/jira/browse/TS-2325 > Project: Traffic Server > Issue Type: Improvement > Components: Configuration, Core >Reporter: James Peach > Fix For: 5.2.0 > > Attachments: ts2325.diff > > > The remap.config .include directive should support including a directory. The > implementation for this would be to simply read all the files in the > directory and include each one. > I don't think the files in the directory should be sorted, since that > requires us to read all the names into memory, and there might be a very > large number of them. Typical ordering constraints can be expressed using > multiple directories. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2325) remap.config .include should support directories
[ https://issues.apache.org/jira/browse/TS-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205871#comment-14205871 ] Masakazu Kitajo commented on TS-2325: - Why is this postponed to 6.0? I think it doesn't break any compatibility. > remap.config .include should support directories > > > Key: TS-2325 > URL: https://issues.apache.org/jira/browse/TS-2325 > Project: Traffic Server > Issue Type: Improvement > Components: Configuration, Core >Reporter: James Peach > Fix For: 6.0.0 > > Attachments: ts2325.diff > > > The remap.config .include directive should support including a directory. The > implementation for this would be to simply read all the files in the > directory and include each one. > I don't think the files in the directory should be sorted, since that > requires us to read all the names into memory, and there might be a very > large number of them. Typical ordering constraints can be expressed using > multiple directories. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2325) remap.config .include should support directories
[ https://issues.apache.org/jira/browse/TS-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205973#comment-14205973 ] Leif Hedstrom commented on TS-2325: --- Yeah, not sure why it got moved out, moved it to 5.2.0. > remap.config .include should support directories > > > Key: TS-2325 > URL: https://issues.apache.org/jira/browse/TS-2325 > Project: Traffic Server > Issue Type: Improvement > Components: Configuration, Core >Reporter: James Peach >Assignee: Leif Hedstrom > Labels: review > Fix For: 5.2.0 > > Attachments: ts2325.diff > > > The remap.config .include directive should support including a directory. The > implementation for this would be to simply read all the files in the > directory and include each one. > I don't think the files in the directory should be sorted, since that > requires us to read all the names into memory, and there might be a very > large number of them. Typical ordering constraints can be expressed using > multiple directories. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
