[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008287#comment-14008287 ] ASF subversion and git services commented on TS-2555: - Commit 14c484b414ea3be02bc5aebee650cb626fc6cc58 in trafficserver's branch refs/heads/master from [~kichan] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=14c484b ] TS-2555: more features for ts_lua - support function to add global hook, use TSError, support TSSkipRemappingSet Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008292#comment-14008292 ] Kit Chan commented on TS-2555: -- Based on feedbacks, the last commit contains the following fixes 1) We can use ts.hook to add global hook instead of using global functions 2) We do not always add TXN_CLOSE_HOOK handler to release resources unless needed 3) We add support for TSSkipRemappingSet 4) We use TSError 5) Documentation is updated. Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008295#comment-14008295 ] ASF subversion and git services commented on TS-2555: - Commit 9a3e5de5f2009921436069b3393a133e0c23d5d1 in trafficserver's branch refs/heads/master from [~kichan] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=9a3e5de ] TS-2555: update README.md and remove old lua plugin Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008298#comment-14008298 ] ASF subversion and git services commented on TS-2555: - Commit b304cf0c16a7f8e47d10e499874c283fa3ba420b in trafficserver's branch refs/heads/master from [~kichan] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=b304cf0 ] TS-2555: update README.md for ts_lua plugin Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004349#comment-14004349 ] ASF subversion and git services commented on TS-2555: - Commit 2ba2baaa69c2bb99dfa95c783a79ec0165690c31 in trafficserver's branch refs/heads/master from [~kichan] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=2ba2baa ] TS-2555: add more hook support for ts_lua plugin Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13995677#comment-13995677 ] ASF subversion and git services commented on TS-2555: - Commit 63400cb4f75873c92352eadecf4510d8893782da in trafficserver's branch refs/heads/master from [~kichan] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=63400cb ] TS-2555: fix TSMBuffer and TSMLoc allocation problem for client request in ts_lua plugin Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13989895#comment-13989895 ] ASF subversion and git services commented on TS-2555: - Commit 3f0bb5bf82e994431245633f67e47c8260425e74 in trafficserver's branch refs/heads/master from [~kichan] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=3f0bb5b ] TS-2555: fix to keep same context for a transaction Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13989221#comment-13989221 ] ASF subversion and git services commented on TS-2555: - Commit 5b1535e399aa450eeb1c75e43c2398042036c363 in trafficserver's branch refs/heads/master from [~kichan] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=5b1535e ] TS-2555: updates to share lua context across hook invocations and only add global hooks if corresponding lua functions exist Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13989224#comment-13989224 ] Kit Chan commented on TS-2555: -- I think now the only thing that lua plugin can do but not ts-lua plugin is the ability to 1) support session hooks 2) support more type of global and transaction hooks, such as pre-remap and post-remap I can create JIRA to add those support later. But I think we can close this bug by removing the lua plugin from repository. Any comments/suggestions? Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13989231#comment-13989231 ] ASF subversion and git services commented on TS-2555: - Commit 5da3a4b90fa8d1e20ffa8349ee985d19ba5800cc in trafficserver's branch refs/heads/master from [~kichan] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=5da3a4b ] TS-2555: fix build failure related to unused variable Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970471#comment-13970471 ] ASF subversion and git services commented on TS-2555: - Commit e350291161f291ddcd70442edcbf2f916cb232d3 in trafficserver's branch refs/heads/master from [~kichan] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=e350291 ] TS-2555 Add to CHANGES Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970545#comment-13970545 ] ASF subversion and git services commented on TS-2555: - Commit 01be17ecd6ec47b493366feb755db9998bb9146e in trafficserver's branch refs/heads/master from [~kichan] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=01be17e ] TS-2555 adding example and documentation Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970450#comment-13970450 ] ASF subversion and git services commented on TS-2555: - Commit 904e1f7c2995dbb4a8afea7cd99e32f0fd844f46 in trafficserver's branch refs/heads/master from [~kichan] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=904e1f7 ] TS-2555 add global plugin support for ts_lua plugin Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967980#comment-13967980 ] ASF subversion and git services commented on TS-2555: - Commit d3b6c1190e2633bc20a8c1cbd49b8ea1a211c21e in trafficserver's branch refs/heads/master from [~kichan] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=d3b6c11 ] [TS-2555] correct documentation with the correct plugin usage Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965427#comment-13965427 ] Kit Chan commented on TS-2555: -- Another thing I am currently finishing up is to provide support for writing global plugin instead of only able to write remap plugin. Will add that on as well as consider Faysal's comments above Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963938#comment-13963938 ] portl4t commented on TS-2555: - OK, I will provide a patch later. Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964371#comment-13964371 ] Faysal Banna commented on TS-2555: -- how is it possible to get portl4t's code manually into master ? Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964460#comment-13964460 ] James Peach commented on TS-2555: - +1 on updating ts-lua. I don't know if there's anything in the old lua plugin worth rescuing. ts-lua is clearly the way forward. Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[
https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964589#comment-13964589
]
Faysal Banna commented on TS-2555:
--
+1 on updating ts-lua. but some issues needs to be addressed before i believe.
ts-lua that portl4t notes uses Lua-5.1 while The last release was Lua 5.1.5,
released on 17 Feb 2012.
New systems mostly come with Lua-5.2 The current release is Lua 5.2.3, released
on 07 Dec 2013 and initial 5.2 release was 16 Dec 2011.
taking into consideration the compilation issues that arises between two
versions as i had while was compiling it on Fedora-20.
code
ts_lua_util.c: In function ‘ts_lua_create_vm’:
ts_lua_util.c:57:26: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_pushvalue(L, LUA_GLOBALSINDEX);
^
ts_lua_util.c:57:26: note: each undeclared identifier is reported only once for
each function it appears in
ts_lua_util.c: In function ‘ts_lua_add_module’:
ts_lua_util.c:126:24: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_replace(L, LUA_GLOBALSINDEX); /* L[GLOBAL] = TB1
*/
^
ts_lua_util.c: In function ‘ts_lua_del_module’:
ts_lua_util.c:213:24: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_replace(L, LUA_GLOBALSINDEX); /* L[GLOBAL] =
L[REG][conf] */
^
ts_lua_util.c: In function ‘ts_lua_set_instance_conf’:
ts_lua_util.c:312:19: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_rawset(L, LUA_GLOBALSINDEX);
^
ts_lua_util.c: In function ‘ts_lua_get_instance_conf’:
ts_lua_util.c:321:19: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_rawget(L, LUA_GLOBALSINDEX);
^
ts_lua_util.c: In function ‘ts_lua_set_http_ctx’:
ts_lua_util.c:334:19: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_rawset(L, LUA_GLOBALSINDEX);
^
ts_lua_util.c: In function ‘ts_lua_get_http_ctx’:
ts_lua_util.c:343:19: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_rawget(L, LUA_GLOBALSINDEX);
^
ts_lua_util.c: In function ‘ts_lua_create_http_ctx’:
ts_lua_util.c:383:20: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_replace(l, LUA_GLOBALSINDEX);
^
ts_lua_util.c: In function ‘ts_lua_set_http_intercept_ctx’:
ts_lua_util.c:435:19: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_rawset(L, LUA_GLOBALSINDEX);
^
ts_lua_util.c: In function ‘ts_lua_get_http_intercept_ctx’:
ts_lua_util.c:444:19: error: ‘LUA_GLOBALSINDEX’ undeclared (first use in this
function)
lua_rawget(L, LUA_GLOBALSINDEX);
^
make: *** [ts_lua_util.lo] Error 1
/code
while current ts-lua compiles without any errors with luajit enabled and
experimental-plugins enabled for both lua-5.1 and lua-5.2
also had to face an issue which i believe could be resolved easily once those
issues cleared off which is
code
[Apr 9 22:03:06.067] Server {0x40093a00} WARNING: Could not add rule at line
#195; Aborting!
[Apr 9 22:03:06.067] Server {0x40093a00} WARNING: [ReverseProxy] Can't load
plugin /usr/local/libexec/trafficserver/libtslua.so -
/usr/local/libexec/trafficserver/libtslua.so: undefined symbol: lua_tointegerx
at line 195
[Apr 9 22:03:06.067] Server {0x40093a00} WARNING: something failed during
BuildTable() -- check your remap plugins!
[Apr 9 22:03:06.067] Server {0x40093a00} WARNING: Can not load the remap
table, exiting out!
/code
other than this i recommend the update as the features in portl4t's libtslua
plugin is great for the needs of modern dynamic cache system and eliminates the
need for any cacheurl or header_rewrite plugin and thus combine config files in
much one place easier to track and easier to maintain
Much Regards
Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
---
Key: TS-2555
URL: https://issues.apache.org/jira/browse/TS-2555
Project: Traffic Server
Issue Type: Task
Components: Plugins
Reporter: Kit Chan
Assignee: Kit Chan
Fix For: 5.0.0
As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we
could move move the old Lua plugin to plugins/deprecated, and name this one
lua again from the start. From what I gather, the consensus on the mailing
list was to replace the old plugin with this one.
Given that the old plugin was experimental, and we've decided that all bets
regarding compatibility and stability are off in experimental, I'm fairly
certain we can just do that. I'd move it, for easy
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963709#comment-13963709 ] portl4t commented on TS-2555: - Hi, all. I had add many features to ts-lua on https://github.com/portl4t/ts-lua. I don't know whether I should add these features to experimental/ts_lua. What's the progress of this issue now? Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963714#comment-13963714 ] Leif Hedstrom commented on TS-2555: --- It'd be fine to make pull requests against ts-lua, until Kit gets a chance to close this one and deprecate the old Lua. I'm making an assumption here that there's not going to be an interest in merging the old Lua code into the new one? Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963785#comment-13963785 ] Kit Chan commented on TS-2555: -- I have been making progress in listing the gaps of features between the two and make sure ts_lua will contain all of the functionality of the old Lua before deprecating it. And I will definitely ask that question in the mailing list before doing so. portl4t, I also have been paying attention to changes in your github repository. There are indeed a lot of functionality you have added. I think you can make pull requests against ts_lua as Leif suggested or file jira ticket with the patch. Either way is fine. I can help to review and merge it in. Thanks. Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2555) Move existing lua plugin to plugins/deprecated and rename ts_lua to lua
[ https://issues.apache.org/jira/browse/TS-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963791#comment-13963791 ] Leif Hedstrom commented on TS-2555: --- To minimize confusion right now, maybe we should turn off building the old plugin? Move existing lua plugin to plugins/deprecated and rename ts_lua to lua --- Key: TS-2555 URL: https://issues.apache.org/jira/browse/TS-2555 Project: Traffic Server Issue Type: Task Components: Plugins Reporter: Kit Chan Assignee: Kit Chan Fix For: 5.0.0 As suggested by Igor Galic in TS-2335, to avoid namespace pollution, we could move move the old Lua plugin to plugins/deprecated, and name this one lua again from the start. From what I gather, the consensus on the mailing list was to replace the old plugin with this one. Given that the old plugin was experimental, and we've decided that all bets regarding compatibility and stability are off in experimental, I'm fairly certain we can just do that. I'd move it, for easy reference into plugins/deprecated, remove it from the build, and once the new plugin has absorbed all of its features, remove it all together. -- This message was sent by Atlassian JIRA (v6.2#6252)
