[jira] [Commented] (TS-2685) TSHttpEventNameLookup can't lookup TSEvent values
[
https://issues.apache.org/jira/browse/TS-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14369612#comment-14369612
]
Leif Hedstrom commented on TS-2685:
---
Yeah, so maybe move this out of the "newbie" area then? :)
> TSHttpEventNameLookup can't lookup TSEvent values
> -
>
> Key: TS-2685
> URL: https://issues.apache.org/jira/browse/TS-2685
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
>Reporter: James Peach
>Assignee: Meera Mosale Nataraja
> Labels: newbie
> Fix For: 6.0.0
>
>
> {{TSHttpEventNameLookup}} can't look up {{TSEvent}} values, see the
> implementation of {{HttpDebugNames::get_event_name}}.
> It would also be pretty neat if it formatted the event class if it didn't
> know about the specific event, e.g. {{ICP_EVENT_EVENTS_START+22}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-2685) TSHttpEventNameLookup can't lookup TSEvent values
[
https://issues.apache.org/jira/browse/TS-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14369514#comment-14369514
]
Alan M. Carroll commented on TS-2685:
-
I think we should just put the extra cases in the functions for now and create
another bug for doing the rationalization which, as you note, is a more complex
issue.
> TSHttpEventNameLookup can't lookup TSEvent values
> -
>
> Key: TS-2685
> URL: https://issues.apache.org/jira/browse/TS-2685
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
>Reporter: James Peach
>Assignee: Meera Mosale Nataraja
> Labels: newbie
> Fix For: 6.0.0
>
>
> {{TSHttpEventNameLookup}} can't look up {{TSEvent}} values, see the
> implementation of {{HttpDebugNames::get_event_name}}.
> It would also be pretty neat if it formatted the event class if it didn't
> know about the specific event, e.g. {{ICP_EVENT_EVENTS_START+22}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-2685) TSHttpEventNameLookup can't lookup TSEvent values
[
https://issues.apache.org/jira/browse/TS-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368456#comment-14368456
]
James Peach commented on TS-2685:
-
Yes that's true. I just think that there's more subtle issues here than the
newbie label implies.
> TSHttpEventNameLookup can't lookup TSEvent values
> -
>
> Key: TS-2685
> URL: https://issues.apache.org/jira/browse/TS-2685
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
>Reporter: James Peach
>Assignee: Meera Mosale Nataraja
> Labels: newbie
> Fix For: 6.0.0
>
>
> {{TSHttpEventNameLookup}} can't look up {{TSEvent}} values, see the
> implementation of {{HttpDebugNames::get_event_name}}.
> It would also be pretty neat if it formatted the event class if it didn't
> know about the specific event, e.g. {{ICP_EVENT_EVENTS_START+22}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-2685) TSHttpEventNameLookup can't lookup TSEvent values
[
https://issues.apache.org/jira/browse/TS-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368318#comment-14368318
]
Alan M. Carroll commented on TS-2685:
-
James - on the other hand, putting all of these names in a single function also
implies centralization of event codes, if not to the same degree.
> TSHttpEventNameLookup can't lookup TSEvent values
> -
>
> Key: TS-2685
> URL: https://issues.apache.org/jira/browse/TS-2685
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
>Reporter: James Peach
>Assignee: Meera Mosale Nataraja
> Labels: newbie
> Fix For: 6.0.0
>
>
> {{TSHttpEventNameLookup}} can't look up {{TSEvent}} values, see the
> implementation of {{HttpDebugNames::get_event_name}}.
> It would also be pretty neat if it formatted the event class if it didn't
> know about the specific event, e.g. {{ICP_EVENT_EVENTS_START+22}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-2685) TSHttpEventNameLookup can't lookup TSEvent values
[
https://issues.apache.org/jira/browse/TS-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367525#comment-14367525
]
bwahn commented on TS-2685:
---
Ah~ It's already have a ticket. It would be add a typedef.
> TSHttpEventNameLookup can't lookup TSEvent values
> -
>
> Key: TS-2685
> URL: https://issues.apache.org/jira/browse/TS-2685
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
>Reporter: James Peach
>Assignee: Meera Mosale Nataraja
> Labels: newbie
> Fix For: 6.0.0
>
>
> {{TSHttpEventNameLookup}} can't look up {{TSEvent}} values, see the
> implementation of {{HttpDebugNames::get_event_name}}.
> It would also be pretty neat if it formatted the event class if it didn't
> know about the specific event, e.g. {{ICP_EVENT_EVENTS_START+22}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-2685) TSHttpEventNameLookup can't lookup TSEvent values
[
https://issues.apache.org/jira/browse/TS-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367509#comment-14367509
]
James Peach commented on TS-2685:
-
In principle that's an improvement (there is another ticket about that
somewhere). However that does imply centralization of event code, which is
problematic. An intermediate improvement would be just to add a typedef for
event IDs.
> TSHttpEventNameLookup can't lookup TSEvent values
> -
>
> Key: TS-2685
> URL: https://issues.apache.org/jira/browse/TS-2685
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
>Reporter: James Peach
>Assignee: Meera Mosale Nataraja
> Labels: newbie
> Fix For: 6.0.0
>
>
> {{TSHttpEventNameLookup}} can't look up {{TSEvent}} values, see the
> implementation of {{HttpDebugNames::get_event_name}}.
> It would also be pretty neat if it formatted the event class if it didn't
> know about the specific event, e.g. {{ICP_EVENT_EVENTS_START+22}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-2685) TSHttpEventNameLookup can't lookup TSEvent values
[
https://issues.apache.org/jira/browse/TS-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367473#comment-14367473
]
bwahn commented on TS-2685:
---
[~jpe...@apache.org], [~amc]
How do you think if #define replace into enum?
> TSHttpEventNameLookup can't lookup TSEvent values
> -
>
> Key: TS-2685
> URL: https://issues.apache.org/jira/browse/TS-2685
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
>Reporter: James Peach
>Assignee: Meera Mosale Nataraja
> Labels: newbie
> Fix For: 6.0.0
>
>
> {{TSHttpEventNameLookup}} can't look up {{TSEvent}} values, see the
> implementation of {{HttpDebugNames::get_event_name}}.
> It would also be pretty neat if it formatted the event class if it didn't
> know about the specific event, e.g. {{ICP_EVENT_EVENTS_START+22}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-2685) TSHttpEventNameLookup can't lookup TSEvent values
[
https://issues.apache.org/jira/browse/TS-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367336#comment-14367336
]
Eric Ahn commented on TS-2685:
--
It's originally from I_Event.h I_VConnection.h. and It may be more clearly
defined.
> TSHttpEventNameLookup can't lookup TSEvent values
> -
>
> Key: TS-2685
> URL: https://issues.apache.org/jira/browse/TS-2685
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
>Reporter: James Peach
>Assignee: Meera Mosale Nataraja
> Labels: newbie
> Fix For: 6.0.0
>
>
> {{TSHttpEventNameLookup}} can't look up {{TSEvent}} values, see the
> implementation of {{HttpDebugNames::get_event_name}}.
> It would also be pretty neat if it formatted the event class if it didn't
> know about the specific event, e.g. {{ICP_EVENT_EVENTS_START+22}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-2685) TSHttpEventNameLookup can't lookup TSEvent values
[
https://issues.apache.org/jira/browse/TS-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970168#comment-13970168
]
James Peach commented on TS-2685:
-
FWIW, there is a partial event name lookup table in {{proxy/EventName.cc}}. We
should rationalize that too.
> TSHttpEventNameLookup can't lookup TSEvent values
> -
>
> Key: TS-2685
> URL: https://issues.apache.org/jira/browse/TS-2685
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
>Reporter: James Peach
> Fix For: 5.0.0
>
>
> {{TSHttpEventNameLookup}} can't look up {{TSEvent}} values, see the
> implementation of {{HttpDebugNames::get_event_name}}.
> It would also be pretty neat if it formatted the event class if it didn't
> know about the specific event, e.g. {{ICP_EVENT_EVENTS_START+22}}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
