[jira] [Commented] (TS-2746) undo accept continuation renaming
[ https://issues.apache.org/jira/browse/TS-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983589#comment-13983589 ] ASF subversion and git services commented on TS-2746: - Commit 20eb9adbb6bfaeaebc26d552afd3ee816e778dc6 in trafficserver's branch refs/heads/master from [~jpe...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=20eb9ad ] TS-2746: rename ProtocolAcceptCont to ProtocolProbeSessionAccept undo accept continuation renaming - Key: TS-2746 URL: https://issues.apache.org/jira/browse/TS-2746 Project: Traffic Server Issue Type: Bug Components: Cleanup, SPDY Reporter: James Peach Assignee: James Peach Fix For: 5.0.0 In TS-2431, all the FooAccept handlers were renamed to FooAcceptCont. If we added the Cont suffix to everything that was a continuation, there would be no other suffixes. We should undo this, or find a new naming convention. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2746) undo accept continuation renaming
[ https://issues.apache.org/jira/browse/TS-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983590#comment-13983590 ] ASF subversion and git services commented on TS-2746: - Commit 7f036b4a5a07f2c84ecb6644f3ec843f295bb67f in trafficserver's branch refs/heads/master from [~jpe...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=7f036b4 ] TS-2746: remove the P_ prefix from SPDY headers undo accept continuation renaming - Key: TS-2746 URL: https://issues.apache.org/jira/browse/TS-2746 Project: Traffic Server Issue Type: Bug Components: Cleanup, SPDY Reporter: James Peach Assignee: James Peach Fix For: 5.0.0 In TS-2431, all the FooAccept handlers were renamed to FooAcceptCont. If we added the Cont suffix to everything that was a continuation, there would be no other suffixes. We should undo this, or find a new naming convention. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2746) undo accept continuation renaming
[ https://issues.apache.org/jira/browse/TS-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983591#comment-13983591 ] ASF subversion and git services commented on TS-2746: - Commit 81390c57b0563b9b603e543e7e2dfdbf37738c75 in trafficserver's branch refs/heads/master from [~jpe...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=81390c5 ] TS-2746: CHANGES undo accept continuation renaming - Key: TS-2746 URL: https://issues.apache.org/jira/browse/TS-2746 Project: Traffic Server Issue Type: Bug Components: Cleanup, SPDY Reporter: James Peach Assignee: James Peach Fix For: 5.0.0 In TS-2431, all the FooAccept handlers were renamed to FooAcceptCont. If we added the Cont suffix to everything that was a continuation, there would be no other suffixes. We should undo this, or find a new naming convention. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2746) undo accept continuation renaming
[ https://issues.apache.org/jira/browse/TS-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983587#comment-13983587 ] ASF subversion and git services commented on TS-2746: - Commit 0d988fd9e0f9f381d5543c9a9d990978bed4966e in trafficserver's branch refs/heads/master from [~jpe...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=0d988fd ] TS-2746: rename HttpAcceptCont to HttpSessionAccept undo accept continuation renaming - Key: TS-2746 URL: https://issues.apache.org/jira/browse/TS-2746 Project: Traffic Server Issue Type: Bug Components: Cleanup, SPDY Reporter: James Peach Assignee: James Peach Fix For: 5.0.0 In TS-2431, all the FooAccept handlers were renamed to FooAcceptCont. If we added the Cont suffix to everything that was a continuation, there would be no other suffixes. We should undo this, or find a new naming convention. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2746) undo accept continuation renaming
[ https://issues.apache.org/jira/browse/TS-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983925#comment-13983925 ] Yunkai Zhang commented on TS-2746: -- nice naming. undo accept continuation renaming - Key: TS-2746 URL: https://issues.apache.org/jira/browse/TS-2746 Project: Traffic Server Issue Type: Bug Components: Cleanup, SPDY Reporter: James Peach Assignee: James Peach Fix For: 5.0.0 In TS-2431, all the FooAccept handlers were renamed to FooAcceptCont. If we added the Cont suffix to everything that was a continuation, there would be no other suffixes. We should undo this, or find a new naming convention. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2746) undo accept continuation renaming
[
https://issues.apache.org/jira/browse/TS-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979966#comment-13979966
]
James Peach commented on TS-2746:
-
{{AcceptCont::createNetAccept}} is needed by {{ProtocolNetAccept}}, but I don't
think that whole thing is needed.
undo accept continuation renaming
-
Key: TS-2746
URL: https://issues.apache.org/jira/browse/TS-2746
Project: Traffic Server
Issue Type: Bug
Components: Cleanup, SPDY
Reporter: James Peach
Assignee: James Peach
Fix For: 5.0.0
In TS-2431, all the FooAccept handlers were renamed to FooAcceptCont. If we
added the Cont suffix to everything that was a continuation, there would be
no other suffixes. We should undo this, or find a new naming convention.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (TS-2746) undo accept continuation renaming
[ https://issues.apache.org/jira/browse/TS-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980262#comment-13980262 ] James Peach commented on TS-2746: - Patch pending. This also removes the P_ prefix from the SPDY header files, since that convention is only perpetrated by iocore. undo accept continuation renaming - Key: TS-2746 URL: https://issues.apache.org/jira/browse/TS-2746 Project: Traffic Server Issue Type: Bug Components: Cleanup, SPDY Reporter: James Peach Assignee: James Peach Fix For: 5.0.0 In TS-2431, all the FooAccept handlers were renamed to FooAcceptCont. If we added the Cont suffix to everything that was a continuation, there would be no other suffixes. We should undo this, or find a new naming convention. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2746) undo accept continuation renaming
[
https://issues.apache.org/jira/browse/TS-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979310#comment-13979310
]
James Peach commented on TS-2746:
-
I think that SessionAccept is a reasonably descriptive name, so I propose
HttpAcceptCont - HttpSessionAccept
SpdyAcceptCont - SpdySessionAccept
ProtocolAcceptCont - ProtocolDetectSessionAccept
I don't think that {{AcceptCont::createNetAccept}} is needed; the processor has
an equivalent virtual function that creates the correct kind of {{NetAccept}}.
undo accept continuation renaming
-
Key: TS-2746
URL: https://issues.apache.org/jira/browse/TS-2746
Project: Traffic Server
Issue Type: Bug
Components: Cleanup
Reporter: James Peach
In TS-2431, all the FooAccept handlers were renamed to FooAcceptCont. If we
added the Cont suffix to everything that was a continuation, there would be
no other suffixes. We should undo this, or find a new naming convention.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
