[jira] [Commented] (TS-2859) fix DBG macros to not generate warnings from GCC 4.9
[
https://issues.apache.org/jira/browse/TS-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063093#comment-14063093
]
ASF subversion and git services commented on TS-2859:
-
Commit 548694089763c985761463edce4d31882e06e48a in trafficserver's branch
refs/heads/4.2.x from [~hrw-redhat]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=5486940 ]
TS-2859: remove DBG macros to not generate warnings from GCC 4.9
(cherry picked from commit e7586dfee7a04b44e3c378a484cc1e776e847b27)
Conflicts:
CHANGES
> fix DBG macros to not generate warnings from GCC 4.9
>
>
> Key: TS-2859
> URL: https://issues.apache.org/jira/browse/TS-2859
> Project: Traffic Server
> Issue Type: Improvement
> Components: Build
>Reporter: Marcin Juszkiewicz
>Assignee: Phil Sorber
> Fix For: 4.2.2, 5.0.0
>
> Attachments: trafficserver-fix-dbg.patch,
> trafficserver-remove-dbg-macros.patch
>
>
> Fedora 'rawhide' is using gcc 4.9 as default compiler. During build of
> trafficserver 4.2.1 I had lot of extra output from gcc due to DBG macros:
> ---
> In file included from ../../lib/ts/ink_time.h:38:0,
> from ../../lib/ts/ink_align.h:28,
> from ../../lib/ts/libts.h:46,
> from P_EventSystem.h:34,
> from IOBuffer.cc:28:
> ../../lib/ts/ink_defs.h:147:56: warning: invalid suffix on literal; C++11
> requires a space between literal and string macro [-Wliteral-suffix]
> #define FDBGif (debug_level==1) printf("debug "__FILE__":%d
> %s : entered\n" ,__LINE__,__FUNCTION__)
> ^
> ../../lib/ts/ink_defs.h:148:56: warning: invalid suffix on literal; C++11
> requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG(s) if (debug_level==1) printf("debug "__FILE__":%d
> %s :" s ,__LINE__,__FUNCTION__)
> ^
> ../../lib/ts/ink_defs.h:149:56: warning: invalid suffix on literal; C++11
> requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG1(s,a) if (debug_level==1) printf("debug "__FILE__":%d
> %s :" s ,__LINE__,__FUNCTION__, a)
> ^
> ../../lib/ts/ink_defs.h:150:56: warning: invalid suffix on literal; C++11
> requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG2(s,a1,a2) if (debug_level==1) printf("debug "__FILE__":%d
> %s :" s ,__LINE__,__FUNCTION__, a1,a2)
> ^
> ../../lib/ts/ink_defs.h:151:56: warning: invalid suffix on literal; C++11
> requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG3(s,a1,a2,a3)if (debug_level==1) printf("debug "__FILE__":%d
> %s :" s ,__LINE__,__FUNCTION__, a1,a2,a3)
> ^
> ../../lib/ts/ink_defs.h:152:56: warning: invalid suffix on literal; C++11
> requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG4(s,a1,a2,a3,a4) if (debug_level==1) printf("debug "__FILE__":%d
> %s :" s ,__LINE__,__FUNCTION__, a1,a2,a3,a4)
> ---
> I have a fix for that.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (TS-2859) fix DBG macros to not generate warnings from GCC 4.9
[
https://issues.apache.org/jira/browse/TS-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012757#comment-14012757
]
ASF subversion and git services commented on TS-2859:
-
Commit e7586dfee7a04b44e3c378a484cc1e776e847b27 in trafficserver's branch
refs/heads/master from [~hrw-redhat]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=e7586df ]
TS-2859: remove DBG macros to not generate warnings from GCC 4.9
> fix DBG macros to not generate warnings from GCC 4.9
>
>
> Key: TS-2859
> URL: https://issues.apache.org/jira/browse/TS-2859
> Project: Traffic Server
> Issue Type: Improvement
> Components: Build
>Reporter: Marcin Juszkiewicz
> Attachments: trafficserver-fix-dbg.patch,
> trafficserver-remove-dbg-macros.patch
>
>
> Fedora 'rawhide' is using gcc 4.9 as default compiler. During build of
> trafficserver 4.2.1 I had lot of extra output from gcc due to DBG macros:
> ---
> In file included from ../../lib/ts/ink_time.h:38:0,
> from ../../lib/ts/ink_align.h:28,
> from ../../lib/ts/libts.h:46,
> from P_EventSystem.h:34,
> from IOBuffer.cc:28:
> ../../lib/ts/ink_defs.h:147:56: warning: invalid suffix on literal; C++11
> requires a space between literal and string macro [-Wliteral-suffix]
> #define FDBGif (debug_level==1) printf("debug "__FILE__":%d
> %s : entered\n" ,__LINE__,__FUNCTION__)
> ^
> ../../lib/ts/ink_defs.h:148:56: warning: invalid suffix on literal; C++11
> requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG(s) if (debug_level==1) printf("debug "__FILE__":%d
> %s :" s ,__LINE__,__FUNCTION__)
> ^
> ../../lib/ts/ink_defs.h:149:56: warning: invalid suffix on literal; C++11
> requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG1(s,a) if (debug_level==1) printf("debug "__FILE__":%d
> %s :" s ,__LINE__,__FUNCTION__, a)
> ^
> ../../lib/ts/ink_defs.h:150:56: warning: invalid suffix on literal; C++11
> requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG2(s,a1,a2) if (debug_level==1) printf("debug "__FILE__":%d
> %s :" s ,__LINE__,__FUNCTION__, a1,a2)
> ^
> ../../lib/ts/ink_defs.h:151:56: warning: invalid suffix on literal; C++11
> requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG3(s,a1,a2,a3)if (debug_level==1) printf("debug "__FILE__":%d
> %s :" s ,__LINE__,__FUNCTION__, a1,a2,a3)
> ^
> ../../lib/ts/ink_defs.h:152:56: warning: invalid suffix on literal; C++11
> requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG4(s,a1,a2,a3,a4) if (debug_level==1) printf("debug "__FILE__":%d
> %s :" s ,__LINE__,__FUNCTION__, a1,a2,a3,a4)
> ---
> I have a fix for that.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (TS-2859) fix DBG macros to not generate warnings from GCC 4.9
[
https://issues.apache.org/jira/browse/TS-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012435#comment-14012435
]
James Peach commented on TS-2859:
-
Thanks for the patch Marcin. These macros look obsolete and unused. Could you
submit a path that simply removes them?
> fix DBG macros to not generate warnings from GCC 4.9
>
>
> Key: TS-2859
> URL: https://issues.apache.org/jira/browse/TS-2859
> Project: Traffic Server
> Issue Type: Improvement
> Components: Build
>Reporter: Marcin Juszkiewicz
> Attachments: trafficserver-fix-dbg.patch
>
>
> Fedora 'rawhide' is using gcc 4.9 as default compiler. During build of
> trafficserver 4.2.1 I had lot of extra output from gcc due to DBG macros:
> ---
> In file included from ../../lib/ts/ink_time.h:38:0,
> from ../../lib/ts/ink_align.h:28,
> from ../../lib/ts/libts.h:46,
> from P_EventSystem.h:34,
> from IOBuffer.cc:28:
> ../../lib/ts/ink_defs.h:147:56: warning: invalid suffix on literal; C++11
> requires a space between literal and string macro [-Wliteral-suffix]
> #define FDBGif (debug_level==1) printf("debug "__FILE__":%d
> %s : entered\n" ,__LINE__,__FUNCTION__)
> ^
> ../../lib/ts/ink_defs.h:148:56: warning: invalid suffix on literal; C++11
> requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG(s) if (debug_level==1) printf("debug "__FILE__":%d
> %s :" s ,__LINE__,__FUNCTION__)
> ^
> ../../lib/ts/ink_defs.h:149:56: warning: invalid suffix on literal; C++11
> requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG1(s,a) if (debug_level==1) printf("debug "__FILE__":%d
> %s :" s ,__LINE__,__FUNCTION__, a)
> ^
> ../../lib/ts/ink_defs.h:150:56: warning: invalid suffix on literal; C++11
> requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG2(s,a1,a2) if (debug_level==1) printf("debug "__FILE__":%d
> %s :" s ,__LINE__,__FUNCTION__, a1,a2)
> ^
> ../../lib/ts/ink_defs.h:151:56: warning: invalid suffix on literal; C++11
> requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG3(s,a1,a2,a3)if (debug_level==1) printf("debug "__FILE__":%d
> %s :" s ,__LINE__,__FUNCTION__, a1,a2,a3)
> ^
> ../../lib/ts/ink_defs.h:152:56: warning: invalid suffix on literal; C++11
> requires a space between literal and string macro [-Wliteral-suffix]
> #define DBG4(s,a1,a2,a3,a4) if (debug_level==1) printf("debug "__FILE__":%d
> %s :" s ,__LINE__,__FUNCTION__, a1,a2,a3,a4)
> ---
> I have a fix for that.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
