[jira] [Commented] (TS-2907) Unix Sockets
[ https://issues.apache.org/jira/browse/TS-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15531028#comment-15531028 ] Leif Hedstrom commented on TS-2907: --- [~luca.rea] Hi Luca, are you still active on this? Any chance you can make this a Github PR for proper review etc.? > Unix Sockets > > > Key: TS-2907 > URL: https://issues.apache.org/jira/browse/TS-2907 > Project: Traffic Server > Issue Type: New Feature > Components: Core >Reporter: Luca Rea >Assignee: Brian Geffon > Labels: A, review > Fix For: 7.1.0 > > Attachments: TS-2907.diff, unixsocket-backpost.diff > > > Feature request for support listeners and parents on unix sockets. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2907) Unix Sockets
[
https://issues.apache.org/jira/browse/TS-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14603011#comment-14603011
]
Alan M. Carroll commented on TS-2907:
-
My primary concern here is that a {{sockaddr_un}} is big and {{IpEndpoint}} is
used in many places so I'm not sure of the memory footprint issue here. It's
one reason I didn't use {{sockaddr_storage}} when I implemented the IPv6
support.
We would need to look at the impact on HostDB as well - that's a more serious
sizing issue especially for people who won't use the unix domain socket
capability.
Unix Sockets
Key: TS-2907
URL: https://issues.apache.org/jira/browse/TS-2907
Project: Traffic Server
Issue Type: New Feature
Components: Core
Reporter: Luca Rea
Assignee: Brian Geffon
Labels: review
Fix For: 6.1.0
Attachments: TS-2907.diff, unixsocket-backpost.diff
Feature request for support listeners and parents on unix sockets.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-2907) Unix Sockets
[ https://issues.apache.org/jira/browse/TS-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14579496#comment-14579496 ] Leif Hedstrom commented on TS-2907: --- [~briang] Ping? Land it? Unix Sockets Key: TS-2907 URL: https://issues.apache.org/jira/browse/TS-2907 Project: Traffic Server Issue Type: New Feature Components: Core Reporter: Luca Rea Assignee: Brian Geffon Labels: review Fix For: 6.0.0 Attachments: TS-2907.diff, unixsocket-backpost.diff Feature request for support listeners and parents on unix sockets. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2907) Unix Sockets
[ https://issues.apache.org/jira/browse/TS-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14575291#comment-14575291 ] Leif Hedstrom commented on TS-2907: --- Should we land this for 6.0.0? Unix Sockets Key: TS-2907 URL: https://issues.apache.org/jira/browse/TS-2907 Project: Traffic Server Issue Type: New Feature Components: Core Reporter: Luca Rea Assignee: Brian Geffon Labels: review Fix For: 6.0.0 Attachments: TS-2907.diff, unixsocket-backpost.diff Feature request for support listeners and parents on unix sockets. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2907) Unix Sockets
[ https://issues.apache.org/jira/browse/TS-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537521#comment-14537521 ] Brian Geffon commented on TS-2907: -- This patch looks good to me. [~jamespeach], [~zwoop] any comments? Unix Sockets Key: TS-2907 URL: https://issues.apache.org/jira/browse/TS-2907 Project: Traffic Server Issue Type: New Feature Components: Core Reporter: Luca Rea Assignee: Brian Geffon Labels: review Fix For: 6.0.0 Attachments: TS-2907.diff, unixsocket-backpost.diff Feature request for support listeners and parents on unix sockets. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2907) Unix Sockets
[ https://issues.apache.org/jira/browse/TS-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372021#comment-14372021 ] Phil Sorber commented on TS-2907: - Moving out to 6.0.0. Unix Sockets Key: TS-2907 URL: https://issues.apache.org/jira/browse/TS-2907 Project: Traffic Server Issue Type: New Feature Components: Core Reporter: Luca Rea Assignee: Brian Geffon Labels: review Fix For: 6.0.0 Attachments: TS-2907.diff, unixsocket-backpost.diff Feature request for support listeners and parents on unix sockets. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2907) Unix Sockets
[ https://issues.apache.org/jira/browse/TS-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14363917#comment-14363917 ] Brian Geffon commented on TS-2907: -- I apologize for the delay, I'll review. Unix Sockets Key: TS-2907 URL: https://issues.apache.org/jira/browse/TS-2907 Project: Traffic Server Issue Type: New Feature Components: Core Reporter: Luca Rea Assignee: Brian Geffon Labels: review Fix For: 5.3.0 Attachments: TS-2907.diff, unixsocket-backpost.diff Feature request for support listeners and parents on unix sockets. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2907) Unix Sockets
[ https://issues.apache.org/jira/browse/TS-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14361593#comment-14361593 ] Phil Sorber commented on TS-2907: - [~briang], can we get an update on this? It's marked for 5.3.0. Unix Sockets Key: TS-2907 URL: https://issues.apache.org/jira/browse/TS-2907 Project: Traffic Server Issue Type: New Feature Components: Core Reporter: Luca Rea Assignee: Brian Geffon Labels: review Fix For: 5.3.0 Attachments: TS-2907.diff, unixsocket-backpost.diff Feature request for support listeners and parents on unix sockets. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2907) Unix Sockets
[ https://issues.apache.org/jira/browse/TS-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14220053#comment-14220053 ] Leif Hedstrom commented on TS-2907: --- [~briang] Should we move this out to 5.3.0 ? Unix Sockets Key: TS-2907 URL: https://issues.apache.org/jira/browse/TS-2907 Project: Traffic Server Issue Type: New Feature Components: Core Reporter: Luca Rea Assignee: Brian Geffon Labels: review Fix For: 5.2.0 Attachments: TS-2907.diff, unixsocket-backpost.diff Feature request for support listeners and parents on unix sockets. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2907) Unix Sockets
[
https://issues.apache.org/jira/browse/TS-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14208426#comment-14208426
]
James Peach commented on TS-2907:
-
This looks pretty reasonable to me. I had a few comments ...
Remove --enable-unix-socket option. we already assume unix domain socket, let's
just use them.
TS_UNIX_SIZE is not necessary; it's clearer to use sockaddr.sun_path directly.
Do you need to increment the HostDB version number so force traffic_server do
recreate it?
{{bool ats_is_supported_sa(int family)}} should be called
{{ats_is_supported_family()}}.
The comments for {{ats_unix_path_cast()}} seems wrong. AFAICT
{{ats_unix_path_cast()}} doesn't return NULL if applied to the wrong socket
type.
I need [~amc] to review the hdrtoken+wks changes for cache compatibility.
In {{HttpTransact::initialize_state_variables_from_request}}, I don't see how
the scheme from {{incoming_request-url_get()}} can be Unix. The Unix scheme is
only for origin requests, so this seems confusing.
In {{remap_parse_config_bti}}, we should raise an error if the {{fromScheme}}
is Unix.
We should mention this feature in the {{remap.config}} documentation.
Unix Sockets
Key: TS-2907
URL: https://issues.apache.org/jira/browse/TS-2907
Project: Traffic Server
Issue Type: New Feature
Components: Core
Reporter: Luca Rea
Assignee: James Peach
Labels: review
Fix For: 5.2.0
Attachments: TS-2907.diff, unixsocket-backpost.diff
Feature request for support listeners and parents on unix sockets.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-2907) Unix Sockets
[
https://issues.apache.org/jira/browse/TS-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14208514#comment-14208514
]
Brian Geffon commented on TS-2907:
--
Agree that {{--enable-unix-socket}} is unnecessary.
In general I do not like the idea of ‘unix:///foo/bar.sock/path, I think the
following syntax makes more sense, how else can we manipulate the host header
for the next hop without a plugin?
{{map http://www.foo.bar/ http://www.blah.com/ @unix_socket=/tmp/foo.bar.sock}}
Also, with this approach you can remove all the
{{url_parse_unix_no_path_component_breakdown()}} code.
Unix Sockets
Key: TS-2907
URL: https://issues.apache.org/jira/browse/TS-2907
Project: Traffic Server
Issue Type: New Feature
Components: Core
Reporter: Luca Rea
Assignee: James Peach
Labels: review
Fix For: 5.2.0
Attachments: TS-2907.diff, unixsocket-backpost.diff
Feature request for support listeners and parents on unix sockets.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-2907) Unix Sockets
[ https://issues.apache.org/jira/browse/TS-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126477#comment-14126477 ] Leif Hedstrom commented on TS-2907: --- Yeah, these mappings with !'s looks very strange honestly. One option would be to consume the socket path up until it finds a file on the file system, but that means that you can't load the remap (properly) if the socket doesn't exist (maybe that's as you want anyways). So, e.g. map / unix:///var/tmp/origin.sock/foo/bar would consume /var/tmp/origin.sock, and leave /foo/bar in the remap to-URL path. Unix Sockets Key: TS-2907 URL: https://issues.apache.org/jira/browse/TS-2907 Project: Traffic Server Issue Type: New Feature Components: Core Reporter: Luca Rea Assignee: Brian Geffon Labels: review Fix For: 5.2.0 Attachments: unixsocket-backpost.diff Feature request for support listeners and parents on unix sockets. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2907) Unix Sockets
[
https://issues.apache.org/jira/browse/TS-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14123083#comment-14123083
]
James Peach commented on TS-2907:
-
Have not reviewed the patch yet, but IMHO the ``map`` syntax for unix sockets
should be
{code}
map / unix:///var/tmp/origin/sock
{code}
Unix Sockets
Key: TS-2907
URL: https://issues.apache.org/jira/browse/TS-2907
Project: Traffic Server
Issue Type: New Feature
Components: Core
Reporter: Luca Rea
Assignee: Brian Geffon
Labels: review
Fix For: 5.2.0
Attachments: unixsocket-backpost.diff
Feature request for support listeners and parents on unix sockets.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-2907) Unix Sockets
[ https://issues.apache.org/jira/browse/TS-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14123357#comment-14123357 ] James Peach commented on TS-2907: - Oh I see what you mean. There's no way to distinguish between the path for the socket and the remainder of the path on the URL. That's interesting. Hmmm. Unix Sockets Key: TS-2907 URL: https://issues.apache.org/jira/browse/TS-2907 Project: Traffic Server Issue Type: New Feature Components: Core Reporter: Luca Rea Assignee: Brian Geffon Labels: review Fix For: 5.2.0 Attachments: unixsocket-backpost.diff Feature request for support listeners and parents on unix sockets. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2907) Unix Sockets
[ https://issues.apache.org/jira/browse/TS-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14123388#comment-14123388 ] Brian Geffon commented on TS-2907: -- In my patch that I had you would specify the socket with @socket=/var/sock. Unix Sockets Key: TS-2907 URL: https://issues.apache.org/jira/browse/TS-2907 Project: Traffic Server Issue Type: New Feature Components: Core Reporter: Luca Rea Assignee: Brian Geffon Labels: review Fix For: 5.2.0 Attachments: unixsocket-backpost.diff Feature request for support listeners and parents on unix sockets. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
