[jira] [Commented] (TS-3023) Support space separated values in inline plugin parameters in remap rules
[ https://issues.apache.org/jira/browse/TS-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14134903#comment-14134903 ] Bryan Call commented on TS-3023: [~sudheerv] Can this be marked as resolved? Support space separated values in inline plugin parameters in remap rules - Key: TS-3023 URL: https://issues.apache.org/jira/browse/TS-3023 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Sudheer Vinukonda Fix For: 5.2.0 Attachments: TS-3023.diff While reviewing and testing TS-2947, Leif found that, space separated values are not supported correctly for inline plugin params whereas, they work as expected when specified in the config file. For example, @pparam=proxy.config.foo='bar beer' results only in setting proxy.config.foo=bar whereas CONFIG proxy.config.foo STRING 'bar beer' results in setting proxy.config.foo='bar beer' Further analysis revealed that the limitation is in parsing/tokenizing the input, which always treats space or tab as delimiters, regardless of whether they are included within quotes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3023) Support space separated values in inline plugin parameters in remap rules
[ https://issues.apache.org/jira/browse/TS-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14132851#comment-14132851 ] ASF subversion and git services commented on TS-3023: - Commit 8dec47284e541b160f7bb8751b185f5fe0757486 in trafficserver's branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=8dec472 ] TS-3023 Fix indentation. Support space separated values in inline plugin parameters in remap rules - Key: TS-3023 URL: https://issues.apache.org/jira/browse/TS-3023 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Sudheer Vinukonda Fix For: 5.2.0 Attachments: TS-3023.diff While reviewing and testing TS-2947, Leif found that, space separated values are not supported correctly for inline plugin params whereas, they work as expected when specified in the config file. For example, @pparam=proxy.config.foo='bar beer' results only in setting proxy.config.foo=bar whereas CONFIG proxy.config.foo STRING 'bar beer' results in setting proxy.config.foo='bar beer' Further analysis revealed that the limitation is in parsing/tokenizing the input, which always treats space or tab as delimiters, regardless of whether they are included within quotes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3023) Support space separated values in inline plugin parameters in remap rules
[ https://issues.apache.org/jira/browse/TS-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14131735#comment-14131735 ] ASF subversion and git services commented on TS-3023: - Commit 85afd76e07380161dc3268a1b5d3bdd7286a9527 in trafficserver's branch refs/heads/master from [~sudheerv] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=85afd76 ] [TS-3023] - Support space separated values in inline plugin parameters in remap rules Support space separated values in inline plugin parameters in remap rules - Key: TS-3023 URL: https://issues.apache.org/jira/browse/TS-3023 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Sudheer Vinukonda Fix For: 5.2.0 Attachments: TS-3023.diff While reviewing and testing TS-2947, Leif found that, space separated values are not supported correctly for inline plugin params whereas, they work as expected when specified in the config file. For example, @pparam=proxy.config.foo='bar beer' results only in setting proxy.config.foo=bar whereas CONFIG proxy.config.foo STRING 'bar beer' results in setting proxy.config.foo='bar beer' Further analysis revealed that the limitation is in parsing/tokenizing the input, which always treats space or tab as delimiters, regardless of whether they are included within quotes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3023) Support space separated values in inline plugin parameters in remap rules
[ https://issues.apache.org/jira/browse/TS-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103954#comment-14103954 ] Sudheer Vinukonda commented on TS-3023: --- Updated patch with tests attached. Support space separated values in inline plugin parameters in remap rules - Key: TS-3023 URL: https://issues.apache.org/jira/browse/TS-3023 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Sudheer Vinukonda Fix For: 5.2.0 Attachments: TS-3023.diff While reviewing and testing TS-2947, Leif found that, space separated values are not supported correctly for inline plugin params whereas, they work as expected when specified in the config file. For example, @pparam=proxy.config.foo='bar beer' results only in setting proxy.config.foo=bar whereas CONFIG proxy.config.foo STRING 'bar beer' results in setting proxy.config.foo='bar beer' Further analysis revealed that the limitation is in parsing/tokenizing the input, which always treats space or tab as delimiters, regardless of whether they are included within quotes. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-3023) Support space separated values in inline plugin parameters in remap rules
[
https://issues.apache.org/jira/browse/TS-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102622#comment-14102622
]
Sudheer Vinukonda commented on TS-3023:
---
Sample test output for the below config:
map https://abc.com https://abc.com @plugin=conf_remap.so
@pparam=proxy.config.http.global_user_agent_header='ABC DEF'
@pparam=proxy.config.http.global_user_agent_header=ABC
@pparam=proxy.config.http.global_user_agent_header=ABC DEF
@pparam=proxy.config.http.global_user_agent_header=ABC
@pparam=proxy.config.http.global_user_agent_header=DEF
{code}
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DEBUG: (url_rewrite) Viewing all
parameters for config line
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DEBUG: (url_rewrite) Argument 0:
plugin=conf_remap.so
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DEBUG: (url_rewrite) Argument 1:
pparam=proxy.config.http.global_user_agent_header='ABC DEF'
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DEBUG: (url_rewrite) Argument 2:
pparam=proxy.config.http.global_user_agent_header=ABC
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DEBUG: (url_rewrite) Argument 3:
pparam=proxy.config.http.global_user_agent_header=ABC DEF
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DEBUG: (url_rewrite) Argument 4:
pparam=proxy.config.http.global_user_agent_header=ABC
@pparam=proxy.config.http.global_user_agent_header=DEF
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DEBUG: (url_rewrite) Viewing
parsed plugin parameters for /home/y/libexec64/trafficserver/conf_remap.so: [0]
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DEBUG: (url_rewrite) Argument 0:
https://dev1.stg.uff.corp.gq1.yahoo.com/
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DEBUG: (url_rewrite) Argument 1:
https://www.flickr.com/
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DEBUG: (url_rewrite) Argument 2:
proxy.config.http.global_user_agent_header='ABC DEF'
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DEBUG: (url_rewrite) Argument 3:
proxy.config.http.global_user_agent_header=ABC
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DEBUG: (url_rewrite) Argument 4:
proxy.config.http.global_user_agent_header=ABC DEF
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DEBUG: (url_rewrite) Argument 5:
proxy.config.http.global_user_agent_header=ABC
@pparam=proxy.config.http.global_user_agent_header=DEF
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DIAG: (conf_remap) argv =
proxy.config.http.global_user_agent_header='ABC DEF'
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DIAG: (conf_remap) parse_inline
argv = proxy.config.http.global_user_agent_header='ABC DEF'
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DIAG: (conf_remap) value 'ABC DEF'
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DIAG: (conf_remap) argv =
proxy.config.http.global_user_agent_header=ABC
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DIAG: (conf_remap) parse_inline
argv = proxy.config.http.global_user_agent_header=ABC
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DIAG: (conf_remap) value ABC
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DIAG: (conf_remap) argv =
proxy.config.http.global_user_agent_header=ABC DEF
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DIAG: (conf_remap) parse_inline
argv = proxy.config.http.global_user_agent_header=ABC DEF
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DIAG: (conf_remap) value ABC DEF
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DIAG: (conf_remap) argv =
proxy.config.http.global_user_agent_header=ABC
@pparam=proxy.config.http.global_user_agent_header=DEF
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DIAG: (conf_remap) parse_inline
argv = proxy.config.http.global_user_agent_header=ABC
@pparam=proxy.config.http.global_user_agent_header=DEF
[Aug 19 18:10:25.566] Server {0x2adaa78348e0} DIAG: (conf_remap) value ABC
@pparam=proxy.config.http.global_user_agent_header=DEF
{code}
Support space separated values in inline plugin parameters in remap rules
-
Key: TS-3023
URL: https://issues.apache.org/jira/browse/TS-3023
Project: Traffic Server
Issue Type: Bug
Components: Core
Reporter: Sudheer Vinukonda
Fix For: 5.2.0
Attachments: TS-3023.diff
While reviewing and testing TS-2947, Leif found that, space separated values
are not supported correctly for inline plugin params whereas, they work as
expected when specified in the config file.
For example,
@pparam=proxy.config.foo='bar beer' results only in setting
proxy.config.foo=bar
whereas
CONFIG proxy.config.foo STRING 'bar beer' results in setting
proxy.config.foo='bar beer'
Further analysis revealed that the limitation is in parsing/tokenizing the
input, which always treats space or tab as delimiters, regardless of whether
they are included within quotes.
--
This message
[jira] [Commented] (TS-3023) Support space separated values in inline plugin parameters in remap rules
[ https://issues.apache.org/jira/browse/TS-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102795#comment-14102795 ] James Peach commented on TS-3023: - Seems better to use the options flag than adding extra options. Could use some tests too. Support space separated values in inline plugin parameters in remap rules - Key: TS-3023 URL: https://issues.apache.org/jira/browse/TS-3023 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Sudheer Vinukonda Fix For: 5.2.0 Attachments: TS-3023.diff While reviewing and testing TS-2947, Leif found that, space separated values are not supported correctly for inline plugin params whereas, they work as expected when specified in the config file. For example, @pparam=proxy.config.foo='bar beer' results only in setting proxy.config.foo=bar whereas CONFIG proxy.config.foo STRING 'bar beer' results in setting proxy.config.foo='bar beer' Further analysis revealed that the limitation is in parsing/tokenizing the input, which always treats space or tab as delimiters, regardless of whether they are included within quotes. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-3023) Support space separated values in inline plugin parameters in remap rules
[ https://issues.apache.org/jira/browse/TS-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102804#comment-14102804 ] Sudheer Vinukonda commented on TS-3023: --- Ah, thanks [~jpe...@apache.org] - I agree that's a cleaner approach - will modify the patch to use options flag and will try to add some tests too. Support space separated values in inline plugin parameters in remap rules - Key: TS-3023 URL: https://issues.apache.org/jira/browse/TS-3023 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Sudheer Vinukonda Fix For: 5.2.0 Attachments: TS-3023.diff While reviewing and testing TS-2947, Leif found that, space separated values are not supported correctly for inline plugin params whereas, they work as expected when specified in the config file. For example, @pparam=proxy.config.foo='bar beer' results only in setting proxy.config.foo=bar whereas CONFIG proxy.config.foo STRING 'bar beer' results in setting proxy.config.foo='bar beer' Further analysis revealed that the limitation is in parsing/tokenizing the input, which always treats space or tab as delimiters, regardless of whether they are included within quotes. -- This message was sent by Atlassian JIRA (v6.2#6252)
