[jira] [Commented] (TS-3642) proxy.config.http.share_server_sessions not working
[ https://issues.apache.org/jira/browse/TS-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875791#comment-14875791 ] ASF GitHub Bot commented on TS-3642: Github user SolidWallOfCode closed the pull request at: https://github.com/apache/trafficserver/pull/236 > proxy.config.http.share_server_sessions not working > --- > > Key: TS-3642 > URL: https://issues.apache.org/jira/browse/TS-3642 > Project: Traffic Server > Issue Type: Bug > Components: Configuration >Affects Versions: 5.3.0 >Reporter: David Carlin >Assignee: Phil Sorber > Fix For: 5.3.2 > > > Testing 5.3.0 and I noticed proxy.config.http.share_server_sessions = 1 no > longer works. Saw a 10-15x increase in origin connections; there appears to > be some reuse, I am seeing approximately 1.2-1.3 requests per origin > connection. > Setting "proxy.config.http.server_session_sharing.pool = global" restored > expected behavior (Thanks [~sudheerv]!) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3642) proxy.config.http.share_server_sessions not working
[ https://issues.apache.org/jira/browse/TS-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875790#comment-14875790 ] ASF GitHub Bot commented on TS-3642: Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/236#issuecomment-141484785 I think Phil merged this in to 5.3.2 so I'm closing the PR. > proxy.config.http.share_server_sessions not working > --- > > Key: TS-3642 > URL: https://issues.apache.org/jira/browse/TS-3642 > Project: Traffic Server > Issue Type: Bug > Components: Configuration >Affects Versions: 5.3.0 >Reporter: David Carlin >Assignee: Phil Sorber > Fix For: 5.3.2 > > > Testing 5.3.0 and I noticed proxy.config.http.share_server_sessions = 1 no > longer works. Saw a 10-15x increase in origin connections; there appears to > be some reuse, I am seeing approximately 1.2-1.3 requests per origin > connection. > Setting "proxy.config.http.server_session_sharing.pool = global" restored > expected behavior (Thanks [~sudheerv]!) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3642) proxy.config.http.share_server_sessions not working
[ https://issues.apache.org/jira/browse/TS-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608506#comment-14608506 ] Alan M. Carroll commented on TS-3642: - I set up a pull request for this, which has the commits from TS-3650 cherry-picked first and then a commit for the actual fix. proxy.config.http.share_server_sessions not working --- Key: TS-3642 URL: https://issues.apache.org/jira/browse/TS-3642 Project: Traffic Server Issue Type: Bug Components: Configuration Affects Versions: 5.3.0 Reporter: David Carlin Assignee: Phil Sorber Testing 5.3.0 and I noticed proxy.config.http.share_server_sessions = 1 no longer works. Saw a 10-15x increase in origin connections; there appears to be some reuse, I am seeing approximately 1.2-1.3 requests per origin connection. Setting proxy.config.http.server_session_sharing.pool = global restored expected behavior (Thanks [~sudheerv]!) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3642) proxy.config.http.share_server_sessions not working
[ https://issues.apache.org/jira/browse/TS-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605913#comment-14605913 ] Phil Sorber commented on TS-3642: - [~amc] said he is going to fix this today. proxy.config.http.share_server_sessions not working --- Key: TS-3642 URL: https://issues.apache.org/jira/browse/TS-3642 Project: Traffic Server Issue Type: Bug Components: Configuration Affects Versions: 5.3.0 Reporter: David Carlin Assignee: Phil Sorber Fix For: 5.3.1 Testing 5.3.0 and I noticed proxy.config.http.share_server_sessions = 1 no longer works. Saw a 10-15x increase in origin connections; there appears to be some reuse, I am seeing approximately 1.2-1.3 requests per origin connection. Setting proxy.config.http.server_session_sharing.pool = global restored expected behavior (Thanks [~sudheerv]!) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3642) proxy.config.http.share_server_sessions not working
[ https://issues.apache.org/jira/browse/TS-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14606593#comment-14606593 ] ASF GitHub Bot commented on TS-3642: GitHub user SolidWallOfCode opened a pull request: https://github.com/apache/trafficserver/pull/236 TS-3642: Make server session sharing configuration work as documented. You can merge this pull request into a Git repository by running: $ git pull https://github.com/SolidWallOfCode/trafficserver ts-3642 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/236.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #236 commit e449570f5419daa90b080e5f275f63794bb41a73 Author: Alan M. Carroll a...@apache.org Date: 2015-05-29T21:09:52Z TS-3650: Track configuration variable source. commit 26cd2558aab8c94d4c28b88cf2fa203ddc5780a5 Author: Phil Sorber sor...@apache.org Date: 2015-06-17T01:33:44Z TS-3650: clang-format commit 3f4cc21d3fcd8623cf4180e5a17a8711822a5e22 Author: Alan M. Carroll a...@apache.org Date: 2015-06-29T22:48:27Z TS-3642: Make server session sharing config values worked as documented. proxy.config.http.share_server_sessions not working --- Key: TS-3642 URL: https://issues.apache.org/jira/browse/TS-3642 Project: Traffic Server Issue Type: Bug Components: Configuration Affects Versions: 5.3.0 Reporter: David Carlin Assignee: Phil Sorber Fix For: 5.3.1 Testing 5.3.0 and I noticed proxy.config.http.share_server_sessions = 1 no longer works. Saw a 10-15x increase in origin connections; there appears to be some reuse, I am seeing approximately 1.2-1.3 requests per origin connection. Setting proxy.config.http.server_session_sharing.pool = global restored expected behavior (Thanks [~sudheerv]!) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3642) proxy.config.http.share_server_sessions not working
[ https://issues.apache.org/jira/browse/TS-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590123#comment-14590123 ] Phil Sorber commented on TS-3642: - [~amc], Yeah I think we need something back-portable. proxy.config.http.share_server_sessions not working --- Key: TS-3642 URL: https://issues.apache.org/jira/browse/TS-3642 Project: Traffic Server Issue Type: Bug Components: Configuration Affects Versions: 5.3.0 Reporter: David Carlin Assignee: Phil Sorber Fix For: 6.0.0 Testing 5.3.0 and I noticed proxy.config.http.share_server_sessions = 1 no longer works. Saw a 10-15x increase in origin connections; there appears to be some reuse, I am seeing approximately 1.2-1.3 requests per origin connection. Setting proxy.config.http.server_session_sharing.pool = global restored expected behavior (Thanks [~sudheerv]!) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3642) proxy.config.http.share_server_sessions not working
[ https://issues.apache.org/jira/browse/TS-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590094#comment-14590094 ] Alan M. Carroll commented on TS-3642: - This is now fixed for 6.0 The issue has only come up as far as I know internally for Yahoo! and we have a local patch for 5.3.x which just disables the new configuration which is not something we want to put in open source. Because of TS-3650 this could be fixed for 5.3.x. I'm not sure it rates a back port, but I can provide one if desired. I'm re-assigning to the 5.3.x RM for that decision. proxy.config.http.share_server_sessions not working --- Key: TS-3642 URL: https://issues.apache.org/jira/browse/TS-3642 Project: Traffic Server Issue Type: Bug Components: Configuration Affects Versions: 5.3.0 Reporter: David Carlin Assignee: Alan M. Carroll Fix For: 6.0.0 Testing 5.3.0 and I noticed proxy.config.http.share_server_sessions = 1 no longer works. Saw a 10-15x increase in origin connections; there appears to be some reuse, I am seeing approximately 1.2-1.3 requests per origin connection. Setting proxy.config.http.server_session_sharing.pool = global restored expected behavior (Thanks [~sudheerv]!) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3642) proxy.config.http.share_server_sessions not working
[ https://issues.apache.org/jira/browse/TS-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590111#comment-14590111 ] Eric Sproul commented on TS-3642: - +1 for a 5.3 backport. proxy.config.http.share_server_sessions not working --- Key: TS-3642 URL: https://issues.apache.org/jira/browse/TS-3642 Project: Traffic Server Issue Type: Bug Components: Configuration Affects Versions: 5.3.0 Reporter: David Carlin Assignee: Phil Sorber Fix For: 6.0.0 Testing 5.3.0 and I noticed proxy.config.http.share_server_sessions = 1 no longer works. Saw a 10-15x increase in origin connections; there appears to be some reuse, I am seeing approximately 1.2-1.3 requests per origin connection. Setting proxy.config.http.server_session_sharing.pool = global restored expected behavior (Thanks [~sudheerv]!) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3642) proxy.config.http.share_server_sessions not working
[ https://issues.apache.org/jira/browse/TS-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588337#comment-14588337 ] Eric Sproul commented on TS-3642: - We are still seeing higher-than-expected origin connection counts with 5.3.0. We currently have explicitly set: * CONFIG proxy.config.http.share_server_sessions INT 1 * CONFIG proxy.config.http.server_session_sharing.pool STRING global proxy.config.http.share_server_sessions not working --- Key: TS-3642 URL: https://issues.apache.org/jira/browse/TS-3642 Project: Traffic Server Issue Type: Bug Components: Configuration Affects Versions: 5.3.0 Reporter: David Carlin Assignee: Alan M. Carroll Fix For: 6.0.0 Testing 5.3.0 and I noticed proxy.config.http.share_server_sessions = 1 no longer works. Saw a 10-15x increase in origin connections; there appears to be some reuse, I am seeing approximately 1.2-1.3 requests per origin connection. Setting proxy.config.http.server_session_sharing.pool = global restored expected behavior (Thanks [~sudheerv]!) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3642) proxy.config.http.share_server_sessions not working
[ https://issues.apache.org/jira/browse/TS-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588352#comment-14588352 ] Phil Sorber commented on TS-3642: - [~amc], I think this is an explicit request to get this fixed for 5.3. proxy.config.http.share_server_sessions not working --- Key: TS-3642 URL: https://issues.apache.org/jira/browse/TS-3642 Project: Traffic Server Issue Type: Bug Components: Configuration Affects Versions: 5.3.0 Reporter: David Carlin Assignee: Alan M. Carroll Fix For: 6.0.0 Testing 5.3.0 and I noticed proxy.config.http.share_server_sessions = 1 no longer works. Saw a 10-15x increase in origin connections; there appears to be some reuse, I am seeing approximately 1.2-1.3 requests per origin connection. Setting proxy.config.http.server_session_sharing.pool = global restored expected behavior (Thanks [~sudheerv]!) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3642) proxy.config.http.share_server_sessions not working
[ https://issues.apache.org/jira/browse/TS-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14568490#comment-14568490 ] Phil Sorber commented on TS-3642: - Any resolution to this? proxy.config.http.share_server_sessions not working --- Key: TS-3642 URL: https://issues.apache.org/jira/browse/TS-3642 Project: Traffic Server Issue Type: Bug Components: Configuration Affects Versions: 5.3.0 Reporter: David Carlin Assignee: Sudheer Vinukonda Fix For: 6.0.0 Testing 5.3.0 and I noticed proxy.config.http.share_server_sessions = 1 no longer works. Saw a 10-15x increase in origin connections; there appears to be some reuse, I am seeing approximately 1.2-1.3 requests per origin connection. Setting proxy.config.http.server_session_sharing.pool = global restored expected behavior (Thanks [~sudheerv]!) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3642) proxy.config.http.share_server_sessions not working
[ https://issues.apache.org/jira/browse/TS-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563943#comment-14563943 ] Sudheer Vinukonda commented on TS-3642: --- A few notes: *) I honestly don't understand the need to have a separate/new setting to replace the existing *proxy.config.http.share_server_sessions*. The existing setting has been working fine. It was indicated to me that the motivation behind the change was TS-1893, but, reading through that jira, I haven't found the need to change the *proxy.config.http.share_server_sessions* setting. That jira, AFAICT asks for a configuration control on the *match* and not the *pool*. Also, I am not sure, if it makes sense to remove the *disable* option for the existing *share_server_sessions* and move it to the *match* setting. *) Also, AFAICT, the new settings never worked until the coverity fix a020cb2943f78f77ba8c928001359e8a2440cd28, which went in 5.3.0. Prior to that, the old setting was always working (in 5.0.x/5.1.x/5.2.x) and has been active in production. So, I'd argue that it is essential to preserve that behavior in 5.3.x at least. proxy.config.http.share_server_sessions not working --- Key: TS-3642 URL: https://issues.apache.org/jira/browse/TS-3642 Project: Traffic Server Issue Type: Bug Components: Configuration Affects Versions: 5.3.0 Reporter: David Carlin Assignee: Sudheer Vinukonda Testing 5.3.0 and I noticed proxy.config.http.share_server_sessions = 1 no longer works. Saw a 10-15x increase in origin connections; there appears to be some reuse, I am seeing approximately 1.2-1.3 requests per origin connection. Setting proxy.config.http.server_session_sharing.pool = global restored expected behavior (Thanks [~sudheerv]!) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3642) proxy.config.http.share_server_sessions not working
[ https://issues.apache.org/jira/browse/TS-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563100#comment-14563100 ] Phil Sorber commented on TS-3642: - Also include commit 349fb2f proxy.config.http.share_server_sessions not working --- Key: TS-3642 URL: https://issues.apache.org/jira/browse/TS-3642 Project: Traffic Server Issue Type: Bug Components: Configuration Affects Versions: 5.3.0 Reporter: David Carlin Assignee: Sudheer Vinukonda Testing 5.3.0 and I noticed proxy.config.http.share_server_sessions = 1 no longer works. Saw a 10-15x increase in origin connections; there appears to be some reuse, I am seeing approximately 1.2-1.3 requests per origin connection. Setting proxy.config.http.server_session_sharing.pool = global restored expected behavior (Thanks [~sudheerv]!) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3642) proxy.config.http.share_server_sessions not working
[ https://issues.apache.org/jira/browse/TS-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561474#comment-14561474 ] Sudheer Vinukonda commented on TS-3642: --- This issue is a consequence of the commit a020cb2943f78f77ba8c928001359e8a2440cd28 (Coverity CID #1196453). The original implementation of the settings *proxy.config.http.server_session_sharing.pool*, *proxy.config.http.server_session_sharing.match* claims to maintain backward compatibility with the existing setting *proxy.config.http.share_server_sessions*, but, the order in which these settings are being read is always the old setting first, followed by the new settings. Both old and new settings have default values (defaulting to per-thread pool), which means, the new settings would override the old setting always. However, the original implementation had a bug in reading the new settings, which made it behave in such a way that the old setting would take affect always. This bug in reading the setting was fixed in commit a020cb2943f78f77ba8c928001359e8a2440cd28, exposing the backward compatibility issue. proxy.config.http.share_server_sessions not working --- Key: TS-3642 URL: https://issues.apache.org/jira/browse/TS-3642 Project: Traffic Server Issue Type: Bug Components: Configuration Affects Versions: 5.3.0 Reporter: David Carlin Testing 5.3.0 and I noticed proxy.config.http.share_server_sessions = 1 no longer works. Saw a 10-15x increase in origin connections; there appears to be some reuse, I am seeing approximately 1.2-1.3 requests per origin connection. Setting proxy.config.http.server_session_sharing.pool = global restored expected behavior (Thanks [~sudheerv]!) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3642) proxy.config.http.share_server_sessions not working
[ https://issues.apache.org/jira/browse/TS-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561483#comment-14561483 ] ASF subversion and git services commented on TS-3642: - Commit a00c51bd7bdfa0b18c1f0acd14ae750c64c43657 in trafficserver's branch refs/heads/master from [~sudheerv] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=a00c51b ] [TS-3642]: fix reading of proxy.config.http.share_server_sessions proxy.config.http.share_server_sessions not working --- Key: TS-3642 URL: https://issues.apache.org/jira/browse/TS-3642 Project: Traffic Server Issue Type: Bug Components: Configuration Affects Versions: 5.3.0 Reporter: David Carlin Testing 5.3.0 and I noticed proxy.config.http.share_server_sessions = 1 no longer works. Saw a 10-15x increase in origin connections; there appears to be some reuse, I am seeing approximately 1.2-1.3 requests per origin connection. Setting proxy.config.http.server_session_sharing.pool = global restored expected behavior (Thanks [~sudheerv]!) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
