[jira] [Commented] (TS-3978) Allow empty document caching to follow normal logic

[Leif Hedstrom (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424742#comment-15424742
 ] 

Leif Hedstrom commented on TS-3978:
---

This might be easier if we eliminate cache clustering :-).

> Allow empty document caching to follow normal logic
> ---
>
> Key: TS-3978
> URL: https://issues.apache.org/jira/browse/TS-3978
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cache
>Reporter: Felicity Tarnell
> Fix For: 7.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently, allow_empty_doc only works if the origin sends a content-length 
> header.  It should have a setting to enable empty documents to be cached in 
> the normal way without any special handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3978) Allow empty document caching to follow normal logic

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291414#comment-15291414
 ] 

ASF GitHub Bot commented on TS-3978:


Github user zwoop commented on the pull request:

https://github.com/apache/trafficserver/pull/310#issuecomment-220376339
  


.



> Allow empty document caching to follow normal logic
> ---
>
> Key: TS-3978
> URL: https://issues.apache.org/jira/browse/TS-3978
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cache
>Reporter: Felicity Tarnell
> Fix For: 7.0.0
>
>
> Currently, allow_empty_doc only works if the origin sends a content-length 
> header.  It should have a setting to enable empty documents to be cached in 
> the normal way without any special handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3978) Allow empty document caching to follow normal logic

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15280458#comment-15280458
 ] 

ASF GitHub Bot commented on TS-3978:


Github user atsci commented on the pull request:

https://github.com/apache/trafficserver/pull/310#issuecomment-218525685
  
Can one of the admins verify this patch?


> Allow empty document caching to follow normal logic
> ---
>
> Key: TS-3978
> URL: https://issues.apache.org/jira/browse/TS-3978
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cache
>Reporter: Felicity Tarnell
> Fix For: 7.0.0
>
>
> Currently, allow_empty_doc only works if the origin sends a content-length 
> header.  It should have a setting to enable empty documents to be cached in 
> the normal way without any special handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3978) Allow empty document caching to follow normal logic

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14970868#comment-14970868
 ] 

ASF GitHub Bot commented on TS-3978:


GitHub user ftarnell opened a pull request:

https://github.com/apache/trafficserver/pull/310

TS-3978: Allow empty document caching to follow normal logic



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/torchbox/trafficserver ts3978

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/310.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #310


commit 28d491b32579dfee0aae498d8a47f579eb7ff880
Author: Felicity Tarnell 
Date:   2015-10-23T11:39:28Z

TS-3978: Allow empty document caching to follow normal logic




> Allow empty document caching to follow normal logic
> ---
>
> Key: TS-3978
> URL: https://issues.apache.org/jira/browse/TS-3978
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cache
>Reporter: Felicity Tarnell
>
> Currently, allow_empty_doc only works if the origin sends a content-length 
> header.  It should have a setting to enable empty documents to be cached in 
> the normal way without any special handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3978) Allow empty document caching to follow normal logic

[Alan M. Carroll (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971115#comment-14971115
 ] 

Alan M. Carroll commented on TS-3978:
-

That's a concern but it should also be OK if it's chunked encoded and you get a 
valid final frame as the first content.

> Allow empty document caching to follow normal logic
> ---
>
> Key: TS-3978
> URL: https://issues.apache.org/jira/browse/TS-3978
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cache
>Reporter: Felicity Tarnell
>
> Currently, allow_empty_doc only works if the origin sends a content-length 
> header.  It should have a setting to enable empty documents to be cached in 
> the normal way without any special handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3978) Allow empty document caching to follow normal logic

[Sudheer Vinukonda (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971121#comment-14971121
 ] 

Sudheer Vinukonda commented on TS-3978:
---

Yes, I understand that - My point is the patch must ensure that the final frame 
was received (unless, of course, chunked handling code already handles it 
indirectly).

> Allow empty document caching to follow normal logic
> ---
>
> Key: TS-3978
> URL: https://issues.apache.org/jira/browse/TS-3978
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cache
>Reporter: Felicity Tarnell
>
> Currently, allow_empty_doc only works if the origin sends a content-length 
> header.  It should have a setting to enable empty documents to be cached in 
> the normal way without any special handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3978) Allow empty document caching to follow normal logic

[James Peach (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971131#comment-14971131
 ] 

James Peach commented on TS-3978:
-

We need TSQA tests for this.

> Allow empty document caching to follow normal logic
> ---
>
> Key: TS-3978
> URL: https://issues.apache.org/jira/browse/TS-3978
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cache
>Reporter: Felicity Tarnell
>
> Currently, allow_empty_doc only works if the origin sends a content-length 
> header.  It should have a setting to enable empty documents to be cached in 
> the normal way without any special handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3978) Allow empty document caching to follow normal logic

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971096#comment-14971096
 ] 

ASF GitHub Bot commented on TS-3978:


Github user sudheerv commented on the pull request:

https://github.com/apache/trafficserver/pull/310#issuecomment-150595466
  
Hmm..the requirement in the jira certainly seems reasonable, but, the 
current state of this is mainly to ensure ATS is not caching broken responses 
(connection failure in the middle of download). 

Allowing to cache the empty docs only when Content-Length=0 indirectly 
ensures that the response was not broken. So, the patch must somehow ensure 
that the response is not broken, otherwise, there's a danger of caching invalid 
responses.


> Allow empty document caching to follow normal logic
> ---
>
> Key: TS-3978
> URL: https://issues.apache.org/jira/browse/TS-3978
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cache
>Reporter: Felicity Tarnell
>
> Currently, allow_empty_doc only works if the origin sends a content-length 
> header.  It should have a setting to enable empty documents to be cached in 
> the normal way without any special handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)