[jira] [Commented] (TS-4466) Add links to other versions/languages of the documentation
[ https://issues.apache.org/jira/browse/TS-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294861#comment-15294861 ] ASF GitHub Bot commented on TS-4466: GitHub user maskit opened a pull request: https://github.com/apache/trafficserver/pull/654 TS-4466: Add links to other versions of the documentation https://issues.apache.org/jira/browse/TS-4466  You can merge this pull request into a Git repository by running: $ git pull https://github.com/maskit/trafficserver ts4466 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/654.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #654 commit 70a23a925be4800efbd24d82217e6d22084f2e14 Author: Masakazu Kitajo Date: 2016-05-21T08:31:33Z TS-4466: Add links to other versions of the documentation commit 59fb3d33391bc4f9adc0417099ea96cddac88cba Author: Masakazu Kitajo Date: 2016-05-21T08:46:48Z TS-4466: Specify language explicitly > Add links to other versions/languages of the documentation > -- > > Key: TS-4466 > URL: https://issues.apache.org/jira/browse/TS-4466 > Project: Traffic Server > Issue Type: Improvement > Components: Documentation >Reporter: Masakazu Kitajo > > The documentation pages generated with sphinx have lost links to other > versions or languages of the documentation since we moved them from RTD. > It would be better to add the links so that we can know existence of other > versions and can choose them easily. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4466) Add links to other versions/languages of the documentation
[ https://issues.apache.org/jira/browse/TS-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294868#comment-15294868 ] ASF GitHub Bot commented on TS-4466: Github user maskit commented on the pull request: https://github.com/apache/trafficserver/pull/654#issuecomment-220767781 The template file could be considered as a derivative of this file. It's licensed under MIT. https://github.com/snide/sphinx_rtd_theme/blob/master/sphinx_rtd_theme/versions.html But I think the structure of tags and class names are sort of APIs to use this area. Should I put original copyright and license to our LICENSE file? > Add links to other versions/languages of the documentation > -- > > Key: TS-4466 > URL: https://issues.apache.org/jira/browse/TS-4466 > Project: Traffic Server > Issue Type: Improvement > Components: Documentation >Reporter: Masakazu Kitajo > > The documentation pages generated with sphinx have lost links to other > versions or languages of the documentation since we moved them from RTD. > It would be better to add the links so that we can know existence of other > versions and can choose them easily. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4466) Add links to other versions/languages of the documentation
[ https://issues.apache.org/jira/browse/TS-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295099#comment-15295099 ] Leif Hedstrom commented on TS-4466: --- [~jsime] Can you take a look and review this please? Also make sure the licensing stuff is correct. > Add links to other versions/languages of the documentation > -- > > Key: TS-4466 > URL: https://issues.apache.org/jira/browse/TS-4466 > Project: Traffic Server > Issue Type: Improvement > Components: Documentation >Reporter: Masakazu Kitajo >Assignee: Masakazu Kitajo > Fix For: 7.0.0 > > > The documentation pages generated with sphinx have lost links to other > versions or languages of the documentation since we moved them from RTD. > It would be better to add the links so that we can know existence of other > versions and can choose them easily. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4466) Add links to other versions/languages of the documentation
[ https://issues.apache.org/jira/browse/TS-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295100#comment-15295100 ] ASF GitHub Bot commented on TS-4466: Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/654#issuecomment-220785838 Great! I've asked Jon to take a look at this as well, since he's our Docs guru :). > Add links to other versions/languages of the documentation > -- > > Key: TS-4466 > URL: https://issues.apache.org/jira/browse/TS-4466 > Project: Traffic Server > Issue Type: Improvement > Components: Documentation >Reporter: Masakazu Kitajo >Assignee: Masakazu Kitajo > Fix For: 7.0.0 > > > The documentation pages generated with sphinx have lost links to other > versions or languages of the documentation since we moved them from RTD. > It would be better to add the links so that we can know existence of other > versions and can choose them easily. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4466) Add links to other versions/languages of the documentation
[ https://issues.apache.org/jira/browse/TS-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296832#comment-15296832 ] ASF GitHub Bot commented on TS-4466: Github user jsime commented on the pull request: https://github.com/apache/trafficserver/pull/654#issuecomment-221055926 This looks really good, except for one issue I've noticed. If you happen to be on a page which is nested pretty far down into the ToC (e.g. any of the experimental plugin docs in the Admin guide), and the chapter navigation in the left sidebar is pretty long, the language/version switcher can obscure the last couple entries in the expanded ToC list. Collapsing the new switcher with the arrow link just to the right of the currently selected version helps, but can still block the last entry in the ToC list (plus it may not be obvious for newcomers to the docs that there are any list items obscured at all). Hopefully this image comes through clearly enough:  The screenshots left and center show left-hand ToC navigation entries being obscured by both the expanded and collapsed language/version switcher - the right hand shot shows the collapsed switcher with a shorter ToC list in which nothing is covered up. My CSS chops aren't good enough to know right away how to correct that, but I'll see if I can come up with something. I can reproduce this issue in both Firefox and Chrome, fwiw. > Add links to other versions/languages of the documentation > -- > > Key: TS-4466 > URL: https://issues.apache.org/jira/browse/TS-4466 > Project: Traffic Server > Issue Type: Improvement > Components: Documentation >Reporter: Masakazu Kitajo >Assignee: Masakazu Kitajo > Fix For: 7.0.0 > > > The documentation pages generated with sphinx have lost links to other > versions or languages of the documentation since we moved them from RTD. > It would be better to add the links so that we can know existence of other > versions and can choose them easily. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4466) Add links to other versions/languages of the documentation
[ https://issues.apache.org/jira/browse/TS-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297825#comment-15297825 ] ASF GitHub Bot commented on TS-4466: Github user maskit commented on the pull request: https://github.com/apache/trafficserver/pull/654#issuecomment-221186963 Thank you for pointing out the issue. I found a fix for it on RTD's repository. https://github.com/rtfd/readthedocs.org/commit/b15d50bc200677053c04f6ede6c72fd1055525dd Also, I modified the template so that the switcher is collapsed until a reader clicks the current version at the bottom right. > Add links to other versions/languages of the documentation > -- > > Key: TS-4466 > URL: https://issues.apache.org/jira/browse/TS-4466 > Project: Traffic Server > Issue Type: Improvement > Components: Documentation >Reporter: Masakazu Kitajo >Assignee: Masakazu Kitajo > Fix For: 7.0.0 > > > The documentation pages generated with sphinx have lost links to other > versions or languages of the documentation since we moved them from RTD. > It would be better to add the links so that we can know existence of other > versions and can choose them easily. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4466) Add links to other versions/languages of the documentation
[ https://issues.apache.org/jira/browse/TS-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299292#comment-15299292 ] ASF subversion and git services commented on TS-4466: - Commit ff319fcae384ba9a3cda09dccdf3d8e1d4d643ff in trafficserver's branch refs/heads/master from [~jsime] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=ff319fc ] Merge pull request #654 from maskit/ts4466 TS-4466: Add links to other versions of the documentation > Add links to other versions/languages of the documentation > -- > > Key: TS-4466 > URL: https://issues.apache.org/jira/browse/TS-4466 > Project: Traffic Server > Issue Type: Improvement > Components: Documentation >Reporter: Masakazu Kitajo >Assignee: Masakazu Kitajo > Fix For: 7.0.0 > > > The documentation pages generated with sphinx have lost links to other > versions or languages of the documentation since we moved them from RTD. > It would be better to add the links so that we can know existence of other > versions and can choose them easily. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4466) Add links to other versions/languages of the documentation
[ https://issues.apache.org/jira/browse/TS-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299291#comment-15299291 ] ASF subversion and git services commented on TS-4466: - Commit ca35a0528b83c74ed7aa2f05cb73041648505b86 in trafficserver's branch refs/heads/master from [~maskit] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=ca35a05 ] TS-4466: Improve a layout and behavior of the switcher > Add links to other versions/languages of the documentation > -- > > Key: TS-4466 > URL: https://issues.apache.org/jira/browse/TS-4466 > Project: Traffic Server > Issue Type: Improvement > Components: Documentation >Reporter: Masakazu Kitajo >Assignee: Masakazu Kitajo > Fix For: 7.0.0 > > > The documentation pages generated with sphinx have lost links to other > versions or languages of the documentation since we moved them from RTD. > It would be better to add the links so that we can know existence of other > versions and can choose them easily. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4466) Add links to other versions/languages of the documentation
[ https://issues.apache.org/jira/browse/TS-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299289#comment-15299289 ] ASF subversion and git services commented on TS-4466: - Commit 70a23a925be4800efbd24d82217e6d22084f2e14 in trafficserver's branch refs/heads/master from [~maskit] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=70a23a9 ] TS-4466: Add links to other versions of the documentation > Add links to other versions/languages of the documentation > -- > > Key: TS-4466 > URL: https://issues.apache.org/jira/browse/TS-4466 > Project: Traffic Server > Issue Type: Improvement > Components: Documentation >Reporter: Masakazu Kitajo >Assignee: Masakazu Kitajo > Fix For: 7.0.0 > > > The documentation pages generated with sphinx have lost links to other > versions or languages of the documentation since we moved them from RTD. > It would be better to add the links so that we can know existence of other > versions and can choose them easily. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4466) Add links to other versions/languages of the documentation
[ https://issues.apache.org/jira/browse/TS-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299290#comment-15299290 ] ASF subversion and git services commented on TS-4466: - Commit 59fb3d33391bc4f9adc0417099ea96cddac88cba in trafficserver's branch refs/heads/master from [~maskit] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=59fb3d3 ] TS-4466: Specify language explicitly > Add links to other versions/languages of the documentation > -- > > Key: TS-4466 > URL: https://issues.apache.org/jira/browse/TS-4466 > Project: Traffic Server > Issue Type: Improvement > Components: Documentation >Reporter: Masakazu Kitajo >Assignee: Masakazu Kitajo > Fix For: 7.0.0 > > > The documentation pages generated with sphinx have lost links to other > versions or languages of the documentation since we moved them from RTD. > It would be better to add the links so that we can know existence of other > versions and can choose them easily. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4466) Add links to other versions/languages of the documentation
[ https://issues.apache.org/jira/browse/TS-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299288#comment-15299288 ] ASF GitHub Bot commented on TS-4466: Github user jsime closed the pull request at: https://github.com/apache/trafficserver/pull/654 > Add links to other versions/languages of the documentation > -- > > Key: TS-4466 > URL: https://issues.apache.org/jira/browse/TS-4466 > Project: Traffic Server > Issue Type: Improvement > Components: Documentation >Reporter: Masakazu Kitajo >Assignee: Masakazu Kitajo > Fix For: 7.0.0 > > > The documentation pages generated with sphinx have lost links to other > versions or languages of the documentation since we moved them from RTD. > It would be better to add the links so that we can know existence of other > versions and can choose them easily. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4466) Add links to other versions/languages of the documentation
[ https://issues.apache.org/jira/browse/TS-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302035#comment-15302035 ] Masakazu Kitajo commented on TS-4466: - [~jsime] Is the licensing stuff ok? > Add links to other versions/languages of the documentation > -- > > Key: TS-4466 > URL: https://issues.apache.org/jira/browse/TS-4466 > Project: Traffic Server > Issue Type: Improvement > Components: Documentation >Reporter: Masakazu Kitajo >Assignee: Masakazu Kitajo > Fix For: 7.0.0 > > > The documentation pages generated with sphinx have lost links to other > versions or languages of the documentation since we moved them from RTD. > It would be better to add the links so that we can know existence of other > versions and can choose them easily. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4466) Add links to other versions/languages of the documentation
[ https://issues.apache.org/jira/browse/TS-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15629637#comment-15629637 ] Phil Sorber commented on TS-4466: - Does anything need to be back ported here? > Add links to other versions/languages of the documentation > -- > > Key: TS-4466 > URL: https://issues.apache.org/jira/browse/TS-4466 > Project: Traffic Server > Issue Type: Improvement > Components: Documentation >Reporter: Masakazu Kitajo >Assignee: Masakazu Kitajo > Fix For: 7.0.0 > > > The documentation pages generated with sphinx have lost links to other > versions or languages of the documentation since we moved them from RTD. > It would be better to add the links so that we can know existence of other > versions and can choose them easily. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
