[jira] [Commented] (TS-4588) Require braces around statements.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357894#comment-15357894
 ] 

ASF GitHub Bot commented on TS-4588:


Github user jpeach closed the pull request at:

https://github.com/apache/trafficserver/pull/741


> Require braces around statements.
> -
>
> Key: TS-4588
> URL: https://issues.apache.org/jira/browse/TS-4588
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.0.0
>
>
> Bodies of if statements and loops (for, range-for, do-while, and while) are 
> inside braces.
> Apply this as a clang-tidy change 
> [readability-braces-around-statements|http://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4588) Require braces around statements.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355649#comment-15355649
 ] 

ASF subversion and git services commented on TS-4588:
-

Commit 2832d63e6fbf973b0dd431406b1cd3293205d179 in trafficserver's branch 
refs/heads/master from [~jpe...@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=2832d63 ]

TS-4588: Add initial clang-tidy configuration.


> Require braces around statements.
> -
>
> Key: TS-4588
> URL: https://issues.apache.org/jira/browse/TS-4588
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.0.0
>
>
> Bodies of if statements and loops (for, range-for, do-while, and while) are 
> inside braces.
> Apply this as a clang-tidy change 
> [readability-braces-around-statements|http://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4588) Require braces around statements.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355517#comment-15355517
 ] 

ASF GitHub Bot commented on TS-4588:


Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/741
  
Abandoning this PR for now. Will go back and look into getting 
``clang-tidy`` support into the build system.


> Require braces around statements.
> -
>
> Key: TS-4588
> URL: https://issues.apache.org/jira/browse/TS-4588
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.0.0
>
>
> Bodies of if statements and loops (for, range-for, do-while, and while) are 
> inside braces.
> Apply this as a clang-tidy change 
> [readability-braces-around-statements|http://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4588) Require braces around statements.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349064#comment-15349064
 ] 

ASF GitHub Bot commented on TS-4588:


Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/741
  
This would be in addition to #739. We should be able to implement ``make 
tidy`` but it is not there yet.


> Require braces around statements.
> -
>
> Key: TS-4588
> URL: https://issues.apache.org/jira/browse/TS-4588
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.0.0
>
>
> Bodies of if statements and loops (for, range-for, do-while, and while) are 
> inside braces.
> Apply this as a clang-tidy change 
> [readability-braces-around-statements|http://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4588) Require braces around statements.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349008#comment-15349008
 ] 

ASF GitHub Bot commented on TS-4588:


Github user PSUdaemon commented on the issue:

https://github.com/apache/trafficserver/pull/741
  
Is there a `.clang-tidy` config we can add and run with `make` like `make 
clang-tidy`?

Also, is this an alternative proposal to #739, or in addition to?


> Require braces around statements.
> -
>
> Key: TS-4588
> URL: https://issues.apache.org/jira/browse/TS-4588
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.0.0
>
>
> Bodies of if statements and loops (for, range-for, do-while, and while) are 
> inside braces.
> Apply this as a clang-tidy change 
> [readability-braces-around-statements|http://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4588) Require braces around statements.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348991#comment-15348991
 ] 

ASF GitHub Bot commented on TS-4588:


Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/741
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/237/ for details.
 



> Require braces around statements.
> -
>
> Key: TS-4588
> URL: https://issues.apache.org/jira/browse/TS-4588
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.0.0
>
>
> Bodies of if statements and loops (for, range-for, do-while, and while) are 
> inside braces.
> Apply this as a clang-tidy change 
> [readability-braces-around-statements|http://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4588) Require braces around statements.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348990#comment-15348990
 ] 

ASF GitHub Bot commented on TS-4588:


Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/741
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/343/ for details.
 



> Require braces around statements.
> -
>
> Key: TS-4588
> URL: https://issues.apache.org/jira/browse/TS-4588
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.0.0
>
>
> Bodies of if statements and loops (for, range-for, do-while, and while) are 
> inside braces.
> Apply this as a clang-tidy change 
> [readability-braces-around-statements|http://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4588) Require braces around statements.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348980#comment-15348980
 ] 

ASF GitHub Bot commented on TS-4588:


Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/741
  
Ping @zwoop @PSUdaemon 


> Require braces around statements.
> -
>
> Key: TS-4588
> URL: https://issues.apache.org/jira/browse/TS-4588
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.0.0
>
>
> Bodies of if statements and loops (for, range-for, do-while, and while) are 
> inside braces.
> Apply this as a clang-tidy change 
> [readability-braces-around-statements|http://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4588) Require braces around statements.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348981#comment-15348981
 ] 

ASF GitHub Bot commented on TS-4588:


Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/741
  
[approve ci]


> Require braces around statements.
> -
>
> Key: TS-4588
> URL: https://issues.apache.org/jira/browse/TS-4588
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.0.0
>
>
> Bodies of if statements and loops (for, range-for, do-while, and while) are 
> inside braces.
> Apply this as a clang-tidy change 
> [readability-braces-around-statements|http://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4588) Require braces around statements.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348979#comment-15348979
 ] 

ASF GitHub Bot commented on TS-4588:


GitHub user jpeach opened a pull request:

https://github.com/apache/trafficserver/pull/741

TS-4588: Require braces around statements.

Require bodies of if statements and loops (for, range-for, do-while,
and while) to be inside braces.

This is a automated change made with clang-tidy and clang-format.
Header files are not included because they are not emitted into the
compilation database.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jpeach/trafficserver fix/4588

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/741.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #741


commit 7c4158a4b8317e6f4ba5ff15e3bb9795f94f0954
Author: James Peach 
Date:   2016-06-25T01:10:42Z

TS-4588: Require braces around statements.

Require bodies of if statements and loops (for, range-for, do-while,
and while) to be inside braces.

This is a automated change made with clang-tidy and clang-format.
Header files are not included because they are not emitted into the
compilation database.




> Require braces around statements.
> -
>
> Key: TS-4588
> URL: https://issues.apache.org/jira/browse/TS-4588
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.0.0
>
>
> Bodies of if statements and loops (for, range-for, do-while, and while) are 
> inside braces.
> Apply this as a clang-tidy change 
> [readability-braces-around-statements|http://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)