[jira] [Commented] (TS-608) Is HttpSessionManager::purge_keepalives() too aggressive?
[ https://issues.apache.org/jira/browse/TS-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14015714#comment-14015714 ] Brian Geffon commented on TS-608: - We can only purge up to 75% of the limit or something? Is HttpSessionManager::purge_keepalives() too aggressive? -- Key: TS-608 URL: https://issues.apache.org/jira/browse/TS-608 Project: Traffic Server Issue Type: Bug Components: HTTP Reporter: Leif Hedstrom Assignee: Bin Chen Fix For: 5.2.0 Attachments: TS-608.patch It seems that if we trigger the max server connections, we call this purge function in the session manager, which will close all currently open keep-alive connections. This seems very aggressive, why not limit it to say only removing 10% of each bucket or some such? Also, how does this work together with per-origin limits? Ideally, if the per-origin limits are in place, we would only purge sessions that are for the IP we wish to connect to ? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-608) Is HttpSessionManager::purge_keepalives() too aggressive?
[ https://issues.apache.org/jira/browse/TS-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14015727#comment-14015727 ] Brian Geffon commented on TS-608: - Also, since the links are inherently LRU we should be purging from the end and not the start of the list. Is HttpSessionManager::purge_keepalives() too aggressive? -- Key: TS-608 URL: https://issues.apache.org/jira/browse/TS-608 Project: Traffic Server Issue Type: Bug Components: HTTP Reporter: Leif Hedstrom Assignee: Bin Chen Fix For: 5.2.0 Attachments: TS-608.patch It seems that if we trigger the max server connections, we call this purge function in the session manager, which will close all currently open keep-alive connections. This seems very aggressive, why not limit it to say only removing 10% of each bucket or some such? Also, how does this work together with per-origin limits? Ideally, if the per-origin limits are in place, we would only purge sessions that are for the IP we wish to connect to ? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-608) Is HttpSessionManager::purge_keepalives() too aggressive?
[ https://issues.apache.org/jira/browse/TS-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841488#comment-13841488 ] Leif Hedstrom commented on TS-608: -- Ping on this bug ? What do we do with it ? Is HttpSessionManager::purge_keepalives() too aggressive? -- Key: TS-608 URL: https://issues.apache.org/jira/browse/TS-608 Project: Traffic Server Issue Type: Bug Components: HTTP Reporter: Leif Hedstrom Assignee: Bin Chen Fix For: 5.0.0 Attachments: TS-608.patch It seems that if we trigger the max server connections, we call this purge function in the session manager, which will close all currently open keep-alive connections. This seems very aggressive, why not limit it to say only removing 10% of each bucket or some such? Also, how does this work together with per-origin limits? Ideally, if the per-origin limits are in place, we would only purge sessions that are for the IP we wish to connect to ? -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TS-608) Is HttpSessionManager::purge_keepalives() too aggressive?
[ https://issues.apache.org/jira/browse/TS-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630067#comment-13630067 ] weijin commented on TS-608: --- since chenbin is going to handle the session management stuff, assign to him. :) Is HttpSessionManager::purge_keepalives() too aggressive? -- Key: TS-608 URL: https://issues.apache.org/jira/browse/TS-608 Project: Traffic Server Issue Type: Bug Components: HTTP Reporter: Leif Hedstrom Assignee: Bin Chen Fix For: 3.3.3 Attachments: TS-608.patch It seems that if we trigger the max server connections, we call this purge function in the session manager, which will close all currently open keep-alive connections. This seems very aggressive, why not limit it to say only removing 10% of each bucket or some such? Also, how does this work together with per-origin limits? Ideally, if the per-origin limits are in place, we would only purge sessions that are for the IP we wish to connect to ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-608) Is HttpSessionManager::purge_keepalives() too aggressive?
[ https://issues.apache.org/jira/browse/TS-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606526#comment-13606526 ] Leif Hedstrom commented on TS-608: -- Wow, this is an old patch. Mohan or anyone in Taobao, is this patch still relevant? If so, can you rebase it for current master, and post again? Is HttpSessionManager::purge_keepalives() too aggressive? -- Key: TS-608 URL: https://issues.apache.org/jira/browse/TS-608 Project: Traffic Server Issue Type: Bug Components: HTTP Reporter: Leif Hedstrom Fix For: 3.3.3 Attachments: TS-608.patch It seems that if we trigger the max server connections, we call this purge function in the session manager, which will close all currently open keep-alive connections. This seems very aggressive, why not limit it to say only removing 10% of each bucket or some such? Also, how does this work together with per-origin limits? Ideally, if the per-origin limits are in place, we would only purge sessions that are for the IP we wish to connect to ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
