[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691732#comment-13691732 ] ASF subversion and git services commented on TS-745: Commit adaefd7893e89a18d6a45de0210dda70a8067138 in branch refs/heads/master from [~zym] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=adaefd7 ] TS-745: update CHANGES Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: weijin Fix For: 3.3.6 Attachments: 0001-TS-745-support-interim-caching-in-storage.patch, 0001-TS-745-support-interim-caching-in-storage_rebased.patch, ts-745.diff, TS-ssd-2.patch, TS-ssd.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691670#comment-13691670 ] ASF subversion and git services commented on TS-745: Commit 8006abcbe740af4a78a7e4e918b4ddaff2c62f79 in branch refs/heads/master from [~taorui] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=8006abc ] TS-745: support interim caching in storage this is one of the SSD project result, the current solution make a interim block cache layer between the storage and ram cache. two records directive added. proxy.config.cache.interim.storage: disk device(s) for the interim cache proxy.config.cache.interim.migrate_threshold: controls how many times one content should be migrate to the interim cache from the storage Signed-off-by: Zhao Yongming ming@gmail.com Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: weijin Fix For: 3.3.6 Attachments: 0001-TS-745-support-interim-caching-in-storage.patch, 0001-TS-745-support-interim-caching-in-storage_rebased.patch, ts-745.diff, TS-ssd-2.patch, TS-ssd.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691074#comment-13691074 ] Zhao Yongming commented on TS-745: -- this feature is disabled by configure options, by default. and the disk format change, in #DEFINED out if you do not enable in configure. I think that is fairly safe for common users. and for who enable this feature, he will aware of all the pins. and someone may work out the perfect solution for multi-tiered storage later, or we don't need it anymore if we find out that the slowest disk is SSD years later, we can safely revert then. is that ok? Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: weijin Fix For: 3.3.6 Attachments: 0001-TS-745-support-interim-caching-in-storage.patch, 0001-TS-745-support-interim-caching-in-storage_rebased.patch, ts-745.diff, TS-ssd-2.patch, TS-ssd.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691167#comment-13691167 ] Leif Hedstrom commented on TS-745: -- Yep, good with me. So in the normal build, everything in the disk layout is as it was, right? Long term, it'd be nice to have this configurable at run-time instead, which makes it easier to test (off by default of course). Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: weijin Fix For: 3.3.6 Attachments: 0001-TS-745-support-interim-caching-in-storage.patch, 0001-TS-745-support-interim-caching-in-storage_rebased.patch, ts-745.diff, TS-ssd-2.patch, TS-ssd.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691029#comment-13691029 ] Leif Hedstrom commented on TS-745: -- Question: does this patch preserve the old cache/directory format when the feature is not enabled? I agree with John that doing these invasive changes, particularly changing the directory size, and the coupling between disks, is potentially bad. If however the cache is backward compatible with these features disabled, I'm ok with landing it for v3.4. Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: weijin Fix For: 3.3.6 Attachments: 0001-TS-745-support-interim-caching-in-storage.patch, 0001-TS-745-support-interim-caching-in-storage_rebased.patch, ts-745.diff, TS-ssd-2.patch, TS-ssd.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13662756#comment-13662756 ] weijin commented on TS-745: --- the ssd is treated as the (block) cache of hdd disk, and the ssd dir will be cleared when you start (restart) ats, so it also can unplug any hdd disk and change it back. I admit this patch is pretty invasive and make cache more complicated, and I appropriate that someone can give us a more general and elegant design of tired cache solution. Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: weijin Fix For: 3.3.5 Attachments: 0001-TS-745-support-interim-caching-in-storage.patch, ts-745.diff, TS-ssd-2.patch, TS-ssd.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13663697#comment-13663697 ] John Plevyak commented on TS-745: - Humm... let me read over the code. An SSD layer is necessary at this point, and if this is ephemeral, I am sure we can find a clean integration. thanx! Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: weijin Fix For: 3.3.5 Attachments: 0001-TS-745-support-interim-caching-in-storage.patch, ts-745.diff, TS-ssd-2.patch, TS-ssd.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13662551#comment-13662551 ] Zhao Yongming commented on TS-745: -- yeah, I'd like that too, then we don't have to enable that by configure :D Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: weijin Fix For: 3.3.5 Attachments: 0001-TS-745-support-interim-caching-in-storage.patch, ts-745.diff, TS-ssd-2.patch, TS-ssd.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13662684#comment-13662684 ] John Plevyak commented on TS-745: - I think the idea of stealing bits from the directory which are hard coded to point off device (off the hard disk which the directory is a part of) is a huge design departure and a problem. When the cache was first built, it was limited to 8GB disks which seemed HUGE. For Apache I extended it to .5PB as by then 8GB was far too small. Currently disks are at 4TB and this patch would decrease the limit from .5PB to 32TB which gives us only a few years headroom, not a good idea. Furthermore, the current design let's you unplug any cache disk from any machine, move it to another machine and have your cache back. This change stores SSD information in the HDD directory! why? Changing the configuration, a disk or machine failure, etc. invalidates that information corrupting the cache. Why not store that information in a side structure and either store it only in memory only or on the SSD? The idea of storing the SSD configuration in a string in records.config is also a bad idea. Overall, a stacked cache seems like a better idea or a minimally invasive extension would be great. This patch is pretty invasive, duplicates code and generally touches many bits of the code. The ram cache for example uses no bits in the HDD directory and only a couple entry points at well defined places (insert, lookup and delete/invalidate). This patch looks to incur more technical depth at a time when I think we would like to decrease the technical debt. For example, it would be nice to have more smaller locks, move the HTTP support out of the core via a well defined interface, add layering, etc. Adding yet another set of core code paths is going to make those changes harder. my 2 cents. Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: weijin Fix For: 3.3.5 Attachments: 0001-TS-745-support-interim-caching-in-storage.patch, ts-745.diff, TS-ssd-2.patch, TS-ssd.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631376#comment-13631376 ] James Peach commented on TS-745: FWIW, I'm fine with this plan. We need to ensure that the various features co-operate in a sensible fashion, but I'm also OK with supporting Taobao's need for compatibility with the records.config options. Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: weijin Fix For: 3.3.4 Attachments: ts-745.diff, TS-ssd-2.patch, TS-ssd.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[
https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631084#comment-13631084
]
Leif Hedstrom commented on TS-745:
--
We had a long, heated discussion about this, so capturing some of this in this
email.
First, we all agree that this should be a Tiered Cache, and not specific to
SSD. So code and configs etc. should properly reflect that.
Secondly, I obviously dislike the idea of storing some disk configs in
storage.config, and some in records.config. I understand making this change is
a big deal for Taobao, so I'm offering a compromise:
1) We add support for storage.config, with a new tag similar to the tag
TS-1728. Maybe something like
{code}
/dev/sda tier=1
/dev/sdb tier=1
/dev/sdc tier=2
/dev/sdd tier=2
{code}
Where tier=1 is SSD (or whatever fast storage device you have, what currently
gets configured in records.config) and tier=2 is all other disks (what's
currently in storage.config).
2) In addition, we keep the records.config setting in mgmt/RecordsConfig.cc,
and make it populate the tier=1 disks. This option will not be documented, or
added to records.config.default.in. It's purely there to allow Taobao to merge
with upstream and not having to maintain a fork. Long term, I'd imagine this
config goes away, as we refactor all the configuraitons into a unified
VirtualHost conceptual config.
James and I (and hopefully John too) will continue reviewing this complicated
piece of code in the next week or two. The goal is to land this for v3.3.3,
which is Mid-May. We do need to make sure this also doesn't conflict with
TS-1728, which also should be landed for v3.3.3.
Feedback please.
Support ssd
---
Key: TS-745
URL: https://issues.apache.org/jira/browse/TS-745
Project: Traffic Server
Issue Type: New Feature
Components: Cache
Reporter: mohan_zl
Assignee: weijin
Fix For: 3.3.4
Attachments: ts-745.diff, TS-ssd-2.patch, TS-ssd.patch
A patch for supporting, not work well for a long time with --enable-debug
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631106#comment-13631106 ] Zhao Yongming commented on TS-745: -- well, I can not tell how to merge the config with TS-1728, that is working on the volume assign tricky, but we are working on the block level. I really like to get some idea how the performance compared in Comcast. in common case, if you can identify what is the good way to use the disks, you can make a good usage by assign the SSDs to the site that really need it. in real production, you'd need to figure that out, and monitor it and adapt when they changed, sounds not that good for complex site question is, when we merge both patches, how to tell the system, we just care of some disks and assign some tiered storage for them, but not other disks? sounds some complex matrix, or some more coding needed /dev/sda tier=1 volume=2 /dev/sdb tier=1 volume=1 /dev/sdc tier=2 volume=1 /dev/sdd tier=2 volume=3 Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: weijin Fix For: 3.3.4 Attachments: ts-745.diff, TS-ssd-2.patch, TS-ssd.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631210#comment-13631210 ] Leif Hedstrom commented on TS-745: -- Exactly, that's why we need to figure this out together, and not do one off hacks :). Having both TS-745 and TS-1728 seems fine with me, but they need to cooperate together nicely (even if it means one takes priority over the other). Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: weijin Fix For: 3.3.4 Attachments: ts-745.diff, TS-ssd-2.patch, TS-ssd.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630673#comment-13630673 ] Leif Hedstrom commented on TS-745: -- Couple of things with the latest patch: 1) Configuration for this does most certainly not belong in records.config. It should be integrated with storage.config (and perhaps hosting.config and volumes.config as well). 2) I dislike that we use the variable/method/config names with SSD in them. The configure option is to enable tiered storage, and I think the code and configs should reflect this as well. Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: weijin Fix For: 3.3.4 Attachments: ts-745.diff, TS-ssd-2.patch, TS-ssd.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13473016#comment-13473016 ] Zhao Yongming commented on TS-745: -- after discuss on the IRC, we'd start to merge and rebase the codes onto git master, and prepare for code review. Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: weijin Fix For: 3.3.1 Attachments: TS-ssd-2.patch, TS-ssd.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13443029#comment-13443029 ] Igor Galić commented on TS-745: --- Can you please rebase this branch against the current trunk? Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: mohan_zl Fix For: 3.3.1 Attachments: TS-ssd-2.patch, TS-ssd.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13443208#comment-13443208 ] Zhao Yongming commented on TS-745: -- woo, that will be a tough task. and Wei Jin had make another implement on tiered storage, which is based on 3.0.x tree, codes on: https://gitorious.org/trafficserver/taobao/commits/new_tbtrunk_ssd, without docs as always. the tiered storage does not work well with multi-volume config for now. I am still not sure we should move forward to merge it in our office tree or not, although it works perfect for me. in my hardware spec, mem:ssd:sas=1:10:100. if you guys think the tiered storage is a right way to go, we will merge it into the git master. thanks Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: mohan_zl Fix For: 3.3.1 Attachments: TS-ssd-2.patch, TS-ssd.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13056420#comment-13056420 ] Zhao Yongming commented on TS-745: -- done commit the TS-ssd.patch into branch ssd. Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: mohan_zl Fix For: 3.1.0 Attachments: TS-ssd.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13038371#comment-13038371 ] mohan_zl commented on TS-745: - In my thoughts, if we use the same CacheVC to write after calling back the user, we can do it before free_CacheVC, but when i did this, i could not pass the function test. Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: mohan_zl Fix For: 3.1 Attachments: ssd_cache.patch, ssd_cache2.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13038374#comment-13038374 ] mohan_zl commented on TS-745: - My boss have give me another passport to visit http://codereview.appspot.com/. John, i did not search the traffic server results in this site. Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: mohan_zl Fix For: 3.1 Attachments: ssd_cache.patch, ssd_cache2.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13035178#comment-13035178 ] mohan_zl commented on TS-745: - +1 on a branch. I am busy on preparing ts for online use these days, sorry for looking at this so late. Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: mohan_zl Fix For: 3.1 Attachments: ssd_cache.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13031254#comment-13031254 ] John Plevyak commented on TS-745: - We should make a branch for this. Then we could collaborate. I would also like to simplify locking in the cache by getting rid of the TryLocks for the partition. This would make it easier to write the SSD code to handle multiple SSDs I think. What do you think mohan_zl? Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: mohan_zl Attachments: ssd_cache.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-745) Support ssd
[ https://issues.apache.org/jira/browse/TS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13024839#comment-13024839 ] John Plevyak commented on TS-745: - Overall several comments: 1) Once we get it working we need to reorganize the patch so that we avoid code duplication. 2) The limitation of a single SSD is probably overly restrictive. SSDs are relatively inexpensive now and it is very likely that folks will want to have 1 per disk or better yet some combination of SSD and SATA. 3) The code uses xmalloc to store docs and creates another CacheVC to do the write in the background. We would be using the various allocators rather than xmalloc and we should be adding states rather than creating another CacheVC. The write can occur after calling back the user, so there will be no additional latency. 4) The code doesn't seem to have provision for handling multi-fragment documents. There are some tradeoffs there, but in any case the issues needs to be considered. Handling of multi-fragment documents requires tighter control over when the write is done and if and when it is successful. Again, this would indicate we should be doing the write on the same CacheVC in additional states. 5) The code needs to deal collisions after the initial directory is looked up. Again, this would be easier if the SSD code was operating in the same CacheVC. Please think about these comments. Let's use http://codereview.appspot.com/ for detailed reviews. I have already added traffic server as a repository. I have imported the patch as well, but I think we still have some design discussion to do before we can get into the details. Support ssd --- Key: TS-745 URL: https://issues.apache.org/jira/browse/TS-745 Project: Traffic Server Issue Type: New Feature Components: Cache Reporter: mohan_zl Assignee: mohan_zl Attachments: ssd_cache.patch A patch for supporting, not work well for a long time with --enable-debug -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
