[jira] [Commented] (TS-984) LogFile::roll crash at Machine::instance

[Alan M. Carroll (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142565#comment-13142565
 ] 

Alan M. Carroll commented on TS-984:


Problem identified and fixed.

 LogFile::roll crash at Machine::instance
 

 Key: TS-984
 URL: https://issues.apache.org/jira/browse/TS-984
 Project: Traffic Server
  Issue Type: Bug
  Components: Logging
Affects Versions: 3.1.0
Reporter: Zhao Yongming
Assignee: Alan M. Carroll
  Labels: crash
 Fix For: 3.1.1

 Attachments: ts-984.diff


 this is a strange error when I testing the current trunk with logging 
 colation server enabled:
 {code}
 [Oct 16 01:24:48.643] Server {0x2b4967f51760} WARNING: File 
 /var/log/trafficserver/ex_squid.log will be rolled because a LogObject with 
 different format is requesting the same filename
 FATAL: Machine.cc:37: failed assert `_instance || !Machine instance accessed 
 before initialization`
 /usr/bin/traffic_server - STACK TRACE: 
 /usr/lib64/trafficserver/libtsutil.so.3(ink_fatal_va+0xc5)[0x2b49651a5109]
 /usr/lib64/trafficserver/libtsutil.so.3(ink_fatal+0xa3)[0x2b49651a51bb]
 /usr/lib64/trafficserver/libtsutil.so.3(_ink_assert+0xc2)[0x2b49651a3aee]
 /usr/bin/traffic_server(Machine::instance()+0x24)[0x634a04]
 /usr/bin/traffic_server(LogFile::roll(long, long)+0x230)[0x5f8138]
 /usr/bin/traffic_server(LogObjectManager::_solve_filename_conflicts(LogObject*,
  int)+0x489)[0x603263]
 /usr/bin/traffic_server(LogObjectManager::_manage_object(LogObject*, bool, 
 int)+0x126)[0x6029ea]
 /usr/bin/traffic_server(LogObjectManager::manage_object(LogObject*, 
 int)+0x2d)[0x5e9e27]
 /usr/bin/traffic_server(LogConfig::read_xml_log_config(int)+0x3189)[0x5f28c9]
 /usr/bin/traffic_server(LogConfig::setup_log_objects()+0x229)[0x5edd63]
 /usr/bin/traffic_server(LogConfig::init(LogConfig*)+0x254)[0x5ec3ea]
 /usr/bin/traffic_server(Log::init(int)+0x30c)[0x5e8134]
 /usr/bin/traffic_server(main+0xb6a)[0x5161a4]
 /lib64/libc.so.6(__libc_start_main+0xfd)[0x2b49673b4ebd]
 /usr/bin/traffic_server[0x4cc789]
 {code}
 there is two problem here:
 1, why the machine is not initialized?
 2, what does WARNING: File /var/log/trafficserver/ex_squid.log will be 
 rolled because a LogObject with different format is requesting the same 
 filename mean? is that harm?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TS-984) LogFile::roll crash at Machine::instance

[Alan M. Carroll (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140665#comment-13140665
 ] 

Alan M. Carroll commented on TS-984:


After testing by submitter and no reports of problems, I am comitting this 
patch.

 LogFile::roll crash at Machine::instance
 

 Key: TS-984
 URL: https://issues.apache.org/jira/browse/TS-984
 Project: Traffic Server
  Issue Type: Bug
  Components: Logging
Affects Versions: 3.1.0
Reporter: Zhao Yongming
Assignee: Alan M. Carroll
  Labels: crash
 Fix For: 3.1.1

 Attachments: ts-984.diff


 this is a strange error when I testing the current trunk with logging 
 colation server enabled:
 {code}
 [Oct 16 01:24:48.643] Server {0x2b4967f51760} WARNING: File 
 /var/log/trafficserver/ex_squid.log will be rolled because a LogObject with 
 different format is requesting the same filename
 FATAL: Machine.cc:37: failed assert `_instance || !Machine instance accessed 
 before initialization`
 /usr/bin/traffic_server - STACK TRACE: 
 /usr/lib64/trafficserver/libtsutil.so.3(ink_fatal_va+0xc5)[0x2b49651a5109]
 /usr/lib64/trafficserver/libtsutil.so.3(ink_fatal+0xa3)[0x2b49651a51bb]
 /usr/lib64/trafficserver/libtsutil.so.3(_ink_assert+0xc2)[0x2b49651a3aee]
 /usr/bin/traffic_server(Machine::instance()+0x24)[0x634a04]
 /usr/bin/traffic_server(LogFile::roll(long, long)+0x230)[0x5f8138]
 /usr/bin/traffic_server(LogObjectManager::_solve_filename_conflicts(LogObject*,
  int)+0x489)[0x603263]
 /usr/bin/traffic_server(LogObjectManager::_manage_object(LogObject*, bool, 
 int)+0x126)[0x6029ea]
 /usr/bin/traffic_server(LogObjectManager::manage_object(LogObject*, 
 int)+0x2d)[0x5e9e27]
 /usr/bin/traffic_server(LogConfig::read_xml_log_config(int)+0x3189)[0x5f28c9]
 /usr/bin/traffic_server(LogConfig::setup_log_objects()+0x229)[0x5edd63]
 /usr/bin/traffic_server(LogConfig::init(LogConfig*)+0x254)[0x5ec3ea]
 /usr/bin/traffic_server(Log::init(int)+0x30c)[0x5e8134]
 /usr/bin/traffic_server(main+0xb6a)[0x5161a4]
 /lib64/libc.so.6(__libc_start_main+0xfd)[0x2b49673b4ebd]
 /usr/bin/traffic_server[0x4cc789]
 {code}
 there is two problem here:
 1, why the machine is not initialized?
 2, what does WARNING: File /var/log/trafficserver/ex_squid.log will be 
 rolled because a LogObject with different format is requesting the same 
 filename mean? is that harm?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TS-984) LogFile::roll crash at Machine::instance

[Zhao Yongming (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13128420#comment-13128420
 ] 

Zhao Yongming commented on TS-984:
--

in the #2:
what I have done is that we I have both the logging colation clients and server 
have the same logging format name defined in logs_xml.config, but I make some 
change in the server, so the difine is not the same in the Format:
{code}
zymtest1 trafficserver # cat logs_xml.config | grep combined
  Format = combined [%cqtn] %chi %phi 81 %ttms \%{Referer}cqh\ 
\%cqtx\ %pssc %cqhl %psql %psct %crc \%{User-Agent}cqh\ 
%cquuc %cquup /
zymtest1 trafficserver # ssh 10.62.163.237 grep combined 
/etc/trafficserver/logs_xml.config
  Format = combined [%cqtn] %chi %phi 81 %ttms \%{Referer}cqh\ 
\%cqtx\ %pssc %cqhl %psql %psct %crc \%{User-Agent}cqh\ /
{code}

that is the most stupid settings in the world, but you can not stop me doing 
that. :D

 LogFile::roll crash at Machine::instance
 

 Key: TS-984
 URL: https://issues.apache.org/jira/browse/TS-984
 Project: Traffic Server
  Issue Type: Bug
  Components: Logging
Affects Versions: 3.1.0
Reporter: Zhao Yongming
Assignee: Alan M. Carroll
  Labels: crash
 Fix For: 3.1.1


 this is a strange error when I testing the current trunk with logging 
 colation server enabled:
 {code}
 [Oct 16 01:24:48.643] Server {0x2b4967f51760} WARNING: File 
 /var/log/trafficserver/ex_squid.log will be rolled because a LogObject with 
 different format is requesting the same filename
 FATAL: Machine.cc:37: failed assert `_instance || !Machine instance accessed 
 before initialization`
 /usr/bin/traffic_server - STACK TRACE: 
 /usr/lib64/trafficserver/libtsutil.so.3(ink_fatal_va+0xc5)[0x2b49651a5109]
 /usr/lib64/trafficserver/libtsutil.so.3(ink_fatal+0xa3)[0x2b49651a51bb]
 /usr/lib64/trafficserver/libtsutil.so.3(_ink_assert+0xc2)[0x2b49651a3aee]
 /usr/bin/traffic_server(Machine::instance()+0x24)[0x634a04]
 /usr/bin/traffic_server(LogFile::roll(long, long)+0x230)[0x5f8138]
 /usr/bin/traffic_server(LogObjectManager::_solve_filename_conflicts(LogObject*,
  int)+0x489)[0x603263]
 /usr/bin/traffic_server(LogObjectManager::_manage_object(LogObject*, bool, 
 int)+0x126)[0x6029ea]
 /usr/bin/traffic_server(LogObjectManager::manage_object(LogObject*, 
 int)+0x2d)[0x5e9e27]
 /usr/bin/traffic_server(LogConfig::read_xml_log_config(int)+0x3189)[0x5f28c9]
 /usr/bin/traffic_server(LogConfig::setup_log_objects()+0x229)[0x5edd63]
 /usr/bin/traffic_server(LogConfig::init(LogConfig*)+0x254)[0x5ec3ea]
 /usr/bin/traffic_server(Log::init(int)+0x30c)[0x5e8134]
 /usr/bin/traffic_server(main+0xb6a)[0x5161a4]
 /lib64/libc.so.6(__libc_start_main+0xfd)[0x2b49673b4ebd]
 /usr/bin/traffic_server[0x4cc789]
 {code}
 there is two problem here:
 1, why the machine is not initialized?
 2, what does WARNING: File /var/log/trafficserver/ex_squid.log will be 
 rolled because a LogObject with different format is requesting the same 
 filename mean? is that harm?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira