[ 
https://issues.apache.org/jira/browse/TS-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom resolved TS-1181.
-------------------------------

    Resolution: Fixed

I believe / hope this is fixed with the changes below. William, can you please 
take a look, and reopen this bug if there's still a problem.

{code}
commit 3cf51ee61a11ce69632ef8bf6bddef01236355b9
Author:     Leif Hedstrom <zw...@apache.org>
AuthorDate: Tue May 8 13:43:30 2012 -0600
Commit:     Leif Hedstrom <zw...@apache.org>
CommitDate: Tue May 8 13:47:57 2012 -0600

    TS-1181 Reorder some struct members, to make all byte configs near each 
other (less padding)

commit f6fefd4c9ace2a2b6f9eb9c9a8da7e2f995eb7e6
Author:     Leif Hedstrom <zw...@apache.org>
AuthorDate: Mon May 7 20:30:36 2012 -0600
Commit:     Leif Hedstrom <zw...@apache.org>
CommitDate: Tue May 8 13:47:57 2012 -0600

    TS-1181 Make the overridable configs work properly with "byte" configs.
{code}
                
> TSHttpTxnConfigInt* don't look right with MgmtByte fields in 
> OverridableHttpConfigParams
> ----------------------------------------------------------------------------------------
>
>                 Key: TS-1181
>                 URL: https://issues.apache.org/jira/browse/TS-1181
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: TS API
>    Affects Versions: 3.0.4
>            Reporter: William Bardwell
>            Assignee: Leif Hedstrom
>            Priority: Minor
>             Fix For: 3.1.4
>
>
> TSHttpTxnConfigIntSet and Get use _conf_to_memberp to get a pointer to 
> various fields, and then access it as a 32bit int.  But many of the fields 
> are now bytes.  A fix would be to make _conf_to_memberp return the type 
> properly, and make TSHttpTxnConfigInt* access the field as the proper size.
> I saw valgrind complaining about uninitialized data from the code (which is 
> probably because of padding in the structure, since it is cleared a field at 
> a time), but there are probably much worse effects around reading and writing 
> unrelated fields.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to