[jira] [Updated] (TS-3156) Mutex[Try]Lock bool() operator change and unused API removal
[ https://issues.apache.org/jira/browse/TS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-3156: -- Backport to Version: (was: 5.2.0) Mutex[Try]Lock bool() operator change and unused API removal Key: TS-3156 URL: https://issues.apache.org/jira/browse/TS-3156 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Powell Molleti Assignee: Alan M. Carroll Priority: Minor Labels: review Fix For: 5.2.0 Attachments: MutexLock-ats.patch, MutexLock-ats.patch, Use-Ryo-s-patch-to-pass-shared_ptr-to-MutexLock.patch, fix-MutexLock.patch Removed unused constructor in MutexLock along with set_and_take() method, had to change FORCE_PLUGIN_MUTEX() for that. Removed release() method. default bool and ! operator from both MutexLock and MutexTryLock with is_locked() API. Changes if (lock) to if (lock.is_locked()) across the code base. Ran make test will be performing more system testing. Posted before for early comments / feedback. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TS-3156) Mutex[Try]Lock bool() operator change and unused API removal
[ https://issues.apache.org/jira/browse/TS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Susan Hinrichs updated TS-3156: --- Assignee: Alan M. Carroll (was: James Peach) Mutex[Try]Lock bool() operator change and unused API removal Key: TS-3156 URL: https://issues.apache.org/jira/browse/TS-3156 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Powell Molleti Assignee: Alan M. Carroll Priority: Minor Labels: review Fix For: 5.2.0 Attachments: MutexLock-ats.patch, MutexLock-ats.patch, Use-Ryo-s-patch-to-pass-shared_ptr-to-MutexLock.patch, fix-MutexLock.patch Removed unused constructor in MutexLock along with set_and_take() method, had to change FORCE_PLUGIN_MUTEX() for that. Removed release() method. default bool and ! operator from both MutexLock and MutexTryLock with is_locked() API. Changes if (lock) to if (lock.is_locked()) across the code base. Ran make test will be performing more system testing. Posted before for early comments / feedback. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TS-3156) Mutex[Try]Lock bool() operator change and unused API removal
[
https://issues.apache.org/jira/browse/TS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryo Okubo updated TS-3156:
--
Attachment: fix-MutexLock.patch
The cause of above issue is probably calling pthread_mutex_lock() for
destroyed mutex lock.
If a variable of ProxyMutex* is passed to MUTEX_LOCK(), it's destroyed when
leaving that scope. For example, pthread_mutex_destroy() is called in
MakeHttpProxyAcceptor():
{noformat}
(gdb) bt
#0 0x77830e70 in pthread_mutex_destroy () from /lib64/libpthread.so.0
#1 0x004e03da in ink_mutex_destroy (m=0xac7890) at
../lib/ts/ink_mutex.h:87
#2 0x004e15c2 in ProxyMutex::free (this=0xac7880) at
../iocore/eventsystem/I_Lock.h:543
#3 0x004e2f39 in PtrProxyMutex::~Ptr (this=0x7fffe3b0,
__in_chrg=value optimized out) at ../lib/ts/Ptr.h:393
#4 0x00520f17 in MutexLock::~MutexLock (this=0x7fffe3b0,
__in_chrg=value optimized out) at ../iocore/eventsystem/I_Lock.h:465
#5 0x005cea60 in MakeHttpProxyAcceptor (acceptor=..., port=...,
nthreads=1) at HttpProxyServerMain.cc:230
#6 0x005cec45 in init_HttpProxyServer (n_accept_threads=1) at
HttpProxyServerMain.cc:270
#7 0x0052aded in main (argv=0x7fffe7a8) at Main.cc:1554
{noformat}
I tried to replace ProxyMutex* with PtrProxyMutex. It looks to work fine.
@Powell, what do you think about fix-MutexLock.patch?
Mutex[Try]Lock bool() operator change and unused API removal
Key: TS-3156
URL: https://issues.apache.org/jira/browse/TS-3156
Project: Traffic Server
Issue Type: Improvement
Components: Core
Reporter: Powell Molleti
Assignee: James Peach
Priority: Minor
Labels: review
Fix For: 5.2.0
Attachments: MutexLock-ats.patch, MutexLock-ats.patch,
fix-MutexLock.patch
Removed unused constructor in MutexLock along with set_and_take() method, had
to change FORCE_PLUGIN_MUTEX() for that. Removed release() method.
default bool and ! operator from both MutexLock and MutexTryLock with
is_locked() API. Changes if (lock) to if (lock.is_locked()) across the code
base.
Ran make test will be performing more system testing. Posted before for early
comments / feedback.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TS-3156) Mutex[Try]Lock bool() operator change and unused API removal
[ https://issues.apache.org/jira/browse/TS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Powell Molleti updated TS-3156: --- Attachment: Use-Ryo-s-patch-to-pass-shared_ptr-to-MutexLock.patch Fix the issue caught by Ryo, modified Ryo's patch to bring the code closer to the original implementation. Mutex[Try]Lock bool() operator change and unused API removal Key: TS-3156 URL: https://issues.apache.org/jira/browse/TS-3156 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Powell Molleti Assignee: James Peach Priority: Minor Labels: review Fix For: 5.2.0 Attachments: MutexLock-ats.patch, MutexLock-ats.patch, Use-Ryo-s-patch-to-pass-shared_ptr-to-MutexLock.patch, fix-MutexLock.patch Removed unused constructor in MutexLock along with set_and_take() method, had to change FORCE_PLUGIN_MUTEX() for that. Removed release() method. default bool and ! operator from both MutexLock and MutexTryLock with is_locked() API. Changes if (lock) to if (lock.is_locked()) across the code base. Ran make test will be performing more system testing. Posted before for early comments / feedback. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TS-3156) Mutex[Try]Lock bool() operator change and unused API removal
[ https://issues.apache.org/jira/browse/TS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Powell Molleti updated TS-3156: --- Attachment: MutexLock-ats.patch Addressed Alan's comments, removed ink_scoped_mutex and ink_scoped_try_mutex Mutex[Try]Lock bool() operator change and unused API removal Key: TS-3156 URL: https://issues.apache.org/jira/browse/TS-3156 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Powell Molleti Assignee: James Peach Priority: Minor Labels: review Fix For: 5.2.0 Attachments: MutexLock-ats.patch, MutexLock-ats.patch Removed unused constructor in MutexLock along with set_and_take() method, had to change FORCE_PLUGIN_MUTEX() for that. Removed release() method. default bool and ! operator from both MutexLock and MutexTryLock with is_locked() API. Changes if (lock) to if (lock.is_locked()) across the code base. Ran make test will be performing more system testing. Posted before for early comments / feedback. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TS-3156) Mutex[Try]Lock bool() operator change and unused API removal
[ https://issues.apache.org/jira/browse/TS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-3156: -- Labels: review (was: ) Mutex[Try]Lock bool() operator change and unused API removal Key: TS-3156 URL: https://issues.apache.org/jira/browse/TS-3156 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Powell Molleti Priority: Minor Labels: review Fix For: 5.2.0 Attachments: MutexLock-ats.patch Removed unused constructor in MutexLock along with set_and_take() method, had to change FORCE_PLUGIN_MUTEX() for that. Removed release() method. default bool and ! operator from both MutexLock and MutexTryLock with is_locked() API. Changes if (lock) to if (lock.is_locked()) across the code base. Ran make test will be performing more system testing. Posted before for early comments / feedback. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TS-3156) Mutex[Try]Lock bool() operator change and unused API removal
[ https://issues.apache.org/jira/browse/TS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-3156: -- Fix Version/s: 5.2.0 Mutex[Try]Lock bool() operator change and unused API removal Key: TS-3156 URL: https://issues.apache.org/jira/browse/TS-3156 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Powell Molleti Priority: Minor Labels: review Fix For: 5.2.0 Attachments: MutexLock-ats.patch Removed unused constructor in MutexLock along with set_and_take() method, had to change FORCE_PLUGIN_MUTEX() for that. Removed release() method. default bool and ! operator from both MutexLock and MutexTryLock with is_locked() API. Changes if (lock) to if (lock.is_locked()) across the code base. Ran make test will be performing more system testing. Posted before for early comments / feedback. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TS-3156) Mutex[Try]Lock bool() operator change and unused API removal
[ https://issues.apache.org/jira/browse/TS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Powell Molleti updated TS-3156: --- Priority: Minor (was: Major) Mutex[Try]Lock bool() operator change and unused API removal Key: TS-3156 URL: https://issues.apache.org/jira/browse/TS-3156 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Powell Molleti Priority: Minor Attachments: MutexLock-ats.patch Removed unused constructor in MutexLock along with set_and_take() method, had to change FORCE_PLUGIN_MUTEX() for that. Removed release() method. default bool and ! operator from both MutexLock and MutexTryLock with is_locked() API. Changes if (lock) to if (lock.is_locked()) across the code base. Ran make test will be performing more system testing. Posted before for early comments / feedback. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TS-3156) Mutex[Try]Lock bool() operator change and unused API removal
[ https://issues.apache.org/jira/browse/TS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Powell Molleti updated TS-3156: --- Attachment: MutexLock-ats.patch Patch cut against latest git clone. Mutex[Try]Lock bool() operator change and unused API removal Key: TS-3156 URL: https://issues.apache.org/jira/browse/TS-3156 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Powell Molleti Attachments: MutexLock-ats.patch Removed unused constructor in MutexLock along with set_and_take() method, had to change FORCE_PLUGIN_MUTEX() for that. Removed release() method. default bool and ! operator from both MutexLock and MutexTryLock with is_locked() API. Changes if (lock) to if (lock.is_locked()) across the code base. Ran make test will be performing more system testing. Posted before for early comments / feedback. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
