[jira] [Work logged] (TS-3965) regex_remap plugin does not deal with all possible redirects
[ https://issues.apache.org/jira/browse/TS-3965?focusedWorklogId=26100=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26100 ] ASF GitHub Bot logged work on TS-3965: -- Author: ASF GitHub Bot Created on: 30/Jul/16 17:55 Start Date: 30/Jul/16 17:55 Worklog Time Spent: 10m Work Description: Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/832 Issue Time Tracking --- Worklog Id: (was: 26100) Time Spent: 1h (was: 50m) > regex_remap plugin does not deal with all possible redirects > > > Key: TS-3965 > URL: https://issues.apache.org/jira/browse/TS-3965 > Project: Traffic Server > Issue Type: Improvement > Components: Plugins >Reporter: Leif Hedstrom >Assignee: David Ben Zakai > Labels: newbie > Fix For: 7.0.0 > > Time Spent: 1h > Remaining Estimate: 0h > > There are some old, and new, redirect status codes, that the regex_remap > plugin ought to handle as redirects (setting the redirect flag). > In the code, we only test for this: > {code} > if (re->status_option() != TS_HTTP_STATUS_MOVED_PERMANENTLY && > re->status_option() != TS_HTTP_STATUS_MOVED_TEMPORARILY) { > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-3965) regex_remap plugin does not deal with all possible redirects
[ https://issues.apache.org/jira/browse/TS-3965?focusedWorklogId=26097=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26097 ] ASF GitHub Bot logged work on TS-3965: -- Author: ASF GitHub Bot Created on: 30/Jul/16 17:38 Start Date: 30/Jul/16 17:38 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/832 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/387/ for details. Issue Time Tracking --- Worklog Id: (was: 26097) Time Spent: 50m (was: 40m) > regex_remap plugin does not deal with all possible redirects > > > Key: TS-3965 > URL: https://issues.apache.org/jira/browse/TS-3965 > Project: Traffic Server > Issue Type: Improvement > Components: Plugins >Reporter: Leif Hedstrom >Assignee: David Ben Zakai > Labels: newbie > Fix For: 7.0.0 > > Time Spent: 50m > Remaining Estimate: 0h > > There are some old, and new, redirect status codes, that the regex_remap > plugin ought to handle as redirects (setting the redirect flag). > In the code, we only test for this: > {code} > if (re->status_option() != TS_HTTP_STATUS_MOVED_PERMANENTLY && > re->status_option() != TS_HTTP_STATUS_MOVED_TEMPORARILY) { > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-3965) regex_remap plugin does not deal with all possible redirects
[ https://issues.apache.org/jira/browse/TS-3965?focusedWorklogId=26096=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26096 ] ASF GitHub Bot logged work on TS-3965: -- Author: ASF GitHub Bot Created on: 30/Jul/16 17:33 Start Date: 30/Jul/16 17:33 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/832 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/490/ for details. Issue Time Tracking --- Worklog Id: (was: 26096) Time Spent: 40m (was: 0.5h) > regex_remap plugin does not deal with all possible redirects > > > Key: TS-3965 > URL: https://issues.apache.org/jira/browse/TS-3965 > Project: Traffic Server > Issue Type: Improvement > Components: Plugins >Reporter: Leif Hedstrom >Assignee: David Ben Zakai > Labels: newbie > Fix For: 7.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > > There are some old, and new, redirect status codes, that the regex_remap > plugin ought to handle as redirects (setting the redirect flag). > In the code, we only test for this: > {code} > if (re->status_option() != TS_HTTP_STATUS_MOVED_PERMANENTLY && > re->status_option() != TS_HTTP_STATUS_MOVED_TEMPORARILY) { > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-3965) regex_remap plugin does not deal with all possible redirects
[ https://issues.apache.org/jira/browse/TS-3965?focusedWorklogId=26092=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26092 ] ASF GitHub Bot logged work on TS-3965: -- Author: ASF GitHub Bot Created on: 30/Jul/16 17:24 Start Date: 30/Jul/16 17:24 Worklog Time Spent: 10m Work Description: Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/832 Looks good, :+1: Issue Time Tracking --- Worklog Id: (was: 26092) Time Spent: 0.5h (was: 20m) > regex_remap plugin does not deal with all possible redirects > > > Key: TS-3965 > URL: https://issues.apache.org/jira/browse/TS-3965 > Project: Traffic Server > Issue Type: Improvement > Components: Plugins >Reporter: Leif Hedstrom > Labels: newbie > Fix For: sometime > > Time Spent: 0.5h > Remaining Estimate: 0h > > There are some old, and new, redirect status codes, that the regex_remap > plugin ought to handle as redirects (setting the redirect flag). > In the code, we only test for this: > {code} > if (re->status_option() != TS_HTTP_STATUS_MOVED_PERMANENTLY && > re->status_option() != TS_HTTP_STATUS_MOVED_TEMPORARILY) { > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-3965) regex_remap plugin does not deal with all possible redirects
[ https://issues.apache.org/jira/browse/TS-3965?focusedWorklogId=26091=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26091 ] ASF GitHub Bot logged work on TS-3965: -- Author: ASF GitHub Bot Created on: 30/Jul/16 17:22 Start Date: 30/Jul/16 17:22 Worklog Time Spent: 10m Work Description: Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/832 [approve ci] Issue Time Tracking --- Worklog Id: (was: 26091) Time Spent: 20m (was: 10m) > regex_remap plugin does not deal with all possible redirects > > > Key: TS-3965 > URL: https://issues.apache.org/jira/browse/TS-3965 > Project: Traffic Server > Issue Type: Improvement > Components: Plugins >Reporter: Leif Hedstrom > Labels: newbie > Fix For: sometime > > Time Spent: 20m > Remaining Estimate: 0h > > There are some old, and new, redirect status codes, that the regex_remap > plugin ought to handle as redirects (setting the redirect flag). > In the code, we only test for this: > {code} > if (re->status_option() != TS_HTTP_STATUS_MOVED_PERMANENTLY && > re->status_option() != TS_HTTP_STATUS_MOVED_TEMPORARILY) { > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-3965) regex_remap plugin does not deal with all possible redirects
[ https://issues.apache.org/jira/browse/TS-3965?focusedWorklogId=26090=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26090 ] ASF GitHub Bot logged work on TS-3965: -- Author: ASF GitHub Bot Created on: 30/Jul/16 08:06 Start Date: 30/Jul/16 08:06 Worklog Time Spent: 10m Work Description: GitHub user davidbz opened a pull request: https://github.com/apache/trafficserver/pull/832 TS-3965: regex_remap plugin does not deal with all possible redirects Newbie here: I'm not sure I got them all, would appreciate a review :) You can merge this pull request into a Git repository by running: $ git pull https://github.com/davidbz/trafficserver TS-3965 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/832.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #832 commit 41e807a7f731631b198c74256cc93911396d9b01 Author: David Ben ZakaiDate: 2016-07-04T04:30:27Z dummy Issue Time Tracking --- Worklog Id: (was: 26090) Time Spent: 10m Remaining Estimate: 0h > regex_remap plugin does not deal with all possible redirects > > > Key: TS-3965 > URL: https://issues.apache.org/jira/browse/TS-3965 > Project: Traffic Server > Issue Type: Improvement > Components: Plugins >Reporter: Leif Hedstrom > Labels: newbie > Fix For: sometime > > Time Spent: 10m > Remaining Estimate: 0h > > There are some old, and new, redirect status codes, that the regex_remap > plugin ought to handle as redirects (setting the redirect flag). > In the code, we only test for this: > {code} > if (re->status_option() != TS_HTTP_STATUS_MOVED_PERMANENTLY && > re->status_option() != TS_HTTP_STATUS_MOVED_TEMPORARILY) { > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)