[jira] [Work logged] (TS-4657) SNI hook sends hook ID for events
[
https://issues.apache.org/jira/browse/TS-4657?focusedWorklogId=28596=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28596
]
ASF GitHub Bot logged work on TS-4657:
--
Author: ASF GitHub Bot
Created on: 09/Sep/16 15:31
Start Date: 09/Sep/16 15:31
Worklog Time Spent: 10m
Work Description: Github user shinrich closed the pull request at:
https://github.com/apache/trafficserver/pull/977
Issue Time Tracking
---
Worklog Id: (was: 28596)
Time Spent: 1.5h (was: 1h 20m)
> SNI hook sends hook ID for events
> -
>
> Key: TS-4657
> URL: https://issues.apache.org/jira/browse/TS-4657
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
>Reporter: James Peach
>Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> If you use the {{TS_SSL_SNI_HOOK}} hook, it will send {{TS_SSL_SNI_HOOK}}
> values as the event. {{TS_SSL_SNI_HOOK}} is not a valid {{TSEvent}} value.
> It is also weird that {{TS_SSL_SNI_HOOK}} and {{TS_SSL_CERT_HOOK}} have the
> same value. One of these ought to be redundant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4657) SNI hook sends hook ID for events
[
https://issues.apache.org/jira/browse/TS-4657?focusedWorklogId=28537=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28537
]
ASF GitHub Bot logged work on TS-4657:
--
Author: ASF GitHub Bot
Created on: 08/Sep/16 21:59
Start Date: 08/Sep/16 21:59
Worklog Time Spent: 10m
Work Description: Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/977
:+1:
Issue Time Tracking
---
Worklog Id: (was: 28537)
Time Spent: 1h 20m (was: 1h 10m)
> SNI hook sends hook ID for events
> -
>
> Key: TS-4657
> URL: https://issues.apache.org/jira/browse/TS-4657
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
>Reporter: James Peach
>Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> If you use the {{TS_SSL_SNI_HOOK}} hook, it will send {{TS_SSL_SNI_HOOK}}
> values as the event. {{TS_SSL_SNI_HOOK}} is not a valid {{TSEvent}} value.
> It is also weird that {{TS_SSL_SNI_HOOK}} and {{TS_SSL_CERT_HOOK}} have the
> same value. One of these ought to be redundant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4657) SNI hook sends hook ID for events
[
https://issues.apache.org/jira/browse/TS-4657?focusedWorklogId=28496=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28496
]
ASF GitHub Bot logged work on TS-4657:
--
Author: ASF GitHub Bot
Created on: 08/Sep/16 19:50
Start Date: 08/Sep/16 19:50
Worklog Time Spent: 10m
Work Description: Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/977
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/750/ for details.
Issue Time Tracking
---
Worklog Id: (was: 28496)
Time Spent: 1h 10m (was: 1h)
> SNI hook sends hook ID for events
> -
>
> Key: TS-4657
> URL: https://issues.apache.org/jira/browse/TS-4657
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
>Reporter: James Peach
>Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> If you use the {{TS_SSL_SNI_HOOK}} hook, it will send {{TS_SSL_SNI_HOOK}}
> values as the event. {{TS_SSL_SNI_HOOK}} is not a valid {{TSEvent}} value.
> It is also weird that {{TS_SSL_SNI_HOOK}} and {{TS_SSL_CERT_HOOK}} have the
> same value. One of these ought to be redundant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4657) SNI hook sends hook ID for events
[
https://issues.apache.org/jira/browse/TS-4657?focusedWorklogId=28495=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28495
]
ASF GitHub Bot logged work on TS-4657:
--
Author: ASF GitHub Bot
Created on: 08/Sep/16 19:50
Start Date: 08/Sep/16 19:50
Worklog Time Spent: 10m
Work Description: Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/977
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/646/ for details.
Issue Time Tracking
---
Worklog Id: (was: 28495)
Time Spent: 1h (was: 50m)
> SNI hook sends hook ID for events
> -
>
> Key: TS-4657
> URL: https://issues.apache.org/jira/browse/TS-4657
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
>Reporter: James Peach
>Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> If you use the {{TS_SSL_SNI_HOOK}} hook, it will send {{TS_SSL_SNI_HOOK}}
> values as the event. {{TS_SSL_SNI_HOOK}} is not a valid {{TSEvent}} value.
> It is also weird that {{TS_SSL_SNI_HOOK}} and {{TS_SSL_CERT_HOOK}} have the
> same value. One of these ought to be redundant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4657) SNI hook sends hook ID for events
[
https://issues.apache.org/jira/browse/TS-4657?focusedWorklogId=28486=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28486
]
ASF GitHub Bot logged work on TS-4657:
--
Author: ASF GitHub Bot
Created on: 08/Sep/16 19:16
Start Date: 08/Sep/16 19:16
Worklog Time Spent: 10m
Work Description: Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/977
It looks like I had an error in the "compile against openssl 1.0.2" case.
FreeBSD must use openssl 1.0.2 and linux must use openssl 1.0.1. Fixing.
Issue Time Tracking
---
Worklog Id: (was: 28486)
Time Spent: 50m (was: 40m)
> SNI hook sends hook ID for events
> -
>
> Key: TS-4657
> URL: https://issues.apache.org/jira/browse/TS-4657
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
>Reporter: James Peach
>Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> If you use the {{TS_SSL_SNI_HOOK}} hook, it will send {{TS_SSL_SNI_HOOK}}
> values as the event. {{TS_SSL_SNI_HOOK}} is not a valid {{TSEvent}} value.
> It is also weird that {{TS_SSL_SNI_HOOK}} and {{TS_SSL_CERT_HOOK}} have the
> same value. One of these ought to be redundant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4657) SNI hook sends hook ID for events
[
https://issues.apache.org/jira/browse/TS-4657?focusedWorklogId=28304=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28304
]
ASF GitHub Bot logged work on TS-4657:
--
Author: ASF GitHub Bot
Created on: 07/Sep/16 16:59
Start Date: 07/Sep/16 16:59
Worklog Time Spent: 10m
Work Description: Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/977
Looks good, but fails on FreeBSD for some reason:
{code}
../../../iocore/net/SSLUtils.cc:384:27: error: use of undeclared identifier
'TS_SSL_CERT_EVENT'; did you mean 'TS_SSL_CERT_HOOK'?
if (!netvc->calledHooks(TS_SSL_CERT_EVENT)) {
^
TS_SSL_CERT_HOOK
../../lib/ts/apidefs.h:290:3: note: 'TS_SSL_CERT_HOOK' declared here
TS_SSL_CERT_HOOK = TS_SSL_SNI_HOOK,
^
../../../iocore/net/SSLUtils.cc:384:27: error: cannot initialize a
parameter of type 'TSEvent' with an rvalue of type 'TSHttpHookID'
if (!netvc->calledHooks(TS_SSL_CERT_EVENT)) {
^
../../../iocore/net/P_SSLNetVConnection.h:221:41: note: passing argument to
parameter here
bool calledHooks(TSEvent /* eventId */) const { return
(this->sslHandshakeHookState != HANDSHAKE_HOOKS_PRE); }
^
{code}
Issue Time Tracking
---
Worklog Id: (was: 28304)
Time Spent: 40m (was: 0.5h)
> SNI hook sends hook ID for events
> -
>
> Key: TS-4657
> URL: https://issues.apache.org/jira/browse/TS-4657
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
>Reporter: James Peach
>Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> If you use the {{TS_SSL_SNI_HOOK}} hook, it will send {{TS_SSL_SNI_HOOK}}
> values as the event. {{TS_SSL_SNI_HOOK}} is not a valid {{TSEvent}} value.
> It is also weird that {{TS_SSL_SNI_HOOK}} and {{TS_SSL_CERT_HOOK}} have the
> same value. One of these ought to be redundant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4657) SNI hook sends hook ID for events
[
https://issues.apache.org/jira/browse/TS-4657?focusedWorklogId=28263=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28263
]
ASF GitHub Bot logged work on TS-4657:
--
Author: ASF GitHub Bot
Created on: 07/Sep/16 03:54
Start Date: 07/Sep/16 03:54
Worklog Time Spent: 10m
Work Description: Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/977
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/615/ for details.
Issue Time Tracking
---
Worklog Id: (was: 28263)
Time Spent: 0.5h (was: 20m)
> SNI hook sends hook ID for events
> -
>
> Key: TS-4657
> URL: https://issues.apache.org/jira/browse/TS-4657
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
>Reporter: James Peach
>Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If you use the {{TS_SSL_SNI_HOOK}} hook, it will send {{TS_SSL_SNI_HOOK}}
> values as the event. {{TS_SSL_SNI_HOOK}} is not a valid {{TSEvent}} value.
> It is also weird that {{TS_SSL_SNI_HOOK}} and {{TS_SSL_CERT_HOOK}} have the
> same value. One of these ought to be redundant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4657) SNI hook sends hook ID for events
[
https://issues.apache.org/jira/browse/TS-4657?focusedWorklogId=28262=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28262
]
ASF GitHub Bot logged work on TS-4657:
--
Author: ASF GitHub Bot
Created on: 07/Sep/16 03:43
Start Date: 07/Sep/16 03:43
Worklog Time Spent: 10m
Work Description: Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/977
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/719/ for details.
Issue Time Tracking
---
Worklog Id: (was: 28262)
Time Spent: 20m (was: 10m)
> SNI hook sends hook ID for events
> -
>
> Key: TS-4657
> URL: https://issues.apache.org/jira/browse/TS-4657
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
>Reporter: James Peach
>Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> If you use the {{TS_SSL_SNI_HOOK}} hook, it will send {{TS_SSL_SNI_HOOK}}
> values as the event. {{TS_SSL_SNI_HOOK}} is not a valid {{TSEvent}} value.
> It is also weird that {{TS_SSL_SNI_HOOK}} and {{TS_SSL_CERT_HOOK}} have the
> same value. One of these ought to be redundant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4657) SNI hook sends hook ID for events
[
https://issues.apache.org/jira/browse/TS-4657?focusedWorklogId=28261=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28261
]
ASF GitHub Bot logged work on TS-4657:
--
Author: ASF GitHub Bot
Created on: 07/Sep/16 03:38
Start Date: 07/Sep/16 03:38
Worklog Time Spent: 10m
Work Description: GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/977
TS-4657: SNI hook sends hook ID for events
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-4657
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/977.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #977
Issue Time Tracking
---
Worklog Id: (was: 28261)
Time Spent: 10m
Remaining Estimate: 0h
> SNI hook sends hook ID for events
> -
>
> Key: TS-4657
> URL: https://issues.apache.org/jira/browse/TS-4657
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
>Reporter: James Peach
>Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If you use the {{TS_SSL_SNI_HOOK}} hook, it will send {{TS_SSL_SNI_HOOK}}
> values as the event. {{TS_SSL_SNI_HOOK}} is not a valid {{TSEvent}} value.
> It is also weird that {{TS_SSL_SNI_HOOK}} and {{TS_SSL_CERT_HOOK}} have the
> same value. One of these ought to be redundant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
