[jira] [Work logged] (TS-4667) The gzip plugin uses non-WKS strings where it should

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4667?focusedWorklogId=25782=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25782
 ]

ASF GitHub Bot logged work on TS-4667:
--

Author: ASF GitHub Bot
Created on: 20/Jul/16 23:49
Start Date: 20/Jul/16 23:49
Worklog Time Spent: 10m 
  Work Description: Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/817


Issue Time Tracking
---

Worklog Id: (was: 25782)
Time Spent: 1h  (was: 50m)

> The gzip plugin uses non-WKS strings where it should
> 
>
> Key: TS-4667
> URL: https://issues.apache.org/jira/browse/TS-4667
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> In all its handling of MIME header fields, it uses its own strings, instead 
> of our WKS strings that are available via plugin APIs. Albeit benign, this 
> sets a bad precedence, and we should do it right :).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4667) The gzip plugin uses non-WKS strings where it should

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4667?focusedWorklogId=25781=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25781
 ]

ASF GitHub Bot logged work on TS-4667:
--

Author: ASF GitHub Bot
Created on: 20/Jul/16 23:14
Start Date: 20/Jul/16 23:14
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/817
  
 


Issue Time Tracking
---

Worklog Id: (was: 25781)
Time Spent: 50m  (was: 40m)

> The gzip plugin uses non-WKS strings where it should
> 
>
> Key: TS-4667
> URL: https://issues.apache.org/jira/browse/TS-4667
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> In all its handling of MIME header fields, it uses its own strings, instead 
> of our WKS strings that are available via plugin APIs. Albeit benign, this 
> sets a bad precedence, and we should do it right :).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4667) The gzip plugin uses non-WKS strings where it should

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4667?focusedWorklogId=25770=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25770
 ]

ASF GitHub Bot logged work on TS-4667:
--

Author: ASF GitHub Bot
Created on: 20/Jul/16 20:17
Start Date: 20/Jul/16 20:17
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/817
  
@oschaaf  please review.


Issue Time Tracking
---

Worklog Id: (was: 25770)
Time Spent: 40m  (was: 0.5h)

> The gzip plugin uses non-WKS strings where it should
> 
>
> Key: TS-4667
> URL: https://issues.apache.org/jira/browse/TS-4667
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> In all its handling of MIME header fields, it uses its own strings, instead 
> of our WKS strings that are available via plugin APIs. Albeit benign, this 
> sets a bad precedence, and we should do it right :).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4667) The gzip plugin uses non-WKS strings where it should

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4667?focusedWorklogId=25763=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25763
 ]

ASF GitHub Bot logged work on TS-4667:
--

Author: ASF GitHub Bot
Created on: 20/Jul/16 16:09
Start Date: 20/Jul/16 16:09
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/817
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/355/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 25763)
Time Spent: 0.5h  (was: 20m)

> The gzip plugin uses non-WKS strings where it should
> 
>
> Key: TS-4667
> URL: https://issues.apache.org/jira/browse/TS-4667
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In all its handling of MIME header fields, it uses its own strings, instead 
> of our WKS strings that are available via plugin APIs. Albeit benign, this 
> sets a bad precedence, and we should do it right :).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4667) The gzip plugin uses non-WKS strings where it should

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4667?focusedWorklogId=25762=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25762
 ]

ASF GitHub Bot logged work on TS-4667:
--

Author: ASF GitHub Bot
Created on: 20/Jul/16 16:03
Start Date: 20/Jul/16 16:03
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/817
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/459/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 25762)
Time Spent: 20m  (was: 10m)

> The gzip plugin uses non-WKS strings where it should
> 
>
> Key: TS-4667
> URL: https://issues.apache.org/jira/browse/TS-4667
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In all its handling of MIME header fields, it uses its own strings, instead 
> of our WKS strings that are available via plugin APIs. Albeit benign, this 
> sets a bad precedence, and we should do it right :).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4667) The gzip plugin uses non-WKS strings where it should

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4667?focusedWorklogId=25761=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25761
 ]

ASF GitHub Bot logged work on TS-4667:
--

Author: ASF GitHub Bot
Created on: 20/Jul/16 15:54
Start Date: 20/Jul/16 15:54
Worklog Time Spent: 10m 
  Work Description: GitHub user zwoop opened a pull request:

https://github.com/apache/trafficserver/pull/817

TS-4667 Uses the WKS in the gzip plugin

Instead of just using strings, like "deflate". Albeit, it's functionally 
the same, this is a bad pattern that we should discourage (using the WKS's 
consistently is better performance, and better to read).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zwoop/trafficserver TS-4667

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/817.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #817


commit 82a7db79306949a85cc7fe9f7bde48b849e2860a
Author: Leif Hedstrom 
Date:   2016-07-20T15:37:37Z

TS-4667 Uses the WKS in the gzip plugin




Issue Time Tracking
---

Worklog Id: (was: 25761)
Time Spent: 10m
Remaining Estimate: 0h

> The gzip plugin uses non-WKS strings where it should
> 
>
> Key: TS-4667
> URL: https://issues.apache.org/jira/browse/TS-4667
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In all its handling of MIME header fields, it uses its own strings, instead 
> of our WKS strings that are available via plugin APIs. Albeit benign, this 
> sets a bad precedence, and we should do it right :).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)