[jira] [Work logged] (TS-4929) Should we avoid loading HostDB disk file is sync_frequency is '0' (disabled)
[ https://issues.apache.org/jira/browse/TS-4929?focusedWorklogId=30230&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30230 ] ASF GitHub Bot logged work on TS-4929: -- Author: ASF GitHub Bot Created on: 06/Oct/16 16:17 Start Date: 06/Oct/16 16:17 Worklog Time Spent: 10m Work Description: Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1076 Issue Time Tracking --- Worklog Id: (was: 30230) Time Spent: 1h 10m (was: 1h) > Should we avoid loading HostDB disk file is sync_frequency is '0' (disabled) > > > Key: TS-4929 > URL: https://issues.apache.org/jira/browse/TS-4929 > Project: Traffic Server > Issue Type: Improvement > Components: HostDB >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.1.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > This addresses two issues: > 1) We get warnings trying to load a non-existent HostDB (since we don't sync > it). > 2) Worse, if someone has an old HostDB, that is no longer synced / updated, > we load the old, possibly stale, data on every startup. > #2 seems inconsistent with the other changes to HostDB, where now the sync > frequency =0 truly turns off disk syncing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4929) Should we avoid loading HostDB disk file is sync_frequency is '0' (disabled)
[ https://issues.apache.org/jira/browse/TS-4929?focusedWorklogId=30183&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30183 ] ASF GitHub Bot logged work on TS-4929: -- Author: ASF GitHub Bot Created on: 05/Oct/16 15:53 Start Date: 05/Oct/16 15:53 Worklog Time Spent: 10m Work Description: Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1076 OK that sounds reasonable. Issue Time Tracking --- Worklog Id: (was: 30183) Time Spent: 1h (was: 50m) > Should we avoid loading HostDB disk file is sync_frequency is '0' (disabled) > > > Key: TS-4929 > URL: https://issues.apache.org/jira/browse/TS-4929 > Project: Traffic Server > Issue Type: Improvement > Components: HostDB >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.1.0 > > Time Spent: 1h > Remaining Estimate: 0h > > This addresses two issues: > 1) We get warnings trying to load a non-existent HostDB (since we don't sync > it). > 2) Worse, if someone has an old HostDB, that is no longer synced / updated, > we load the old, possibly stale, data on every startup. > #2 seems inconsistent with the other changes to HostDB, where now the sync > frequency =0 truly turns off disk syncing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4929) Should we avoid loading HostDB disk file is sync_frequency is '0' (disabled)
[ https://issues.apache.org/jira/browse/TS-4929?focusedWorklogId=30182&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30182 ] ASF GitHub Bot logged work on TS-4929: -- Author: ASF GitHub Bot Created on: 05/Oct/16 15:49 Start Date: 05/Oct/16 15:49 Worklog Time Spent: 10m Work Description: Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1076 Yes, they would have TTLs, but if I turned off syncing, I certainly wouldn't expect it to load something old. What if I had bad entries? What if I had a corruption of some sort? Since it will never update it, you are stuck with loading old (possibly stale or more likely expired) entries for the remaining of life? That just makes no sense. Issue Time Tracking --- Worklog Id: (was: 30182) Time Spent: 50m (was: 40m) > Should we avoid loading HostDB disk file is sync_frequency is '0' (disabled) > > > Key: TS-4929 > URL: https://issues.apache.org/jira/browse/TS-4929 > Project: Traffic Server > Issue Type: Improvement > Components: HostDB >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.1.0 > > Time Spent: 50m > Remaining Estimate: 0h > > This addresses two issues: > 1) We get warnings trying to load a non-existent HostDB (since we don't sync > it). > 2) Worse, if someone has an old HostDB, that is no longer synced / updated, > we load the old, possibly stale, data on every startup. > #2 seems inconsistent with the other changes to HostDB, where now the sync > frequency =0 truly turns off disk syncing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4929) Should we avoid loading HostDB disk file is sync_frequency is '0' (disabled)
[ https://issues.apache.org/jira/browse/TS-4929?focusedWorklogId=30181&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30181 ] ASF GitHub Bot logged work on TS-4929: -- Author: ASF GitHub Bot Created on: 05/Oct/16 15:26 Start Date: 05/Oct/16 15:26 Worklog Time Spent: 10m Work Description: Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1076 @zwoop (1) and (2) sound like they are in conflict? I'm confused about whether it loads or not? If it does load, do you really have a stale record problem, since each record has a TTL? Issue Time Tracking --- Worklog Id: (was: 30181) Time Spent: 40m (was: 0.5h) > Should we avoid loading HostDB disk file is sync_frequency is '0' (disabled) > > > Key: TS-4929 > URL: https://issues.apache.org/jira/browse/TS-4929 > Project: Traffic Server > Issue Type: Improvement > Components: HostDB >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.1.0 > > Time Spent: 40m > Remaining Estimate: 0h > > This addresses two issues: > 1) We get warnings trying to load a non-existent HostDB (since we don't sync > it). > 2) Worse, if someone has an old HostDB, that is no longer synced / updated, > we load the old, possibly stale, data on every startup. > #2 seems inconsistent with the other changes to HostDB, where now the sync > frequency =0 truly turns off disk syncing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4929) Should we avoid loading HostDB disk file is sync_frequency is '0' (disabled)
[ https://issues.apache.org/jira/browse/TS-4929?focusedWorklogId=30115&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30115 ] ASF GitHub Bot logged work on TS-4929: -- Author: ASF GitHub Bot Created on: 04/Oct/16 17:24 Start Date: 04/Oct/16 17:24 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1076 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/822/ for details. Issue Time Tracking --- Worklog Id: (was: 30115) Time Spent: 0.5h (was: 20m) > Should we avoid loading HostDB disk file is sync_frequency is '0' (disabled) > > > Key: TS-4929 > URL: https://issues.apache.org/jira/browse/TS-4929 > Project: Traffic Server > Issue Type: Improvement > Components: HostDB >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.1.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > This addresses two issues: > 1) We get warnings trying to load a non-existent HostDB (since we don't sync > it). > 2) Worse, if someone has an old HostDB, that is no longer synced / updated, > we load the old, possibly stale, data on every startup. > #2 seems inconsistent with the other changes to HostDB, where now the sync > frequency =0 truly turns off disk syncing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4929) Should we avoid loading HostDB disk file is sync_frequency is '0' (disabled)
[ https://issues.apache.org/jira/browse/TS-4929?focusedWorklogId=30114&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30114 ] ASF GitHub Bot logged work on TS-4929: -- Author: ASF GitHub Bot Created on: 04/Oct/16 17:24 Start Date: 04/Oct/16 17:24 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1076 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/928/ for details. Issue Time Tracking --- Worklog Id: (was: 30114) Time Spent: 20m (was: 10m) > Should we avoid loading HostDB disk file is sync_frequency is '0' (disabled) > > > Key: TS-4929 > URL: https://issues.apache.org/jira/browse/TS-4929 > Project: Traffic Server > Issue Type: Improvement > Components: HostDB >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > This addresses two issues: > 1) We get warnings trying to load a non-existent HostDB (since we don't sync > it). > 2) Worse, if someone has an old HostDB, that is no longer synced / updated, > we load the old, possibly stale, data on every startup. > #2 seems inconsistent with the other changes to HostDB, where now the sync > frequency =0 truly turns off disk syncing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4929) Should we avoid loading HostDB disk file is sync_frequency is '0' (disabled)
[ https://issues.apache.org/jira/browse/TS-4929?focusedWorklogId=30113&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30113 ] ASF GitHub Bot logged work on TS-4929: -- Author: ASF GitHub Bot Created on: 04/Oct/16 17:10 Start Date: 04/Oct/16 17:10 Worklog Time Spent: 10m Work Description: GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1076 TS-4929: No loading of HostDB disk file if sync_frequency=0 This has two benefit (2) is most important I think: 1) We avoid warnings on startup about not being able to load the HostDB. 2) Since in 7.0.0, turning off syncing (sync_frequency=0) completely disables writing to HostDB, it's now possible to end up loading a potentially stale HostDB from a previous upgrade. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4929 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1076.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1076 commit b89513b698ea72a09cb700a83ee4102413a708e8 Author: Leif Hedstrom Date: 2016-10-04T16:54:31Z TS-4929: No loading of HostDB disk file if sync_frequency=0 Issue Time Tracking --- Worklog Id: (was: 30113) Time Spent: 10m Remaining Estimate: 0h > Should we avoid loading HostDB disk file is sync_frequency is '0' (disabled) > > > Key: TS-4929 > URL: https://issues.apache.org/jira/browse/TS-4929 > Project: Traffic Server > Issue Type: Improvement > Components: HostDB >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.1.0 > > Time Spent: 10m > Remaining Estimate: 0h > > This addresses two issues: > 1) We get warnings trying to load a non-existent HostDB (since we don't sync > it). > 2) Worse, if someone has an old HostDB, that is no longer synced / updated, > we load the old, possibly stale, data on every startup. > #2 seems inconsistent with the other changes to HostDB, where now the sync > frequency =0 truly turns off disk syncing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
