Re: [I] ☂ cmake: audit tasks [trafficserver]
cmcfarlen commented on issue #10241: URL: https://github.com/apache/trafficserver/issues/10241#issuecomment-1785584227 One way I have found to find the differences is to enable cmake's `CMAKE_EXPORT_COMPILE_COMMANDS` option and then compare that to the filesystem. Cmake will output a compile_commands.json file that lists every file that will be compiled as part of the build. ``` jq -r 'map(.file)[]' compile_commands.json | sort | uniq > compiled.txt ``` ``` find "$(pwd)" -type f -name "*.cc" -or -name "*.cpp" | sort > files.txt ``` Then you can diff these files. For this to work, you have to have a cmake that builds with every available option (autest, quic, experimental plugins, benchmarks, etc). There are known missing items like the plugins listed in #10242 and the tests in swoc in yaml-cpp that we don't build. There are also some files (i.e. the fastcgi plugin) that autotools also does not build. Thanks for helping to audit the cmake build @ywkaras! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] ☂ cmake: audit tasks [trafficserver]
ywkaras commented on issue #10241: URL: https://github.com/apache/trafficserver/issues/10241#issuecomment-1785352426 It looks like there may be over 100 c/cpp/cc file that appear in a Makefile.am or Makefile.inc file, but not in a CMakeLists.txt file. I will work on addressing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] ☂ cmake: audit tasks [trafficserver]
ywkaras commented on issue #10241: URL: https://github.com/apache/trafficserver/issues/10241#issuecomment-1783667798 Some Catch unit tests are missing in the CMake build: wkaras ~/REPOS/TS O$ cat ~/find_catch CML=$( find . -name CMakeLists.txt ) LAST='___NONE___' grep -l -F CATCH_CONFIG_MAIN $( find . -name \*.cc -o -name \*.cpp ) | while read P do F=$( basename $P ) if [[ $F != $LAST ]] ; then COUNT=$( grep -l -F $F $CML | wc -l ) fi if (( COUNT == 0 )) ; then echo "$F missing" else let COUNT=COUNT-1 fi LAST=$F done wkaras ~/REPOS/TS O$ . ~/find_catch authproxy_test.cc missing uri_signing_test.cc missing test_HostFile.cc missing test_MTHashTable.cc missing event_processor_main.cc missing test_NextHopConsistentHash.cc missing test_NextHopRoundRobin.cc missing test_NextHopStrategyFactory.cc missing test_PluginDso.cc missing test_PluginFactory.cc missing test_RemapPlugin.cc missing benchmark_LogObject.cc missing test_RolledLogDeleter.cc missing wkaras ~/REPOS/TS O$ I can't think of a quick way to check if any non-catch unit tests are missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] ☂ cmake: audit tasks [trafficserver]
ywkaras commented on issue #10241: URL: https://github.com/apache/trafficserver/issues/10241#issuecomment-1779795156 -Djemalloc_ROOT=xxx doesn't seem to be working. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] ☂ cmake: audit tasks [trafficserver]
ywkaras commented on issue #10241: URL: https://github.com/apache/trafficserver/issues/10241#issuecomment-1779654129 My development environment is in a x86_64, RHEL8(-ish, Yahoo kernel mods) container in the Yahoo internal cloud. The autotools ./configure detects it as supporting 128 bit CAS. cmake detects in as not supporiting 128 bit CAS. O$ uname -mpi x86_64 x86_64 x86_64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
