[jira] [Commented] (TRAFODION-3142) Correct Syntactic Descriptions of Character String Data Types and Add Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference Manual*
[ https://issues.apache.org/jira/browse/TRAFODION-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550130#comment-16550130 ] ASF GitHub Bot commented on TRAFODION-3142: --- Github user asfgit closed the pull request at: https://github.com/apache/trafodion/pull/1644 > Correct Syntactic Descriptions of Character String Data Types and Add > Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference > Manual* > --- > > Key: TRAFODION-3142 > URL: https://issues.apache.org/jira/browse/TRAFODION-3142 > Project: Apache Trafodion > Issue Type: Documentation >Reporter: Liu Yu >Assignee: Liu Yu >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRAFODION-3142) Correct Syntactic Descriptions of Character String Data Types and Add Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference Manual*
[ https://issues.apache.org/jira/browse/TRAFODION-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548683#comment-16548683 ] ASF GitHub Bot commented on TRAFODION-3142: --- Github user liuyu000 commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r203584509 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -2963,18 +2963,22 @@ column-definition is: <<< ``` data-type is: -char[acter] [(length [characters])] - [character set char-set-name] - [upshift] [[not]casespecific] +char[acter] [(length) [characters]] +[character set char-set-name] +[upshift] [[not]casespecific] | char[acter] varying (length [characters]) - [character set char-set-name] - [upshift] [[not]casespecific] - | varchar (length) [character set char-set-name] +[character set char-set-name] +[upshift] [[not]casespecific] + | varchar (length [characters]) +[character set char-set-name] +[upshift] [[not]casespecific] + | varchar2 (length [characters]) + [character set char-set-name] + [upshift] [[not]casespecific] + | nchar [(length) [characters]] --- End diff -- Thanks, I've corrected :rowboat: > Correct Syntactic Descriptions of Character String Data Types and Add > Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference > Manual* > --- > > Key: TRAFODION-3142 > URL: https://issues.apache.org/jira/browse/TRAFODION-3142 > Project: Apache Trafodion > Issue Type: Documentation >Reporter: Liu Yu >Assignee: Liu Yu >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRAFODION-3142) Correct Syntactic Descriptions of Character String Data Types and Add Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference Manual*
[ https://issues.apache.org/jira/browse/TRAFODION-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548671#comment-16548671 ] ASF GitHub Bot commented on TRAFODION-3142: --- Github user liuyu000 commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r203581595 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -2963,18 +2963,22 @@ column-definition is: <<< ``` data-type is: -char[acter] [(length [characters])] - [character set char-set-name] - [upshift] [[not]casespecific] +char[acter] [(length) [characters]] --- End diff -- Thanks for your eagle eye Sorry it's my careless mistake :pig: I've corrected them all :pencil2: > Correct Syntactic Descriptions of Character String Data Types and Add > Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference > Manual* > --- > > Key: TRAFODION-3142 > URL: https://issues.apache.org/jira/browse/TRAFODION-3142 > Project: Apache Trafodion > Issue Type: Documentation >Reporter: Liu Yu >Assignee: Liu Yu >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRAFODION-3142) Correct Syntactic Descriptions of Character String Data Types and Add Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference Manual*
[ https://issues.apache.org/jira/browse/TRAFODION-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548519#comment-16548519 ] ASF GitHub Bot commented on TRAFODION-3142: --- Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r203554900 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -2963,18 +2963,22 @@ column-definition is: <<< ``` data-type is: -char[acter] [(length [characters])] - [character set char-set-name] - [upshift] [[not]casespecific] +char[acter] [(length) [characters]] +[character set char-set-name] +[upshift] [[not]casespecific] | char[acter] varying (length [characters]) - [character set char-set-name] - [upshift] [[not]casespecific] - | varchar (length) [character set char-set-name] +[character set char-set-name] +[upshift] [[not]casespecific] + | varchar (length [characters]) +[character set char-set-name] +[upshift] [[not]casespecific] + | varchar2 (length [characters]) + [character set char-set-name] + [upshift] [[not]casespecific] + | nchar [(length) [characters]] --- End diff -- Same comment here. > Correct Syntactic Descriptions of Character String Data Types and Add > Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference > Manual* > --- > > Key: TRAFODION-3142 > URL: https://issues.apache.org/jira/browse/TRAFODION-3142 > Project: Apache Trafodion > Issue Type: Documentation >Reporter: Liu Yu >Assignee: Liu Yu >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRAFODION-3142) Correct Syntactic Descriptions of Character String Data Types and Add Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference Manual*
[ https://issues.apache.org/jira/browse/TRAFODION-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548520#comment-16548520 ] ASF GitHub Bot commented on TRAFODION-3142: --- Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r203554845 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -2963,18 +2963,22 @@ column-definition is: <<< ``` data-type is: -char[acter] [(length [characters])] - [character set char-set-name] - [upshift] [[not]casespecific] +char[acter] [(length) [characters]] --- End diff -- Should be "char[acter] [(length [characters])]" (The trailing parenthesis should come after the optional [characters] syntactic element) > Correct Syntactic Descriptions of Character String Data Types and Add > Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference > Manual* > --- > > Key: TRAFODION-3142 > URL: https://issues.apache.org/jira/browse/TRAFODION-3142 > Project: Apache Trafodion > Issue Type: Documentation >Reporter: Liu Yu >Assignee: Liu Yu >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRAFODION-3142) Correct Syntactic Descriptions of Character String Data Types and Add Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference Manual*
[ https://issues.apache.org/jira/browse/TRAFODION-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547296#comment-16547296 ] ASF GitHub Bot commented on TRAFODION-3142: --- Github user liuyu000 commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r203234030 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -2963,18 +2963,22 @@ column-definition is: <<< ``` data-type is: -char[acter] [(length [characters])] - [character set char-set-name] - [upshift] [[not]casespecific] +char[acter] [length [characters]] +[character set char-set-name] +[upshift] [[not]casespecific] | char[acter] varying (length [characters]) - [character set char-set-name] - [upshift] [[not]casespecific] - | varchar (length) [character set char-set-name] +[character set char-set-name] +[upshift] [[not]casespecific] + | varchar (length [characters]) +[character set char-set-name] +[upshift] [[not]casespecific] + | varchar2 (length [characters]) + [character set char-set-name] + [upshift] [[not]casespecific] + | nchar [length [characters]] --- End diff -- Here should be `nchar [(length) [characters]]` > Correct Syntactic Descriptions of Character String Data Types and Add > Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference > Manual* > --- > > Key: TRAFODION-3142 > URL: https://issues.apache.org/jira/browse/TRAFODION-3142 > Project: Apache Trafodion > Issue Type: Documentation >Reporter: Liu Yu >Assignee: Liu Yu >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRAFODION-3142) Correct Syntactic Descriptions of Character String Data Types and Add Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference Manual*
[ https://issues.apache.org/jira/browse/TRAFODION-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547295#comment-16547295 ] ASF GitHub Bot commented on TRAFODION-3142: --- Github user liuyu000 commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r203233947 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -2963,18 +2963,22 @@ column-definition is: <<< ``` data-type is: -char[acter] [(length [characters])] - [character set char-set-name] - [upshift] [[not]casespecific] +char[acter] [length [characters]] --- End diff -- Yes, the origin text is right, I've corrected my writing > Correct Syntactic Descriptions of Character String Data Types and Add > Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference > Manual* > --- > > Key: TRAFODION-3142 > URL: https://issues.apache.org/jira/browse/TRAFODION-3142 > Project: Apache Trafodion > Issue Type: Documentation >Reporter: Liu Yu >Assignee: Liu Yu >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRAFODION-3142) Correct Syntactic Descriptions of Character String Data Types and Add Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference Manual*
[ https://issues.apache.org/jira/browse/TRAFODION-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546865#comment-16546865 ] ASF GitHub Bot commented on TRAFODION-3142: --- Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r203093950 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -2963,18 +2963,22 @@ column-definition is: <<< ``` data-type is: -char[acter] [(length [characters])] - [character set char-set-name] - [upshift] [[not]casespecific] +char[acter] [length [characters]] --- End diff -- FYI: I double-checked the parser code. Length is optional for CHAR and NCHAR. Length is required for VARCHAR and NCHAR VARYING. > Correct Syntactic Descriptions of Character String Data Types and Add > Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference > Manual* > --- > > Key: TRAFODION-3142 > URL: https://issues.apache.org/jira/browse/TRAFODION-3142 > Project: Apache Trafodion > Issue Type: Documentation >Reporter: Liu Yu >Assignee: Liu Yu >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRAFODION-3142) Correct Syntactic Descriptions of Character String Data Types and Add Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference Manual*
[ https://issues.apache.org/jira/browse/TRAFODION-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546849#comment-16546849 ] ASF GitHub Bot commented on TRAFODION-3142: --- Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r203091243 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -2963,18 +2963,22 @@ column-definition is: <<< ``` data-type is: -char[acter] [(length [characters])] - [character set char-set-name] - [upshift] [[not]casespecific] +char[acter] [length [characters]] --- End diff -- Ah, good catch! I stand corrected. So, the original text, "char[acter] [(length [characters])] was correct? (The parentheses are needed if a length is supplied.) > Correct Syntactic Descriptions of Character String Data Types and Add > Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference > Manual* > --- > > Key: TRAFODION-3142 > URL: https://issues.apache.org/jira/browse/TRAFODION-3142 > Project: Apache Trafodion > Issue Type: Documentation >Reporter: Liu Yu >Assignee: Liu Yu >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRAFODION-3142) Correct Syntactic Descriptions of Character String Data Types and Add Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference Manual*
[ https://issues.apache.org/jira/browse/TRAFODION-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545963#comment-16545963 ] ASF GitHub Bot commented on TRAFODION-3142: --- Github user liuyu000 commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r202880294 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -3712,6 +3716,60 @@ ATTRIBUTES ALIGNED FORMAT --- SQL operation complete. ``` +* This example demonstrates the character set of NCHAR column (_c1_) *cannot be specified*. --- End diff -- Thanks Dave, your comments have been incorporated > Correct Syntactic Descriptions of Character String Data Types and Add > Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference > Manual* > --- > > Key: TRAFODION-3142 > URL: https://issues.apache.org/jira/browse/TRAFODION-3142 > Project: Apache Trafodion > Issue Type: Documentation >Reporter: Liu Yu >Assignee: Liu Yu >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRAFODION-3142) Correct Syntactic Descriptions of Character String Data Types and Add Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference Manual*
[ https://issues.apache.org/jira/browse/TRAFODION-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545928#comment-16545928 ] ASF GitHub Bot commented on TRAFODION-3142: --- Github user liuyu000 commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r202873460 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -2963,18 +2963,22 @@ column-definition is: <<< ``` data-type is: -char[acter] [(length [characters])] - [character set char-set-name] - [upshift] [[not]casespecific] +char[acter] [length [characters]] --- End diff -- Thanks for your review @DaveBirdsall `length [characters]` is optional. If `length` is not specified, the default is 1.  > Correct Syntactic Descriptions of Character String Data Types and Add > Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference > Manual* > --- > > Key: TRAFODION-3142 > URL: https://issues.apache.org/jira/browse/TRAFODION-3142 > Project: Apache Trafodion > Issue Type: Documentation >Reporter: Liu Yu >Assignee: Liu Yu >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRAFODION-3142) Correct Syntactic Descriptions of Character String Data Types and Add Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference Manual*
[ https://issues.apache.org/jira/browse/TRAFODION-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545365#comment-16545365 ] ASF GitHub Bot commented on TRAFODION-3142: --- Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r202731971 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -3712,6 +3716,60 @@ ATTRIBUTES ALIGNED FORMAT --- SQL operation complete. ``` +* This example demonstrates the character set of NCHAR column (_c1_) *cannot be specified*. --- End diff -- I think one example is probably enough. The point we are trying to make is that "NATIONAL CHAR" implies a particular character set, namely, "UCS2". This is hard-coded into the product; it cannot be changed. Possible word-smith: "NATIONAL CHAR (or NCHAR) is a short-hand for CHAR ... CHARACTER SET UCS2. So it is not possible to specify a CHARACTER SET clause when using NCHAR, as the following example shows:" > Correct Syntactic Descriptions of Character String Data Types and Add > Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference > Manual* > --- > > Key: TRAFODION-3142 > URL: https://issues.apache.org/jira/browse/TRAFODION-3142 > Project: Apache Trafodion > Issue Type: Documentation >Reporter: Liu Yu >Assignee: Liu Yu >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRAFODION-3142) Correct Syntactic Descriptions of Character String Data Types and Add Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference Manual*
[ https://issues.apache.org/jira/browse/TRAFODION-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545364#comment-16545364 ] ASF GitHub Bot commented on TRAFODION-3142: --- Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r202728022 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -2963,18 +2963,22 @@ column-definition is: <<< ``` data-type is: -char[acter] [(length [characters])] - [character set char-set-name] - [upshift] [[not]casespecific] +char[acter] [length [characters]] +[character set char-set-name] +[upshift] [[not]casespecific] | char[acter] varying (length [characters]) - [character set char-set-name] - [upshift] [[not]casespecific] - | varchar (length) [character set char-set-name] +[character set char-set-name] +[upshift] [[not]casespecific] + | varchar (length [characters]) +[character set char-set-name] +[upshift] [[not]casespecific] + | varchar2 (length [characters]) + [character set char-set-name] + [upshift] [[not]casespecific] + | nchar [length [characters]] --- End diff -- Should be "nchar (length [characters])" > Correct Syntactic Descriptions of Character String Data Types and Add > Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference > Manual* > --- > > Key: TRAFODION-3142 > URL: https://issues.apache.org/jira/browse/TRAFODION-3142 > Project: Apache Trafodion > Issue Type: Documentation >Reporter: Liu Yu >Assignee: Liu Yu >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRAFODION-3142) Correct Syntactic Descriptions of Character String Data Types and Add Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference Manual*
[ https://issues.apache.org/jira/browse/TRAFODION-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545363#comment-16545363 ] ASF GitHub Bot commented on TRAFODION-3142: --- Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r202727823 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -2963,18 +2963,22 @@ column-definition is: <<< ``` data-type is: -char[acter] [(length [characters])] - [character set char-set-name] - [upshift] [[not]casespecific] +char[acter] [length [characters]] --- End diff -- I think you meant, "char[acter] (length [characters])" (That is, the length is surrounded by parentheses, and it is not optional.) > Correct Syntactic Descriptions of Character String Data Types and Add > Examples (NCHAR) for *CREATE TABLE Statement* in *Trafodion SQL Reference > Manual* > --- > > Key: TRAFODION-3142 > URL: https://issues.apache.org/jira/browse/TRAFODION-3142 > Project: Apache Trafodion > Issue Type: Documentation >Reporter: Liu Yu >Assignee: Liu Yu >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
