[jira] [Commented] (TRAFODION-1724) DatabaseMetaData.getTypeInfo() doesn't work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15087664#comment-15087664
 ] 

ASF GitHub Bot commented on TRAFODION-1724:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/241


> DatabaseMetaData.getTypeInfo() doesn't work
> ---
>
> Key: TRAFODION-1724
> URL: https://issues.apache.org/jira/browse/TRAFODION-1724
> Project: Apache Trafodion
>  Issue Type: Bug
>  Components: client-jdbc-t2
>Reporter: Kevin Xu
>Assignee: Kevin Xu
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TRAFODION-1724) DatabaseMetaData.getTypeInfo() doesn't work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085025#comment-15085025
 ] 

ASF GitHub Bot commented on TRAFODION-1724:
---

Github user selvaganesang commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/241#discussion_r48929989
  
--- Diff: core/conn/jdbc_type2/native/CSrvrStmt.cpp ---
@@ -99,7 +99,7 @@ SRVR_STMT_HDL::SRVR_STMT_HDL(long inDialogueId)
 moduleName[0] = '\0';
 inputDescName[0] = '\0';
 outputDescName[0] = '\0';
-isClosed = TRUE;
+isClosed = FALSE;
--- End diff --

Changing the default value for isClosed from TRUE to FALSE can have other 
repercussions. We might miss throwing error. Can you please confirm this change.


> DatabaseMetaData.getTypeInfo() doesn't work
> ---
>
> Key: TRAFODION-1724
> URL: https://issues.apache.org/jira/browse/TRAFODION-1724
> Project: Apache Trafodion
>  Issue Type: Bug
>  Components: client-jdbc-t2
>Reporter: Kevin Xu
>Assignee: Kevin Xu
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TRAFODION-1724) DatabaseMetaData.getTypeInfo() doesn't work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085073#comment-15085073
 ] 

ASF GitHub Bot commented on TRAFODION-1724:
---

Github user selvaganesang commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/241#discussion_r48931851
  
--- Diff: core/conn/jdbc_type2/native/SrvrCommon.cpp ---
@@ -1991,36 +1972,14 @@ short do_ExecFetchAppend(
 longtotalLength=0;
 
 // Setup module filenames for MX metadata
-if (strncmp(stmtLabel, "SQL_GETTYPEINFO",15) == 0) {
-pSrvrStmt = createSrvrStmt(dialogueId,
-stmtLabel,
-,
-"NONSTOP_SQLMX_NSK.MXCS_SCHEMA.CATANSIMXGTI",
-SQLCLI_ODBC_MODULE_VERSION,
-1234567890,
-sqlStmtType,
-false,true);
-}
-else if (strncmp(stmtLabel, "SQL_JAVA_",9) == 0) {
-pSrvrStmt = createSrvrStmt(dialogueId,
-stmtLabel,
-,
-"NONSTOP_SQLMX_NSK.MXCS_SCHEMA.CATANSIMXJAVA",
-SQLCLI_ODBC_MODULE_VERSION,
-1234567890,
-sqlStmtType,
-false,true);
-}
-else {
-pSrvrStmt = createSrvrStmt(dialogueId,
-stmtLabel,
-,
-"NONSTOP_SQLMX_NSK.MXCS_SCHEMA.CATANSIMX",
-SQLCLI_ODBC_MODULE_VERSION,
-1234567890,
-sqlStmtType,
-false,true);
-}
+pSrvrStmt = createSrvrStmt(dialogueId,
+stmtLabel,
+,
+"NONSTOP_SQLMX_NSK.MXCS_SCHEMA.CATANSIMX",
--- End diff --

This is the module name parameter. Can this point to NULL instead.


> DatabaseMetaData.getTypeInfo() doesn't work
> ---
>
> Key: TRAFODION-1724
> URL: https://issues.apache.org/jira/browse/TRAFODION-1724
> Project: Apache Trafodion
>  Issue Type: Bug
>  Components: client-jdbc-t2
>Reporter: Kevin Xu
>Assignee: Kevin Xu
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TRAFODION-1724) DatabaseMetaData.getTypeInfo() doesn't work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083977#comment-15083977
 ] 

ASF GitHub Bot commented on TRAFODION-1724:
---

Github user hegdean commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/241#discussion_r48906759
  
--- Diff: core/conn/jdbc_type2/native/SrvrCommon.cpp ---
@@ -1991,36 +1972,14 @@ short do_ExecFetchAppend(
 longtotalLength=0;
 
 // Setup module filenames for MX metadata
-if (strncmp(stmtLabel, "SQL_GETTYPEINFO",15) == 0) {
-pSrvrStmt = createSrvrStmt(dialogueId,
-stmtLabel,
-,
-"NONSTOP_SQLMX_NSK.MXCS_SCHEMA.CATANSIMXGTI",
-SQLCLI_ODBC_MODULE_VERSION,
-1234567890,
-sqlStmtType,
-false,true);
-}
-else if (strncmp(stmtLabel, "SQL_JAVA_",9) == 0) {
-pSrvrStmt = createSrvrStmt(dialogueId,
-stmtLabel,
-,
-"NONSTOP_SQLMX_NSK.MXCS_SCHEMA.CATANSIMXJAVA",
-SQLCLI_ODBC_MODULE_VERSION,
-1234567890,
-sqlStmtType,
-false,true);
-}
-else {
-pSrvrStmt = createSrvrStmt(dialogueId,
-stmtLabel,
-,
-"NONSTOP_SQLMX_NSK.MXCS_SCHEMA.CATANSIMX",
-SQLCLI_ODBC_MODULE_VERSION,
-1234567890,
-sqlStmtType,
-false,true);
-}
+pSrvrStmt = createSrvrStmt(dialogueId,
+stmtLabel,
+,
+"NONSTOP_SQLMX_NSK.MXCS_SCHEMA.CATANSIMX",
--- End diff --

Do we still need  the MXCS_SCHEMA reference?


> DatabaseMetaData.getTypeInfo() doesn't work
> ---
>
> Key: TRAFODION-1724
> URL: https://issues.apache.org/jira/browse/TRAFODION-1724
> Project: Apache Trafodion
>  Issue Type: Bug
>  Components: client-jdbc-t2
>Reporter: Kevin Xu
>Assignee: Kevin Xu
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TRAFODION-1724) DatabaseMetaData.getTypeInfo() doesn't work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071479#comment-15071479
 ] 

ASF GitHub Bot commented on TRAFODION-1724:
---

GitHub user kevinxu021 opened a pull request:

https://github.com/apache/incubator-trafodion/pull/241

[TRAFODION-1724]Fixes for getTypeInfo()



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kevinxu021/incubator-trafodion 
a_t2_gettypeinfo

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/241.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #241


commit b01724359e77d7f8b9f03d42d296e9ba58e40b7f
Author: Kevin Xu 
Date:   2015-12-25T09:58:57Z

Fixes for getTypeInfo()




> DatabaseMetaData.getTypeInfo() doesn't work
> ---
>
> Key: TRAFODION-1724
> URL: https://issues.apache.org/jira/browse/TRAFODION-1724
> Project: Apache Trafodion
>  Issue Type: Bug
>  Components: client-jdbc-t2
>Reporter: Kevin Xu
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)