[jira] [Commented] (TRAFODION-1868) Compatibility with gcc 4.8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963014#comment-15963014
 ] 

ASF GitHub Bot commented on TRAFODION-1868:
---

Github user arvind-narain closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/666


> Compatibility with gcc 4.8
> --
>
> Key: TRAFODION-1868
> URL: https://issues.apache.org/jira/browse/TRAFODION-1868
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Steve Varnau
>Assignee: Arvind Narain
>Priority: Minor
>
> Current code will not compile with gcc 4.8. That is the default version on 
> RH/CentOS 7.  This is needed to move to a development environment on CentOS 7.
> There is a 4.4 version of gcc available on 7. The RPM package is 
> compat-gcc-44, I have not tried building on 7.x with older compiler, but will 
> likely work.
> This is not urgent at this time, but we should move toward enabling a newer 
> dev environment.  But this needs to be coordinated with with versions of OS 
> are supported for runtime use of trafodion.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TRAFODION-1868) Compatibility with gcc 4.8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516562#comment-15516562
 ] 

ASF GitHub Bot commented on TRAFODION-1868:
---

Github user selvaganesang commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/666#discussion_r80251796
  
--- Diff: core/sql/runtimestats/SqlStats.cpp ---
@@ -1660,11 +1660,12 @@ StatsGlobals * shareStatsSegment(Int32 , 
NABoolean checkForSSMP)
   {
  return NULL;
   }
-  if ((statsGlobalsAddr = shmat(shmid, getRmsSharedMemoryAddr(), 0))
+  if ((statsGlobalsAddr = shmat(shmid, getRmsSharedMemoryAddr(), SHM_REMAP 
| SHM_RND))
--- End diff --

Similar comments as in bin/ex_sscp_main.cpp


> Compatibility with gcc 4.8
> --
>
> Key: TRAFODION-1868
> URL: https://issues.apache.org/jira/browse/TRAFODION-1868
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Steve Varnau
>Assignee: Arvind Narain
>Priority: Minor
>
> Current code will not compile with gcc 4.8. That is the default version on 
> RH/CentOS 7.  This is needed to move to a development environment on CentOS 7.
> There is a 4.4 version of gcc available on 7. The RPM package is 
> compat-gcc-44, I have not tried building on 7.x with older compiler, but will 
> likely work.
> This is not urgent at this time, but we should move toward enabling a newer 
> dev environment.  But this needs to be coordinated with with versions of OS 
> are supported for runtime use of trafodion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TRAFODION-1868) Compatibility with gcc 4.8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429131#comment-15429131
 ] 

ASF GitHub Bot commented on TRAFODION-1868:
---

GitHub user arvind-narain opened a pull request:

https://github.com/apache/incubator-trafodion/pull/666

[TRAFODION-1868] Compatibility with gcc 4.8

Thanks to @narendragoyal , @svarnau, @traflm for the changes.

Pending work - 
1) check on QT toolkit - it's available as default on Centos 7
2) Still need to resolve some issue seen with install_local_hadoop during 
development testing - it may be specific to the development environment used.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/arvind-narain/incubator-trafodion comp72

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/666.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #666


commit a6bc50a0dcb8397394faf9d84b8a0d2e6ea252a0
Author: Arvind Narain 
Date:   2016-08-20T00:40:35Z

[TRAFODION-1868] Compatibility with gcc 4.8

Set of changes needed to compile with gcc 4.8.
Thanks to Narendra and Ming for the changes.

commit aa0b3a26cd91078e3c6e43cce7b641081ff45035
Author: Arvind Narain 
Date:   2016-08-20T00:53:23Z

Merge branch 'master' of https://github.com/apache/incubator-trafodion into 
comp72

Conflicts:
core/sqf/conf/install_features




> Compatibility with gcc 4.8
> --
>
> Key: TRAFODION-1868
> URL: https://issues.apache.org/jira/browse/TRAFODION-1868
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Steve Varnau
>Assignee: Arvind Narain
>Priority: Minor
>
> Current code will not compile with gcc 4.8. That is the default version on 
> RH/CentOS 7.  This is needed to move to a development environment on CentOS 7.
> There is a 4.4 version of gcc available on 7. The RPM package is 
> compat-gcc-44, I have not tried building on 7.x with older compiler, but will 
> likely work.
> This is not urgent at this time, but we should move toward enabling a newer 
> dev environment.  But this needs to be coordinated with with versions of OS 
> are supported for runtime use of trafodion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TRAFODION-1868) Compatibility with gcc 4.8

[liu ming (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390960#comment-15390960
 ] 

liu ming commented on TRAFODION-1868:
-

yes, SQL errors was not checked in yet. I will start to work on this again 
asap. We already have all fixes, but not merge into main branch yet.

> Compatibility with gcc 4.8
> --
>
> Key: TRAFODION-1868
> URL: https://issues.apache.org/jira/browse/TRAFODION-1868
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Steve Varnau
>Assignee: liu ming
>Priority: Minor
>
> Current code will not compile with gcc 4.8. That is the default version on 
> RH/CentOS 7.  This is needed to move to a development environment on CentOS 7.
> There is a 4.4 version of gcc available on 7. The RPM package is 
> compat-gcc-44, I have not tried building on 7.x with older compiler, but will 
> likely work.
> This is not urgent at this time, but we should move toward enabling a newer 
> dev environment.  But this needs to be coordinated with with versions of OS 
> are supported for runtime use of trafodion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TRAFODION-1868) Compatibility with gcc 4.8

[Steve Varnau (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390255#comment-15390255
 ] 

Steve Varnau commented on TRAFODION-1868:
-

Looks like work may have stalled on this effort. I just tried compiling on 
CentOS 7, and got about 40 errors in the SQL area, in these files:

../comexe/CmpMessage.cpp
../comexe/ComKeyMDAM.cpp
../comexe/ComKeyMDAM.h
../common/Collections.h
../common/SharedPtr.h
../exp/exp_expr.h
../exp/ExpLOBinterface.h
../exp/ExpPCode.h
../export/NAVersionedObject.h
../optimizer/ColStatDesc.h


> Compatibility with gcc 4.8
> --
>
> Key: TRAFODION-1868
> URL: https://issues.apache.org/jira/browse/TRAFODION-1868
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Steve Varnau
>Assignee: liu ming
>Priority: Minor
>
> Current code will not compile with gcc 4.8. That is the default version on 
> RH/CentOS 7.  This is needed to move to a development environment on CentOS 7.
> There is a 4.4 version of gcc available on 7. The RPM package is 
> compat-gcc-44, I have not tried building on 7.x with older compiler, but will 
> likely work.
> This is not urgent at this time, but we should move toward enabling a newer 
> dev environment.  But this needs to be coordinated with with versions of OS 
> are supported for runtime use of trafodion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TRAFODION-1868) Compatibility with gcc 4.8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204571#comment-15204571
 ] 

ASF GitHub Bot commented on TRAFODION-1868:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/394


> Compatibility with gcc 4.8
> --
>
> Key: TRAFODION-1868
> URL: https://issues.apache.org/jira/browse/TRAFODION-1868
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Steve Varnau
>Assignee: liu ming
>Priority: Minor
>
> Current code will not compile with gcc 4.8. That is the default version on 
> RH/CentOS 7.  This is needed to move to a development environment on CentOS 7.
> There is a 4.4 version of gcc available on 7. The RPM package is 
> compat-gcc-44, I have not tried building on 7.x with older compiler, but will 
> likely work.
> This is not urgent at this time, but we should move toward enabling a newer 
> dev environment.  But this needs to be coordinated with with versions of OS 
> are supported for runtime use of trafodion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TRAFODION-1868) Compatibility with gcc 4.8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201679#comment-15201679
 ] 

ASF GitHub Bot commented on TRAFODION-1868:
---

Github user traflm commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/394#discussion_r56677885
  
--- Diff: core/conn/odbc/src/odbc/nsksrvr/Makefile ---
@@ -130,6 +130,8 @@ LOC_JSIG=$(JAVA_HOME)/jre/lib/i386/server
 endif
 
 
+#gcc 4.8 need explicit enable this flag, otherwise ld must explicitly link 
with all so using '-l'
--- End diff --

This is NOT a change of gcc4.8, but the CentOS 7. CentOS 7 build gcc with 
'--no-copy-dt-needed-entries' OFF by default. Turn it on is a simple but not 
good change. I will come back later when all .cpp/.h changes are merged.


> Compatibility with gcc 4.8
> --
>
> Key: TRAFODION-1868
> URL: https://issues.apache.org/jira/browse/TRAFODION-1868
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Steve Varnau
>Assignee: liu ming
>Priority: Minor
>
> Current code will not compile with gcc 4.8. That is the default version on 
> RH/CentOS 7.  This is needed to move to a development environment on CentOS 7.
> There is a 4.4 version of gcc available on 7. The RPM package is 
> compat-gcc-44, I have not tried building on 7.x with older compiler, but will 
> likely work.
> This is not urgent at this time, but we should move toward enabling a newer 
> dev environment.  But this needs to be coordinated with with versions of OS 
> are supported for runtime use of trafodion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TRAFODION-1868) Compatibility with gcc 4.8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201677#comment-15201677
 ] 

ASF GitHub Bot commented on TRAFODION-1868:
---

GitHub user traflm opened a pull request:

https://github.com/apache/incubator-trafodion/pull/394

[TRAFODION-1868] Compatibility with gcc 4.8 , part 3, mornitor, odbc …

this is part 3 of gcc 4.8 changes.
some changes are very strange, for example:
core/sqf/monitor/linux/monitor.cxx
it will call glibc function getrlimit(), which defined in 
in gcc 4.4, this code can be compiled, which I don't know why. This is not 
taught in school.
So should add it.
After I understand why gcc 4.8 disable '--no-copy-dt-needed-entries'
https://wiki.ubuntu.com/NattyNarwhal/ToolchainTransition
I realize this is just a temp solution for gcc 4.8 build. In the following 
changes, I will disable it again and fix Makefile link options.
But first let's fix these .cpp and .h issues. Then on Makefile.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/traflm/incubator-trafodion TRAFODION-1854

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/394.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #394


commit 45a21c6a4621b46c7d3437e9ae452102a0b88d3b
Author: Liu Ming 
Date:   2016-03-18T15:35:23Z

[TRAFODION-1868] Compatibility with gcc 4.8 , part 3, mornitor, odbc changes




> Compatibility with gcc 4.8
> --
>
> Key: TRAFODION-1868
> URL: https://issues.apache.org/jira/browse/TRAFODION-1868
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Steve Varnau
>Assignee: liu ming
>Priority: Minor
>
> Current code will not compile with gcc 4.8. That is the default version on 
> RH/CentOS 7.  This is needed to move to a development environment on CentOS 7.
> There is a 4.4 version of gcc available on 7. The RPM package is 
> compat-gcc-44, I have not tried building on 7.x with older compiler, but will 
> likely work.
> This is not urgent at this time, but we should move toward enabling a newer 
> dev environment.  But this needs to be coordinated with with versions of OS 
> are supported for runtime use of trafodion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TRAFODION-1868) Compatibility with gcc 4.8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195592#comment-15195592
 ] 

ASF GitHub Bot commented on TRAFODION-1868:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/383


> Compatibility with gcc 4.8
> --
>
> Key: TRAFODION-1868
> URL: https://issues.apache.org/jira/browse/TRAFODION-1868
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Steve Varnau
>Assignee: liu ming
>Priority: Minor
>
> Current code will not compile with gcc 4.8. That is the default version on 
> RH/CentOS 7.  This is needed to move to a development environment on CentOS 7.
> There is a 4.4 version of gcc available on 7. The RPM package is 
> compat-gcc-44, I have not tried building on 7.x with older compiler, but will 
> likely work.
> This is not urgent at this time, but we should move toward enabling a newer 
> dev environment.  But this needs to be coordinated with with versions of OS 
> are supported for runtime use of trafodion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TRAFODION-1868) Compatibility with gcc 4.8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192168#comment-15192168
 ] 

ASF GitHub Bot commented on TRAFODION-1868:
---

GitHub user traflm opened a pull request:

https://github.com/apache/incubator-trafodion/pull/383

[TRAFODION-1868] Compatibility with gcc 4.8 , part 2, DTM changes

This is the second part of gcc 4.8 compatibility changes.
Related files are from DTM component.
Major fixed issues:
 - unused var
 - old C++ array init method
 - link options compatible for gcc 4.8

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/traflm/incubator-trafodion TRAFODION-1858

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/383.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #383


commit 63e567a227c3c7aa1a9fd756df7cbf2c0b23ba0c
Author: Liu Ming 
Date:   2016-03-13T06:21:20Z

[TRAFODION-1868] Compatibility with gcc 4.8 , part 2, DTM changes




> Compatibility with gcc 4.8
> --
>
> Key: TRAFODION-1868
> URL: https://issues.apache.org/jira/browse/TRAFODION-1868
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Steve Varnau
>Assignee: liu ming
>Priority: Minor
>
> Current code will not compile with gcc 4.8. That is the default version on 
> RH/CentOS 7.  This is needed to move to a development environment on CentOS 7.
> There is a 4.4 version of gcc available on 7. The RPM package is 
> compat-gcc-44, I have not tried building on 7.x with older compiler, but will 
> likely work.
> This is not urgent at this time, but we should move toward enabling a newer 
> dev environment.  But this needs to be coordinated with with versions of OS 
> are supported for runtime use of trafodion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TRAFODION-1868) Compatibility with gcc 4.8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191329#comment-15191329
 ] 

ASF GitHub Bot commented on TRAFODION-1868:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/374


> Compatibility with gcc 4.8
> --
>
> Key: TRAFODION-1868
> URL: https://issues.apache.org/jira/browse/TRAFODION-1868
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Steve Varnau
>Assignee: liu ming
>Priority: Minor
>
> Current code will not compile with gcc 4.8. That is the default version on 
> RH/CentOS 7.  This is needed to move to a development environment on CentOS 7.
> There is a 4.4 version of gcc available on 7. The RPM package is 
> compat-gcc-44, I have not tried building on 7.x with older compiler, but will 
> likely work.
> This is not urgent at this time, but we should move toward enabling a newer 
> dev environment.  But this needs to be coordinated with with versions of OS 
> are supported for runtime use of trafodion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TRAFODION-1868) Compatibility with gcc 4.8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188539#comment-15188539
 ] 

ASF GitHub Bot commented on TRAFODION-1868:
---

GitHub user traflm opened a pull request:

https://github.com/apache/incubator-trafodion/pull/374

[TRAFODION-1868] Compatibility with gcc 4.8

this is partial changes to Trafodion code base in order to make it 
compatible with gcc 4.8.
Gcc 4.8 generally is more strict than gcc 4.4, so Trafodion code need to 
fix all potential issues.
1. variable declared and initialized, but not used anymore
2. suspicious overload of same variable names
3. ld need the required library name to be explicitly added using '-l' 
option
4. some STL/Boost functions replaced with c++11 features in gcc 4.8, so 
remove unnecessary call into boost
So there are a lot of changes, to make this process easier, we decided to 
do this incrementally. Fix small amount of issues each time, easier to code 
review and test.
It must make sure same code compile and work well under gcc 4.4.

This is the first commit for the whole gcc 4.8 support changes.
We already have a successful gcc 4.8 build prototype, and it works well on 
CentOS 7. But there are still more changes, so this is a rather proven way to 
support gcc 4.8.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/traflm/incubator-trafodion TRAFODION-1854

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #374


commit 1ec16451e37fa21e3978a88def5188a6ff22900c
Author: Liu Ming 
Date:   2016-03-10T02:26:07Z

[TRAFODION-1868] Compatibility with gcc 4.8




> Compatibility with gcc 4.8
> --
>
> Key: TRAFODION-1868
> URL: https://issues.apache.org/jira/browse/TRAFODION-1868
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Steve Varnau
>Assignee: liu ming
>Priority: Minor
>
> Current code will not compile with gcc 4.8. That is the default version on 
> RH/CentOS 7.  This is needed to move to a development environment on CentOS 7.
> There is a 4.4 version of gcc available on 7. The RPM package is 
> compat-gcc-44, I have not tried building on 7.x with older compiler, but will 
> likely work.
> This is not urgent at this time, but we should move toward enabling a newer 
> dev environment.  But this needs to be coordinated with with versions of OS 
> are supported for runtime use of trafodion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TRAFODION-1868) Compatibility with gcc 4.8

[liu ming (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRAFODION-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182385#comment-15182385
 ] 

liu ming commented on TRAFODION-1868:
-

there are multiple issues to build using gcc 4.8.
1. Werror
  gcc 4.8 is more strict than gcc 4.4. There are several programming issues 
that not reported as warning by 4.4
  - declare and init a var , but never use it anymore
  - assign 0 to a pointer var
  - etc.
2. syntax checking
  gcc 4.8 will report error for some code like
  for ( int idx = 0; idx < 100; idx++)
  {
ANewClass idx = new ANewClass();
...
  need to fix these issues. 
3. boost conflict with c++11
4. must use -Xlinker --copy-dt-needed-entries, otherwise linker will not find 
all required so automatically.

These are some issues I met, issues related to item 1 are too many. I temply 
remove -Werror to overcome it. and make a build. But we need to fix all issues 
related to item 1.

There are so many changes to many src code. So I suggest to do this 
increamentally. It is easier to test, and easier for others to do code review.


> Compatibility with gcc 4.8
> --
>
> Key: TRAFODION-1868
> URL: https://issues.apache.org/jira/browse/TRAFODION-1868
> Project: Apache Trafodion
>  Issue Type: Bug
>Reporter: Steve Varnau
>Priority: Minor
>
> Current code will not compile with gcc 4.8. That is the default version on 
> RH/CentOS 7.  This is needed to move to a development environment on CentOS 7.
> There is a 4.4 version of gcc available on 7. The RPM package is 
> compat-gcc-44, I have not tried building on 7.x with older compiler, but will 
> likely work.
> This is not urgent at this time, but we should move toward enabling a newer 
> dev environment.  But this needs to be coordinated with with versions of OS 
> are supported for runtime use of trafodion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)