[jira] [Commented] (TRAFODION-2170) certain create table DDL will fail with core dump
[ https://issues.apache.org/jira/browse/TRAFODION-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670827#comment-15670827 ] ASF GitHub Bot commented on TRAFODION-2170: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafodion/pull/834 > certain create table DDL will fail with core dump > - > > Key: TRAFODION-2170 > URL: https://issues.apache.org/jira/browse/TRAFODION-2170 > Project: Apache Trafodion > Issue Type: Bug >Reporter: liu ming >Assignee: liu ming > > create table test2170 ( > c1 varchar(255) CHARACTER SET UTF8 not null, > c2 varchar(256) CHARACTER SET UTF8 not null, > c3 varchar(256) CHARACTER SET UTF8 not null, > c4 int not null , > c5 int, > primary key(c1,c2,c3,c4)) > salt using 4 partitions ; > This will fail. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TRAFODION-2170) certain create table DDL will fail with core dump
[ https://issues.apache.org/jira/browse/TRAFODION-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15460108#comment-15460108 ] liu ming commented on TRAFODION-2170: - block on TRAFODION-2148 > certain create table DDL will fail with core dump > - > > Key: TRAFODION-2170 > URL: https://issues.apache.org/jira/browse/TRAFODION-2170 > Project: Apache Trafodion > Issue Type: Bug >Reporter: liu ming >Assignee: liu ming > > create table test2170 ( > c1 varchar(255) CHARACTER SET UTF8 not null, > c2 varchar(256) CHARACTER SET UTF8 not null, > c3 varchar(256) CHARACTER SET UTF8 not null, > c4 int not null , > c5 int, > primary key(c1,c2,c3,c4)) > salt using 4 partitions ; > This will fail. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TRAFODION-2170) certain create table DDL will fail with core dump
[
https://issues.apache.org/jira/browse/TRAFODION-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438717#comment-15438717
]
ASF GitHub Bot commented on TRAFODION-2170:
---
Github user traflm commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/672#discussion_r76391813
--- Diff: core/sqf/src/tm/tmddlrequests.cpp ---
@@ -39,13 +40,24 @@ JNIEXPORT void JNICALL
Java_org_apache_hadoop_hbase_client_transactional_RMInter
char la_tbldesc[TM_MAX_DDLREQUEST_STRING];
char la_tblname[TM_MAX_DDLREQUEST_STRING];
char* str_key;
- str_key = new char[TM_MAX_DDLREQUEST_STRING];
+ if(pv_keyLength <= 0)
+ {
+ cout << "createTableReq bad input pv_keyLength, abort" << endl;
+ abort();
+ }
+ str_key = new char[pv_keyLength];
--- End diff --
@prashanth-vasudev , I realize I have to wait for TRAFODION-2148 check in
first to do length checking. Currently, even the length is too long, there is
no way to return error and abort the changes done before.
So I will wait for 2148 to be merged first.
> certain create table DDL will fail with core dump
> -
>
> Key: TRAFODION-2170
> URL: https://issues.apache.org/jira/browse/TRAFODION-2170
> Project: Apache Trafodion
> Issue Type: Bug
>Reporter: liu ming
>Assignee: liu ming
>
> create table test2170 (
> c1 varchar(255) CHARACTER SET UTF8 not null,
> c2 varchar(256) CHARACTER SET UTF8 not null,
> c3 varchar(256) CHARACTER SET UTF8 not null,
> c4 int not null ,
> c5 int,
> primary key(c1,c2,c3,c4))
> salt using 4 partitions ;
> This will fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TRAFODION-2170) certain create table DDL will fail with core dump
[
https://issues.apache.org/jira/browse/TRAFODION-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438665#comment-15438665
]
ASF GitHub Bot commented on TRAFODION-2170:
---
Github user traflm commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/672#discussion_r76384092
--- Diff: core/sqf/src/tm/tmddlrequests.cpp ---
@@ -39,13 +40,24 @@ JNIEXPORT void JNICALL
Java_org_apache_hadoop_hbase_client_transactional_RMInter
char la_tbldesc[TM_MAX_DDLREQUEST_STRING];
char la_tblname[TM_MAX_DDLREQUEST_STRING];
char* str_key;
- str_key = new char[TM_MAX_DDLREQUEST_STRING];
+ if(pv_keyLength <= 0)
+ {
+ cout << "createTableReq bad input pv_keyLength, abort" << endl;
+ abort();
+ }
+ str_key = new char[pv_keyLength];
--- End diff --
thanks Prashanth, yes, I should add this check. Will fix it and submit
again.
> certain create table DDL will fail with core dump
> -
>
> Key: TRAFODION-2170
> URL: https://issues.apache.org/jira/browse/TRAFODION-2170
> Project: Apache Trafodion
> Issue Type: Bug
>Reporter: liu ming
>Assignee: liu ming
>
> create table test2170 (
> c1 varchar(255) CHARACTER SET UTF8 not null,
> c2 varchar(256) CHARACTER SET UTF8 not null,
> c3 varchar(256) CHARACTER SET UTF8 not null,
> c4 int not null ,
> c5 int,
> primary key(c1,c2,c3,c4))
> salt using 4 partitions ;
> This will fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TRAFODION-2170) certain create table DDL will fail with core dump
[ https://issues.apache.org/jira/browse/TRAFODION-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432451#comment-15432451 ] liu ming commented on TRAFODION-2170: - DTM hardcode the key buffer to 2048. Need to either allocate dynamic buffer as required, or return error if the keyLength greater than 2048. > certain create table DDL will fail with core dump > - > > Key: TRAFODION-2170 > URL: https://issues.apache.org/jira/browse/TRAFODION-2170 > Project: Apache Trafodion > Issue Type: Bug >Reporter: liu ming >Assignee: liu ming > > create table test2170 ( > c1 varchar(255) CHARACTER SET UTF8 not null, > c2 varchar(256) CHARACTER SET UTF8 not null, > c3 varchar(256) CHARACTER SET UTF8 not null, > c4 int not null , > c5 int, > primary key(c1,c2,c3,c4)) > salt using 4 partitions ; > This will fail. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
