[jira] [Resolved] (YUNIKORN-770) Remove unnecessary DEBUG log while removing a pod from the cache
[
https://issues.apache.org/jira/browse/YUNIKORN-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weiwei Yang resolved YUNIKORN-770.
--
Fix Version/s: 1.0.0
Resolution: Fixed
> Remove unnecessary DEBUG log while removing a pod from the cache
>
>
> Key: YUNIKORN-770
> URL: https://issues.apache.org/jira/browse/YUNIKORN-770
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: shim - kubernetes
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Minor
> Labels: pull-request-available
> Fix For: 1.0.0
>
>
> {code:go}
> n, ok := cache.nodesMap[pod.Spec.NodeName]
> if !ok {
> return fmt.Errorf("node %v is not found", pod.Spec.NodeName)
> }
> if err := n.RemovePod(pod); err != nil {
> return err
> }
> {code}
> It can causes DEBUG log("node is not found") if node name is an empty
> string. For example: the pod status is updated (according to outstanding
> requests) before it is assumed to be run on a node.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Updated] (YUNIKORN-770) Remove unnecessary DEBUG log while removing a pod from the cache
[
https://issues.apache.org/jira/browse/YUNIKORN-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weiwei Yang updated YUNIKORN-770:
-
Summary: Remove unnecessary DEBUG log while removing a pod from the cache
(was: Avoid unexpected DEBUG log in scheduler_cache.go#removePod)
> Remove unnecessary DEBUG log while removing a pod from the cache
>
>
> Key: YUNIKORN-770
> URL: https://issues.apache.org/jira/browse/YUNIKORN-770
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: shim - kubernetes
>Reporter: Chia-Ping Tsai
>Priority: Minor
> Labels: pull-request-available
>
> {code:go}
> n, ok := cache.nodesMap[pod.Spec.NodeName]
> if !ok {
> return fmt.Errorf("node %v is not found", pod.Spec.NodeName)
> }
> if err := n.RemovePod(pod); err != nil {
> return err
> }
> {code}
> It can causes DEBUG log("node is not found") if node name is an empty
> string. For example: the pod status is updated (according to outstanding
> requests) before it is assumed to be run on a node.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Assigned] (YUNIKORN-770) Remove unnecessary DEBUG log while removing a pod from the cache
[
https://issues.apache.org/jira/browse/YUNIKORN-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weiwei Yang reassigned YUNIKORN-770:
Assignee: Chia-Ping Tsai
> Remove unnecessary DEBUG log while removing a pod from the cache
>
>
> Key: YUNIKORN-770
> URL: https://issues.apache.org/jira/browse/YUNIKORN-770
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: shim - kubernetes
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Minor
> Labels: pull-request-available
>
> {code:go}
> n, ok := cache.nodesMap[pod.Spec.NodeName]
> if !ok {
> return fmt.Errorf("node %v is not found", pod.Spec.NodeName)
> }
> if err := n.RemovePod(pod); err != nil {
> return err
> }
> {code}
> It can causes DEBUG log("node is not found") if node name is an empty
> string. For example: the pod status is updated (according to outstanding
> requests) before it is assumed to be run on a node.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Updated] (YUNIKORN-770) Avoid unexpected DEBUG log in scheduler_cache.go#removePod
[
https://issues.apache.org/jira/browse/YUNIKORN-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated YUNIKORN-770:
Labels: pull-request-available (was: )
> Avoid unexpected DEBUG log in scheduler_cache.go#removePod
> --
>
> Key: YUNIKORN-770
> URL: https://issues.apache.org/jira/browse/YUNIKORN-770
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: shim - kubernetes
>Reporter: Chia-Ping Tsai
>Priority: Minor
> Labels: pull-request-available
>
> {code:go}
> n, ok := cache.nodesMap[pod.Spec.NodeName]
> if !ok {
> return fmt.Errorf("node %v is not found", pod.Spec.NodeName)
> }
> if err := n.RemovePod(pod); err != nil {
> return err
> }
> {code}
> It can causes DEBUG log("node is not found") if node name is an empty
> string. For example: the pod status is updated (according to outstanding
> requests) before it is assumed to be run on a node.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Created] (YUNIKORN-770) Avoid unexpected DEBUG log in scheduler_cache.go#removePod
Chia-Ping Tsai created YUNIKORN-770:
---
Summary: Avoid unexpected DEBUG log in scheduler_cache.go#removePod
Key: YUNIKORN-770
URL: https://issues.apache.org/jira/browse/YUNIKORN-770
Project: Apache YuniKorn
Issue Type: Bug
Components: shim - kubernetes
Reporter: Chia-Ping Tsai
{code:go}
n, ok := cache.nodesMap[pod.Spec.NodeName]
if !ok {
return fmt.Errorf("node %v is not found", pod.Spec.NodeName)
}
if err := n.RemovePod(pod); err != nil {
return err
}
{code}
It can causes DEBUG log("node is not found") if node name is an empty string.
For example: the pod status is updated (according to outstanding requests)
before it is assumed to be run on a node.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Created] (YUNIKORN-769) Licence-check is not working properly on precommit
Kinga Marton created YUNIKORN-769: - Summary: Licence-check is not working properly on precommit Key: YUNIKORN-769 URL: https://issues.apache.org/jira/browse/YUNIKORN-769 Project: Apache YuniKorn Issue Type: Bug Affects Versions: 0.10 Reporter: Kinga Marton Thee license-check is passing on pre-commit even if there are some missing headers. In this case it fails locally as expected. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Updated] (YUNIKORN-583) Codecov report is always failing
[ https://issues.apache.org/jira/browse/YUNIKORN-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wilfred Spiegelenburg updated YUNIKORN-583: --- Labels: (was: newbie) > Codecov report is always failing > > > Key: YUNIKORN-583 > URL: https://issues.apache.org/jira/browse/YUNIKORN-583 > Project: Apache YuniKorn > Issue Type: Bug >Affects Versions: 0.11 >Reporter: Weiwei Yang >Priority: Major > Attachments: [YUNIKORN-631]_PR_comment.png > > > It looks like the codecov report is broken. The target is always bigger than > the result, seems like it is using a wrong base to compare. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Resolved] (YUNIKORN-768) License header missing on test file
[ https://issues.apache.org/jira/browse/YUNIKORN-768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kinga Marton resolved YUNIKORN-768. --- Fix Version/s: 1.0.0 Resolution: Fixed > License header missing on test file > --- > > Key: YUNIKORN-768 > URL: https://issues.apache.org/jira/browse/YUNIKORN-768 > Project: Apache YuniKorn > Issue Type: Bug > Components: shim - kubernetes >Affects Versions: 0.10 >Reporter: Wilfred Spiegelenburg >Assignee: Wilfred Spiegelenburg >Priority: Major > Labels: pull-request-available > Fix For: 1.0.0 > > > In YUNIKORN-427 we forgot to add the apache license header to the file: > test/e2e/predicates/predicates_test.go > We need to add the apache license header. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Resolved] (YUNIKORN-767) Add license to mock_plugin_test.go
[ https://issues.apache.org/jira/browse/YUNIKORN-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kinga Marton resolved YUNIKORN-767. --- Fix Version/s: 1.0.0 Resolution: Fixed > Add license to mock_plugin_test.go > -- > > Key: YUNIKORN-767 > URL: https://issues.apache.org/jira/browse/YUNIKORN-767 > Project: Apache YuniKorn > Issue Type: Bug > Components: core - scheduler >Affects Versions: 0.10 >Reporter: Wilfred Spiegelenburg >Assignee: Wilfred Spiegelenburg >Priority: Major > Labels: pull-request-available > Fix For: 1.0.0 > > > The mock plugin test added in YUNIKORN-505 does not have a license file as it > should have. We need to add it: > scheduler/mock_plugin_test.go -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Updated] (YUNIKORN-768) License header missing on test file
[ https://issues.apache.org/jira/browse/YUNIKORN-768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated YUNIKORN-768: Labels: pull-request-available (was: ) > License header missing on test file > --- > > Key: YUNIKORN-768 > URL: https://issues.apache.org/jira/browse/YUNIKORN-768 > Project: Apache YuniKorn > Issue Type: Bug > Components: shim - kubernetes >Affects Versions: 0.10 >Reporter: Wilfred Spiegelenburg >Assignee: Wilfred Spiegelenburg >Priority: Major > Labels: pull-request-available > > In YUNIKORN-427 we forgot to add the apache license header to the file: > test/e2e/predicates/predicates_test.go > We need to add the apache license header. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Updated] (YUNIKORN-768) License header missing on test file
[ https://issues.apache.org/jira/browse/YUNIKORN-768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wilfred Spiegelenburg updated YUNIKORN-768: --- Link back to the jira that added the file. > License header missing on test file > --- > > Key: YUNIKORN-768 > URL: https://issues.apache.org/jira/browse/YUNIKORN-768 > Project: Apache YuniKorn > Issue Type: Bug > Components: shim - kubernetes >Affects Versions: 0.10 >Reporter: Wilfred Spiegelenburg >Assignee: Wilfred Spiegelenburg >Priority: Major > > In YUNIKORN-427 we forgot to add the apache license header to the file: > test/e2e/predicates/predicates_test.go > We need to add the apache license header. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Updated] (YUNIKORN-767) Add license to mock_plugin_test.go
[ https://issues.apache.org/jira/browse/YUNIKORN-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wilfred Spiegelenburg updated YUNIKORN-767: --- Link back to the jira that added the file. > Add license to mock_plugin_test.go > -- > > Key: YUNIKORN-767 > URL: https://issues.apache.org/jira/browse/YUNIKORN-767 > Project: Apache YuniKorn > Issue Type: Bug > Components: core - scheduler >Affects Versions: 0.10 >Reporter: Wilfred Spiegelenburg >Assignee: Wilfred Spiegelenburg >Priority: Major > Labels: pull-request-available > > The mock plugin test added in YUNIKORN-505 does not have a license file as it > should have. We need to add it: > scheduler/mock_plugin_test.go -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Assigned] (YUNIKORN-768) License header missing on test file
[ https://issues.apache.org/jira/browse/YUNIKORN-768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wilfred Spiegelenburg reassigned YUNIKORN-768: -- Assignee: Wilfred Spiegelenburg > License header missing on test file > --- > > Key: YUNIKORN-768 > URL: https://issues.apache.org/jira/browse/YUNIKORN-768 > Project: Apache YuniKorn > Issue Type: Bug > Components: shim - kubernetes >Affects Versions: 0.10 >Reporter: Wilfred Spiegelenburg >Assignee: Wilfred Spiegelenburg >Priority: Major > > In YUNIKORN-427 we forgot to add the apache license header to the file: > test/e2e/predicates/predicates_test.go > We need to add the apache license header. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Updated] (YUNIKORN-767) Add license to mock_plugin_test.go
[ https://issues.apache.org/jira/browse/YUNIKORN-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated YUNIKORN-767: Labels: pull-request-available (was: ) > Add license to mock_plugin_test.go > -- > > Key: YUNIKORN-767 > URL: https://issues.apache.org/jira/browse/YUNIKORN-767 > Project: Apache YuniKorn > Issue Type: Bug > Components: core - scheduler >Affects Versions: 0.10 >Reporter: Wilfred Spiegelenburg >Assignee: Wilfred Spiegelenburg >Priority: Major > Labels: pull-request-available > > The mock plugin test added in YUNIKORN-505 does not have a license file as it > should have. We need to add it: > scheduler/mock_plugin_test.go -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Created] (YUNIKORN-768) License header missing on test file
Wilfred Spiegelenburg created YUNIKORN-768: -- Summary: License header missing on test file Key: YUNIKORN-768 URL: https://issues.apache.org/jira/browse/YUNIKORN-768 Project: Apache YuniKorn Issue Type: Bug Components: shim - kubernetes Affects Versions: 0.10 Reporter: Wilfred Spiegelenburg In YUNIKORN-427 we forgot to add the apache license header to the file: test/e2e/predicates/predicates_test.go We need to add the apache license header. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Created] (YUNIKORN-767) Add license to mock_plugin_test.go
Wilfred Spiegelenburg created YUNIKORN-767: -- Summary: Add license to mock_plugin_test.go Key: YUNIKORN-767 URL: https://issues.apache.org/jira/browse/YUNIKORN-767 Project: Apache YuniKorn Issue Type: Bug Components: core - scheduler Affects Versions: 0.10 Reporter: Wilfred Spiegelenburg Assignee: Wilfred Spiegelenburg The mock plugin test added in YUNIKORN-505 does not have a license file as it should have. We need to add it: scheduler/mock_plugin_test.go -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
