[jira] [Comment Edited] (YUNIKORN-941) split scheduler and admission controller deployment
[ https://issues.apache.org/jira/browse/YUNIKORN-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472261#comment-17472261 ] Craig Condit edited comment on YUNIKORN-941 at 1/10/22, 7:40 PM: - PR #346 opened for shim-side changes, and #60 for release (helm chart) changes. was (Author: ccondit): PR #331 opened for shim-side changes, and #346 for release (helm chart) changes. > split scheduler and admission controller deployment > --- > > Key: YUNIKORN-941 > URL: https://issues.apache.org/jira/browse/YUNIKORN-941 > Project: Apache YuniKorn > Issue Type: Sub-task > Components: shim - kubernetes >Reporter: Kinga Marton >Assignee: Craig Condit >Priority: Major > Labels: pull-request-available > Attachments: logs_322.zip > > > To support proper YuniKorn upgrades and restarts we should move the admission > controller out of the scheduler deployment and make it a separate deployment. > This could also allow the admission controller to be made high available and > allow simpler no down time upgrades possible. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Comment Edited] (YUNIKORN-941) split scheduler and admission controller deployment
[
https://issues.apache.org/jira/browse/YUNIKORN-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17457032#comment-17457032
]
Peter Bacsko edited comment on YUNIKORN-941 at 12/10/21, 10:30 AM:
---
I think the commit needs to be reverted and we should start working on the
replacement of {{admission_util.sh}} and leverage the {{initContainers}}
approach (unless there is a better idea ofc).
was (Author: pbacsko):
I think the commit needs to be reverted and we should start working on the
replacement of {{admission_util.sh}} and leverage the {{initContainers}}
approach.
> split scheduler and admission controller deployment
> ---
>
> Key: YUNIKORN-941
> URL: https://issues.apache.org/jira/browse/YUNIKORN-941
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: shim - kubernetes
>Reporter: Kinga Marton
>Assignee: Peter Bacsko
>Priority: Blocker
> Labels: pull-request-available
> Attachments: logs_322.zip
>
>
> To support proper YuniKorn upgrades and restarts we should move the admission
> controller out of the scheduler deployment and make it a separate deployment.
> This could also allow the admission controller to be made high available and
> allow simpler no down time upgrades possible.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Comment Edited] (YUNIKORN-941) split scheduler and admission controller deployment
[ https://issues.apache.org/jira/browse/YUNIKORN-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448112#comment-17448112 ] Kinga Marton edited comment on YUNIKORN-941 at 11/23/21, 5:14 PM: -- I created the following 2 PR's: [https://github.com/apache/incubator-yunikorn-release/pull/50] [https://github.com/apache/incubator-yunikorn-k8shim/pull/331] In this PR's I just moved away the admission controller related things from the scheduler image. However now we have it in a different deployment, independently from the scheduler, I mould move forward and try to remove the admission_utils.sh script, and handle the admission controller from helm charts or from code, without running shell scripts. was (Author: kmarton): I created the following 2 PR's: [https://github.com/apache/incubator-yunikorn-release/pull/50] [https://github.com/apache/incubator-yunikorn-k8shim/pull/331] In this PR's I just moved away the admission controller related things from the scheduler image. However now we have it in a different deployment, independently from the scheduler, I mould moove forward and try to remove the admission_utils.sh script, and handle the admission controller from helm charts or from code, without running shell scripts. > split scheduler and admission controller deployment > --- > > Key: YUNIKORN-941 > URL: https://issues.apache.org/jira/browse/YUNIKORN-941 > Project: Apache YuniKorn > Issue Type: Improvement > Components: shim - kubernetes >Reporter: Kinga Marton >Assignee: Kinga Marton >Priority: Major > Labels: pull-request-available > > To support proper YuniKorn upgrades and restarts we should move the admission > controller out of the scheduler deployment and make it a separate deployment. > This could also allow the admission controller to be made high available and > allow simpler no down time upgrades possible. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
