[jira] [Commented] (YUNIKORN-1202) Add metrics to track partition resources

2022-05-26 Thread Peter Bacsko (Jira)


[ 
https://issues.apache.org/jira/browse/YUNIKORN-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542531#comment-17542531
 ] 

Peter Bacsko commented on YUNIKORN-1202:


In {{{}queue.go{}}}, there are some methods related to resource tracking. I 
modified the method {{updateAllocatedAndPendingResourceMetrics()}} (I believe 
it was called differently) and I noticed that the condition {{sq.isLeaf}} is 
used at different places. So right now we're only tracking certain metrics for 
leafs. I didn't do any research to find out why that {{if}} branch is there.

I'm not sure if that's really necessary. It could be that removing that 
condition is just fine and tracking will be done for all queues.

> Add metrics to track partition resources
> 
>
> Key: YUNIKORN-1202
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1202
> Project: Apache YuniKorn
>  Issue Type: Sub-task
>Reporter: Weiwei Yang
>Priority: Major
>
> When we monitor the cluster resources, we need to track what is available vs 
> what is used. In the queue metrics, currently, we have per queue used 
> resource metrics e.g yunikorn_queue_root_xyz_used_resource. But we do not 
> have metrics to track what's the total partition resources (both used and 
> total), we need to add that too.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org



[jira] [Commented] (YUNIKORN-1202) Add metrics to track partition resources

2022-05-26 Thread Wilfred Spiegelenburg (Jira)


[ 
https://issues.apache.org/jira/browse/YUNIKORN-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542401#comment-17542401
 ] 

Wilfred Spiegelenburg commented on YUNIKORN-1202:
-

[~pbacsko] can you have a look at this too. You added a number of new metrics 
in the latest release for queues.

> Add metrics to track partition resources
> 
>
> Key: YUNIKORN-1202
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1202
> Project: Apache YuniKorn
>  Issue Type: Sub-task
>Reporter: Weiwei Yang
>Priority: Major
>
> When we monitor the cluster resources, we need to track what is available vs 
> what is used. In the queue metrics, currently, we have per queue used 
> resource metrics e.g yunikorn_queue_root_xyz_used_resource. But we do not 
> have metrics to track what's the total partition resources (both used and 
> total), we need to add that too.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org



[jira] [Commented] (YUNIKORN-1202) Add metrics to track partition resources

2022-05-25 Thread Weiwei Yang (Jira)


[ 
https://issues.apache.org/jira/browse/YUNIKORN-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542373#comment-17542373
 ] 

Weiwei Yang commented on YUNIKORN-1202:
---

hi [~wilfreds], [~surahman]

Could you please double-check this? 
Looks like we only expose the leaf queue resources today, code comment:
https://github.com/apache/yunikorn-core/blob/7f0ca094f04653f61ee6a369bfd8c3f352bf7c62/pkg/scheduler/objects/queue.go#L1266
https://github.com/apache/yunikorn-core/blob/7f0ca094f04653f61ee6a369bfd8c3f352bf7c62/pkg/scheduler/objects/queue.go#L1277

I want to set up some graph to show queue usage, but I do not see where I can 
get the root queue or partition resources.

> Add metrics to track partition resources
> 
>
> Key: YUNIKORN-1202
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1202
> Project: Apache YuniKorn
>  Issue Type: Sub-task
>Reporter: Weiwei Yang
>Priority: Major
>
> When we monitor the cluster resources, we need to track what is available vs 
> what is used. In the queue metrics, currently, we have per queue used 
> resource metrics e.g yunikorn_queue_root_xyz_used_resource. But we do not 
> have metrics to track what's the total partition resources (both used and 
> total), we need to add that too.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org



[jira] [Commented] (YUNIKORN-1202) Add metrics to track partition resources

2022-05-24 Thread Saad Ur Rahman (Jira)


[ 
https://issues.apache.org/jira/browse/YUNIKORN-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541801#comment-17541801
 ] 

Saad Ur Rahman commented on YUNIKORN-1202:
--

Should we close this feature request?

> Add metrics to track partition resources
> 
>
> Key: YUNIKORN-1202
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1202
> Project: Apache YuniKorn
>  Issue Type: Sub-task
>Reporter: Weiwei Yang
>Priority: Major
>
> When we monitor the cluster resources, we need to track what is available vs 
> what is used. In the queue metrics, currently, we have per queue used 
> resource metrics e.g yunikorn_queue_root_xyz_used_resource. But we do not 
> have metrics to track what's the total partition resources (both used and 
> total), we need to add that too.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org



[jira] [Commented] (YUNIKORN-1202) Add metrics to track partition resources

2022-05-24 Thread Wilfred Spiegelenburg (Jira)


[ 
https://issues.apache.org/jira/browse/YUNIKORN-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541386#comment-17541386
 ] 

Wilfred Spiegelenburg commented on YUNIKORN-1202:
-

The root queue is always the size of the cluster. The maximum resources 
available in the cluster is a direct reflection of the number of nodes 
registered.

If the root queue has a maximum resource 1000GB / 500 vcores then that is the 
{{total}} for the cluster and thus the metric you are looking for. The usage of 
the root queue is the same as for all other queues. It gets updated for every 
allocation that is made and thus reflects the partition usage.

The partition metrics would thus be a copy of the root queue metrics. Not sure 
if we want/need to expose that separately on the partition but there is no need 
to track anything extra.

> Add metrics to track partition resources
> 
>
> Key: YUNIKORN-1202
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1202
> Project: Apache YuniKorn
>  Issue Type: Sub-task
>Reporter: Weiwei Yang
>Priority: Major
>
> When we monitor the cluster resources, we need to track what is available vs 
> what is used. In the queue metrics, currently, we have per queue used 
> resource metrics e.g yunikorn_queue_root_xyz_used_resource. But we do not 
> have metrics to track what's the total partition resources (both used and 
> total), we need to add that too.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org



[jira] [Commented] (YUNIKORN-1202) Add metrics to track partition resources

2022-05-23 Thread Saad Ur Rahman (Jira)


[ 
https://issues.apache.org/jira/browse/YUNIKORN-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541080#comment-17541080
 ] 

Saad Ur Rahman commented on YUNIKORN-1202:
--

I will start looking into this.

> Add metrics to track partition resources
> 
>
> Key: YUNIKORN-1202
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1202
> Project: Apache YuniKorn
>  Issue Type: Sub-task
>Reporter: Weiwei Yang
>Priority: Major
>
> When we monitor the cluster resources, we need to track what is available vs 
> what is used. In the queue metrics, currently, we have per queue used 
> resource metrics e.g yunikorn_queue_root_xyz_used_resource. But we do not 
> have metrics to track what's the total partition resources (both used and 
> total), we need to add that too.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org