[jira] [Commented] (YUNIKORN-208) Increase unit test coverage for webservice.go
[ https://issues.apache.org/jira/browse/YUNIKORN-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507430#comment-17507430 ] Ting Yao,Huang commented on YUNIKORN-208: - Just for unit test. Since we got 78% of coverage, and I don't think we need some smoke test, I think we can close this Jira with "won't fix". > Increase unit test coverage for webservice.go > - > > Key: YUNIKORN-208 > URL: https://issues.apache.org/jira/browse/YUNIKORN-208 > Project: Apache YuniKorn > Issue Type: Sub-task > Components: webapp >Reporter: Weiwei Yang >Assignee: Ting Yao,Huang >Priority: Major > > The webapp package coverage is less than 20%. We need to add more unit tests > for this. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Commented] (YUNIKORN-208) Increase unit test coverage for webservice.go
[
https://issues.apache.org/jira/browse/YUNIKORN-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507270#comment-17507270
]
Wilfred Spiegelenburg commented on YUNIKORN-208:
The latest run for the package shows a far better coverage:
{code:java}
ok github.com/apache/incubator-yunikorn-core/pkg/webservice 5.351s
coverage: 78.8% of statements
? github.com/apache/incubator-yunikorn-core/pkg/webservice/dao [no
test files] {code}
The webservice.go file gets a 32% test coverage based on all the other tests
that are run.
Are you looking at adding a smoke test using a real HTTP client or just unit
tests?
> Increase unit test coverage for webservice.go
> -
>
> Key: YUNIKORN-208
> URL: https://issues.apache.org/jira/browse/YUNIKORN-208
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Components: webapp
>Reporter: Weiwei Yang
>Assignee: Ting Yao,Huang
>Priority: Major
>
> The webapp package coverage is less than 20%. We need to add more unit tests
> for this.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Commented] (YUNIKORN-208) Increase unit test coverage for webservice.go
[ https://issues.apache.org/jira/browse/YUNIKORN-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162776#comment-17162776 ] Adam Antal commented on YUNIKORN-208: - Probably we should wait YUNIKORN-283 to be merged before go any further with this. After that we can add more test covering the other handler functions. > Increase unit test coverage for webservice.go > - > > Key: YUNIKORN-208 > URL: https://issues.apache.org/jira/browse/YUNIKORN-208 > Project: Apache YuniKorn > Issue Type: Sub-task > Components: webapp >Reporter: Weiwei Yang >Assignee: Adam Antal >Priority: Major > > The webapp package coverage is less than 20%. We need to add more unit tests > for this. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
