[jira] [Commented] (YUNIKORN-819) Update go version dependency to 1.15
[
https://issues.apache.org/jira/browse/YUNIKORN-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17414762#comment-17414762
]
Chia-Ping Tsai commented on YUNIKORN-819:
-
[~wilfreds] thanks for this great explanation. It does benefit me a lot.
{quote}
Even with an older version of go you can still compile the project.
{quote}
Should we remove the version check from Makefile to support to build project
with older go version?
> Update go version dependency to 1.15
>
>
> Key: YUNIKORN-819
> URL: https://issues.apache.org/jira/browse/YUNIKORN-819
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: core - cache, scheduler-interface, shim - kubernetes
>Reporter: Weiwei Yang
>Assignee: Chia-Ping Tsai
>Priority: Major
> Labels: newbie, pull-request-available
> Fix For: 1.0.0
>
>
> We need to update all go dependency to 1.15
> this is defined in the top level go mod file
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Commented] (YUNIKORN-819) Update go version dependency to 1.15
[ https://issues.apache.org/jira/browse/YUNIKORN-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17414729#comment-17414729 ] Wilfred Spiegelenburg commented on YUNIKORN-819: To make it clear: this has not changed *anything*. The go.mod version as explained a number of times before has nothing to do with dependencies. It specifies that the go code used within the project is using the go language specification for that version. It does not update anything it does not enforce anything. https://golang.org/doc/modules/gomod-ref#go Even with an older version of go you can still compile the project. It just changes the way compilation errors are handled. > Update go version dependency to 1.15 > > > Key: YUNIKORN-819 > URL: https://issues.apache.org/jira/browse/YUNIKORN-819 > Project: Apache YuniKorn > Issue Type: Bug > Components: core - cache, scheduler-interface, shim - kubernetes >Reporter: Weiwei Yang >Assignee: Chia-Ping Tsai >Priority: Major > Labels: newbie, pull-request-available > Fix For: 1.0.0 > > > We need to update all go dependency to 1.15 > this is defined in the top level go mod file -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Commented] (YUNIKORN-819) Update go version dependency to 1.15
[ https://issues.apache.org/jira/browse/YUNIKORN-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17405015#comment-17405015 ] Chia-Ping Tsai commented on YUNIKORN-819: - [~wwei] thanks! I have filed PRs for core, k8shim, and si. > Update go version dependency to 1.15 > > > Key: YUNIKORN-819 > URL: https://issues.apache.org/jira/browse/YUNIKORN-819 > Project: Apache YuniKorn > Issue Type: Bug > Components: core - cache, scheduler-interface, shim - kubernetes >Reporter: Weiwei Yang >Assignee: Chia-Ping Tsai >Priority: Major > Labels: newbie, pull-request-available > Fix For: 1.0.0 > > > We need to update all go dependency to 1.15 > this is defined in the top level go mod file -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Commented] (YUNIKORN-819) Update go version dependency to 1.15
[ https://issues.apache.org/jira/browse/YUNIKORN-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17404957#comment-17404957 ] Weiwei Yang commented on YUNIKORN-819: -- Sure, assigning to you. Thanks! > Update go version dependency to 1.15 > > > Key: YUNIKORN-819 > URL: https://issues.apache.org/jira/browse/YUNIKORN-819 > Project: Apache YuniKorn > Issue Type: Bug > Components: core - cache, scheduler-interface, shim - kubernetes >Reporter: Weiwei Yang >Priority: Major > Labels: newbie > Fix For: 1.0.0 > > > We need to update all go dependency to 1.15 > this is defined in the top level go mod file -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Commented] (YUNIKORN-819) Update go version dependency to 1.15
[ https://issues.apache.org/jira/browse/YUNIKORN-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17403595#comment-17403595 ] Chia-Ping Tsai commented on YUNIKORN-819: - [~wwei] thanks for the explanation. Can I take over this Jira? > Update go version dependency to 1.15 > > > Key: YUNIKORN-819 > URL: https://issues.apache.org/jira/browse/YUNIKORN-819 > Project: Apache YuniKorn > Issue Type: Bug > Components: core - cache, scheduler-interface, shim - kubernetes >Reporter: Weiwei Yang >Priority: Major > Labels: newbie > Fix For: 1.0.0 > > > We need to update all go dependency to 1.15 > this is defined in the top level go mod file -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Commented] (YUNIKORN-819) Update go version dependency to 1.15
[ https://issues.apache.org/jira/browse/YUNIKORN-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17403405#comment-17403405 ] Weiwei Yang commented on YUNIKORN-819: -- hi [~chia7712], the major reason is that our current tests are running against 1.15. such as https://github.com/apache/incubator-yunikorn-k8shim/blob/25a71ba3fc646cbd96dff5b2882388eceb27bf9c/.github/workflows/main.yml#L15. It might potentially be a bigger change if we upgrade to 1.17. > Update go version dependency to 1.15 > > > Key: YUNIKORN-819 > URL: https://issues.apache.org/jira/browse/YUNIKORN-819 > Project: Apache YuniKorn > Issue Type: Bug > Components: core - cache, scheduler-interface, shim - kubernetes >Reporter: Weiwei Yang >Priority: Major > Labels: newbie > Fix For: 1.0.0 > > > We need to update all go dependency to 1.15 > this is defined in the top level go mod file -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Commented] (YUNIKORN-819) Update go version dependency to 1.15
[ https://issues.apache.org/jira/browse/YUNIKORN-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17403350#comment-17403350 ] Chia-Ping Tsai commented on YUNIKORN-819: - just curious. Why not updating to go 1.17 (the latest version)? > Update go version dependency to 1.15 > > > Key: YUNIKORN-819 > URL: https://issues.apache.org/jira/browse/YUNIKORN-819 > Project: Apache YuniKorn > Issue Type: Bug > Components: core - cache, scheduler-interface, shim - kubernetes >Reporter: Weiwei Yang >Priority: Major > Labels: newbie > Fix For: 1.0.0 > > > We need to update all go dependency to 1.15 > this is defined in the top level go mod file -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
