[jira] [Updated] (YUNIKORN-1124) Avoid passing empty nodeAttributes in UpdateNode request
[ https://issues.apache.org/jira/browse/YUNIKORN-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated YUNIKORN-1124: - Labels: pull-request-available (was: ) > Avoid passing empty nodeAttributes in UpdateNode request > > > Key: YUNIKORN-1124 > URL: https://issues.apache.org/jira/browse/YUNIKORN-1124 > Project: Apache YuniKorn > Issue Type: Bug >Reporter: Manikandan R >Assignee: Manikandan R >Priority: Major > Labels: pull-request-available > > YUNIKORN-1123 had fixed YUNIKORN-1090 by passing empty nodeAttributes in > UpdateNode request. But it is better to handle this empty checks in core > itself and avoid passing empty attributes map from shim side. In addition, > need to assess the following: > > # Does core uses OccupiedResource and labels attributes being sent as part > of Create NodeRequest from shim? > # By any chance, Does shim need to pass yunikorn.apache.org/nodeType > attribute to core? Anyway, need to make it as constant -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Updated] (YUNIKORN-1124) Avoid passing empty nodeAttributes in UpdateNode request
[ https://issues.apache.org/jira/browse/YUNIKORN-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wilfred Spiegelenburg updated YUNIKORN-1124: Issue Type: Bug (was: Improvement) > Avoid passing empty nodeAttributes in UpdateNode request > > > Key: YUNIKORN-1124 > URL: https://issues.apache.org/jira/browse/YUNIKORN-1124 > Project: Apache YuniKorn > Issue Type: Bug >Reporter: Manikandan R >Assignee: Manikandan R >Priority: Major > > YUNIKORN-1123 had fixed YUNIKORN-1090 by passing empty nodeAttributes in > UpdateNode request. But it is better to handle this empty checks in core > itself and avoid passing empty attributes map from shim side. In addition, > need to assess the following: > > # Does core uses OccupiedResource and labels attributes being sent as part > of Create NodeRequest from shim? > # By any chance, Does shim need to pass yunikorn.apache.org/nodeType > attribute to core? Anyway, need to make it as constant -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Updated] (YUNIKORN-1124) Avoid passing empty nodeAttributes in UpdateNode request
[ https://issues.apache.org/jira/browse/YUNIKORN-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wilfred Spiegelenburg updated YUNIKORN-1124: Target Version: 1.0.0 > Avoid passing empty nodeAttributes in UpdateNode request > > > Key: YUNIKORN-1124 > URL: https://issues.apache.org/jira/browse/YUNIKORN-1124 > Project: Apache YuniKorn > Issue Type: Improvement >Reporter: Manikandan R >Assignee: Manikandan R >Priority: Major > > YUNIKORN-1123 had fixed YUNIKORN-1090 by passing empty nodeAttributes in > UpdateNode request. But it is better to handle this empty checks in core > itself and avoid passing empty attributes map from shim side. In addition, > need to assess the following: > > # Does core uses OccupiedResource and labels attributes being sent as part > of Create NodeRequest from shim? > # By any chance, Does shim need to pass yunikorn.apache.org/nodeType > attribute to core? Anyway, need to make it as constant -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
[jira] [Updated] (YUNIKORN-1124) Avoid passing empty nodeAttributes in UpdateNode request
[ https://issues.apache.org/jira/browse/YUNIKORN-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wilfred Spiegelenburg updated YUNIKORN-1124: Fix Version/s: (was: 1.0.0) > Avoid passing empty nodeAttributes in UpdateNode request > > > Key: YUNIKORN-1124 > URL: https://issues.apache.org/jira/browse/YUNIKORN-1124 > Project: Apache YuniKorn > Issue Type: Improvement >Reporter: Manikandan R >Assignee: Manikandan R >Priority: Major > > YUNIKORN-1123 had fixed YUNIKORN-1090 by passing empty nodeAttributes in > UpdateNode request. But it is better to handle this empty checks in core > itself and avoid passing empty attributes map from shim side. In addition, > need to assess the following: > > # Does core uses OccupiedResource and labels attributes being sent as part > of Create NodeRequest from shim? > # By any chance, Does shim need to pass yunikorn.apache.org/nodeType > attribute to core? Anyway, need to make it as constant -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org
