[jira] [Commented] (ZOOKEEPER-3354) Improve efficiency of DeleteAllCommand
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857256#comment-16857256 ] Hudson commented on ZOOKEEPER-3354: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #558 (See [https://builds.apache.org/job/ZooKeeper-trunk/558/]) ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand (fangmin: rev 39c40bea3a04cda70a6f9e8caad64b26d4d046e6) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/DeleteAllCommand.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/ZooKeeperTest.java > Improve efficiency of DeleteAllCommand > -- > > Key: ZOOKEEPER-3354 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3354 > Project: ZooKeeper > Issue Type: Improvement > Components: other >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Priority: Trivial > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > The cli DeleteAllCommand internally uses a synchronous iterative formula. > This can be improved with batching for quicker response time on large > subtrees. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3413) add a serialVersionUID for ClientCnxnLimitException to make compile no warning
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857234#comment-16857234
]
maoling commented on ZOOKEEPER-3413:
[~eolivelli]
I reproduce this issue anymore.this may be caused from ZOOKEEPER-3385: fix
build break.
> add a serialVersionUID for ClientCnxnLimitException to make compile no warning
> --
>
> Key: ZOOKEEPER-3413
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3413
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client
>Affects Versions: 3.6.0
>Reporter: maoling
>Priority: Minor
>
> build-generated:
> [javac] Compiling 2 source files to
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
> compile:
> [javac] Compiling 49 source files to
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
> [javac]
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/ClientCnxnLimitException.java:24:
> 警告: [serial] 可序列化类ClientCnxnLimitException没有 serialVersionUID 的定义
> [javac] public class ClientCnxnLimitException extends Exception {
> [javac] ^
> [javac] 1 个警告
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-3413) add a serialVersionUID for ClientCnxnLimitException to make compile no warning
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
maoling resolved ZOOKEEPER-3413.
Resolution: Won't Fix
> add a serialVersionUID for ClientCnxnLimitException to make compile no warning
> --
>
> Key: ZOOKEEPER-3413
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3413
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client
>Affects Versions: 3.6.0
>Reporter: maoling
>Priority: Minor
>
> build-generated:
> [javac] Compiling 2 source files to
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
> compile:
> [javac] Compiling 49 source files to
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
> [javac]
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/ClientCnxnLimitException.java:24:
> 警告: [serial] 可序列化类ClientCnxnLimitException没有 serialVersionUID 的定义
> [javac] public class ClientCnxnLimitException extends Exception {
> [javac] ^
> [javac] 1 个警告
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3344) write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter and doc the usage
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-3344: --- Summary: write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter and doc the usage (was: write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter.java) > write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter and > doc the usage > -- > > Key: ZOOKEEPER-3344 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3344 > Project: ZooKeeper > Issue Type: New Feature > Components: scripts >Affects Versions: 3.5.4 >Reporter: maoling >Assignee: maoling >Priority: Major > > write a new script:*zkSnapShotToolkit.sh* to encapsulate > *SnapshotFormatter.java* > just like*: zkTxnLogToolkit.sh* for the users' convenience. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3321) Add metrics for Leader
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857189#comment-16857189 ] Hudson commented on ZOOKEEPER-3321: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #391 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/391/]) ZOOKEEPER-3321: Add metrics for Leader (fangmin: rev e732d3703137b4c3c4cacd680ed8388f8bf5e677) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LeaderMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java > Add metrics for Leader > -- > > Key: ZOOKEEPER-3321 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3321 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3354) Improve efficiency of DeleteAllCommand
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857190#comment-16857190 ] Hudson commented on ZOOKEEPER-3354: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #391 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/391/]) ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand (fangmin: rev 39c40bea3a04cda70a6f9e8caad64b26d4d046e6) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/DeleteAllCommand.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/ZooKeeperTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java > Improve efficiency of DeleteAllCommand > -- > > Key: ZOOKEEPER-3354 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3354 > Project: ZooKeeper > Issue Type: Improvement > Components: other >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Priority: Trivial > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > The cli DeleteAllCommand internally uses a synchronous iterative formula. > This can be improved with batching for quicker response time on large > subtrees. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3321) Add metrics for Leader
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857117#comment-16857117 ] Hudson commented on ZOOKEEPER-3321: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #557 (See [https://builds.apache.org/job/ZooKeeper-trunk/557/]) ZOOKEEPER-3321: Add metrics for Leader (fangmin: rev e732d3703137b4c3c4cacd680ed8388f8bf5e677) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LeaderMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java > Add metrics for Leader > -- > > Key: ZOOKEEPER-3321 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3321 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-3321) Add metrics for Leader
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv resolved ZOOKEEPER-3321. --- Resolution: Fixed Issue resolved by pull request 858 [https://github.com/apache/zookeeper/pull/858] > Add metrics for Leader > -- > > Key: ZOOKEEPER-3321 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3321 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 3h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3416) Remove redundant ServerCnxnFactoryAccessor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3416: -- Labels: Twitter pull-request-available (was: Twitter) > Remove redundant ServerCnxnFactoryAccessor > -- > > Key: ZOOKEEPER-3416 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3416 > Project: ZooKeeper > Issue Type: Improvement > Components: tests >Affects Versions: 3.6.0 >Reporter: Michael Han >Assignee: Michael Han >Priority: Minor > Labels: Twitter, pull-request-available > > We have two ways to access the private zkServer inside ServerCnxnFactory, and > there is really no need to keep maintaining both. We could remove > ServerCnxnFactoryAccessor when we added the public accessor for > ServerCnxnFactory in ZOOKEEPER-1346, but we did not. > The solution is to consolidate all access of the zkServer through the public > accessor of ServerCnxnFactory. The end result is cleaner code base and less > confusion. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3416) Remove redundant ServerCnxnFactoryAccessor
Michael Han created ZOOKEEPER-3416: -- Summary: Remove redundant ServerCnxnFactoryAccessor Key: ZOOKEEPER-3416 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3416 Project: ZooKeeper Issue Type: Improvement Components: tests Affects Versions: 3.6.0 Reporter: Michael Han Assignee: Michael Han We have two ways to access the private zkServer inside ServerCnxnFactory, and there is really no need to keep maintaining both. We could remove ServerCnxnFactoryAccessor when we added the public accessor for ServerCnxnFactory in ZOOKEEPER-1346, but we did not. The solution is to consolidate all access of the zkServer through the public accessor of ServerCnxnFactory. The end result is cleaner code base and less confusion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3415) convert internal logic to use java 8 streams
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856900#comment-16856900
]
Brian Nixon commented on ZOOKEEPER-3415:
As an example:
{code:java}
+++
b/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
@@ -37,6 +37,7 @@
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicLong;
import java.util.function.BiConsumer;
+import java.util.stream.Collectors;
import javax.security.sasl.SaslException;
@@ -383,17 +384,9 @@ public void loadData() throws IOException,
InterruptedException {
}
// Clean up dead sessions
- List deadSessions = new ArrayList<>();
- for (Long session : zkDb.getSessions()) {
- if (zkDb.getSessionWithTimeOuts().get(session) == null) {
- deadSessions.add(session);
- }
- }
-
- for (long session : deadSessions) {
- // XXX: Is lastProcessedZxid really the best thing to use?
- killSession(session, zkDb.getDataTreeLastProcessedZxid());
- }
+ zkDb.getSessions().stream()
+ .filter(session -> zkDb.getSessionWithTimeOuts().get(session)
== null)
+ .forEach(session -> killSession(session,
zkDb.getDataTreeLastProcessedZxid()));
// Make a clean snapshot
takeSnapshot();
{code}
> convert internal logic to use java 8 streams
>
>
> Key: ZOOKEEPER-3415
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3415
> Project: ZooKeeper
> Issue Type: Wish
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Priority: Trivial
>
> There are a number of places in the code where for loops are used to perform
> basic filtering and collection. The java 8 stream api's make these operations
> much more polished. Since the master branch has been at this language level
> for a while, I'd wish for a (series of) refactor(s) to convert more of these
> loops to streams.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3415) convert internal logic to use java 8 streams
Brian Nixon created ZOOKEEPER-3415: -- Summary: convert internal logic to use java 8 streams Key: ZOOKEEPER-3415 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3415 Project: ZooKeeper Issue Type: Wish Affects Versions: 3.6.0 Reporter: Brian Nixon There are a number of places in the code where for loops are used to perform basic filtering and collection. The java 8 stream api's make these operations much more polished. Since the master branch has been at this language level for a while, I'd wish for a (series of) refactor(s) to convert more of these loops to streams. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3385) Add admin command to display leader
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856756#comment-16856756 ] Hudson commented on ZOOKEEPER-3385: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #556 (See [https://builds.apache.org/job/ZooKeeper-trunk/556/]) ZOOKEEPER-3385: fix build break. (nkalmar: rev 5577d41da48feb8db3595d88a63096594c20fbb9) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java > Add admin command to display leader > --- > > Key: ZOOKEEPER-3385 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3385 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Priority: Trivial > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > Each QuorumPeer prints the identity of the server it believes is the leader > in its logs but that is not easily turned into diagnostic information about > the state of the ensemble. It can be useful in debugging various issues, both > when a quorum is struggling to be established and when a minority of peers > are failing to follow, to see at a glance which peers are following the > leader elected by the majority and which peers are either not following or > following a different server. > Create an admin command that exposes which server a peer believes is the > current leader. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3385) Add admin command to display leader
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856707#comment-16856707 ] Hudson commented on ZOOKEEPER-3385: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #390 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/390/]) ZOOKEEPER-3385: fix build break. (nkalmar: rev 5577d41da48feb8db3595d88a63096594c20fbb9) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java > Add admin command to display leader > --- > > Key: ZOOKEEPER-3385 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3385 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Priority: Trivial > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > Each QuorumPeer prints the identity of the server it believes is the leader > in its logs but that is not easily turned into diagnostic information about > the state of the ensemble. It can be useful in debugging various issues, both > when a quorum is struggling to be established and when a minority of peers > are failing to follow, to see at a glance which peers are following the > leader elected by the majority and which peers are either not following or > following a different server. > Create an admin command that exposes which server a peer believes is the > current leader. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3413) add a serialVersionUID for ClientCnxnLimitException to make compile no warning
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856641#comment-16856641
]
Enrico Olivelli commented on ZOOKEEPER-3413:
Adding such variable is okay.
It is not a real problem but it s better not to make javqc complaint.
Can you check why on maven build qe don't have such error?
Maybe we are lacking some flag on java compiler plugin
> add a serialVersionUID for ClientCnxnLimitException to make compile no warning
> --
>
> Key: ZOOKEEPER-3413
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3413
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client
>Affects Versions: 3.6.0
>Reporter: maoling
>Priority: Minor
>
> build-generated:
> [javac] Compiling 2 source files to
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
> compile:
> [javac] Compiling 49 source files to
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
> [javac]
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/ClientCnxnLimitException.java:24:
> 警告: [serial] 可序列化类ClientCnxnLimitException没有 serialVersionUID 的定义
> [javac] public class ClientCnxnLimitException extends Exception {
> [javac] ^
> [javac] 1 个警告
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3413) add a serialVersionUID for ClientCnxnLimitException to make compile no warning
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856636#comment-16856636
]
Enrico Olivelli commented on ZOOKEEPER-3413:
Can you please translate the error to English?
> add a serialVersionUID for ClientCnxnLimitException to make compile no warning
> --
>
> Key: ZOOKEEPER-3413
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3413
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client
>Affects Versions: 3.6.0
>Reporter: maoling
>Priority: Minor
>
> build-generated:
> [javac] Compiling 2 source files to
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
> compile:
> [javac] Compiling 49 source files to
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
> [javac]
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/ClientCnxnLimitException.java:24:
> 警告: [serial] 可序列化类ClientCnxnLimitException没有 serialVersionUID 的定义
> [javac] public class ClientCnxnLimitException extends Exception {
> [javac] ^
> [javac] 1 个警告
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (ZOOKEEPER-3344) write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter.java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling reassigned ZOOKEEPER-3344: -- Assignee: maoling > write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter.java > - > > Key: ZOOKEEPER-3344 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3344 > Project: ZooKeeper > Issue Type: New Feature > Components: scripts >Affects Versions: 3.5.4 >Reporter: maoling >Assignee: maoling >Priority: Major > > write a new script:*zkSnapShotToolkit.sh* to encapsulate > *SnapshotFormatter.java* > just like*: zkTxnLogToolkit.sh* for the users' convenience. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3380) A revist to the quota mechanism
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856551#comment-16856551 ] maoling commented on ZOOKEEPER-3380: [~lvfangmin] I leave the throught quota feature for you to do: D > A revist to the quota mechanism > --- > > Key: ZOOKEEPER-3380 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3380 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: maoling >Priority: Major > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-2842) optimize the finish() of Send/RecvWorker in QuorumCnxManager and remove testInitiateConnection() and formates some codes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling resolved ZOOKEEPER-2842. Resolution: Won't Do > optimize the finish() of Send/RecvWorker in QuorumCnxManager and remove > testInitiateConnection() and formates some codes > > > Key: ZOOKEEPER-2842 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2842 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Reporter: maoling >Priority: Trivial > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > 1.the finish() of Send/RecvWorker in QuorumCnxManager changes to > double-checked lock style > [https://en.wikipedia.org/wiki/Double-checked_locking] > ,a trivial code changes implement a smaller granularity lock to have a better > perfermance in too fierce multithread situation. > 2.testInitiateConnection() is redundant test function which is only used in > TestCase,so I refactor it. > 3.some codes don't abide to Java Programme Specification ,so I lift a finger > to format them -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3414) sync api should throw NoNodeException when syncing a path which is not exist
maoling created ZOOKEEPER-3414: -- Summary: sync api should throw NoNodeException when syncing a path which is not exist Key: ZOOKEEPER-3414 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3414 Project: ZooKeeper Issue Type: Bug Components: java client Reporter: maoling Fix For: 3.6.0 [zk: 127.0.0.1:2180(CONNECTED) 0] sync /c1 Sync is OK [zk: 127.0.0.1:2180(CONNECTED) 1] sync /c1dsafasdfasdfadsfasd Node does not exist: /c1dsafasdfasdfadsfasd -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3413) add a serialVersionUID for ClientCnxnLimitException to make compile no warning
maoling created ZOOKEEPER-3413:
--
Summary: add a serialVersionUID for ClientCnxnLimitException to
make compile no warning
Key: ZOOKEEPER-3413
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3413
Project: ZooKeeper
Issue Type: Improvement
Components: java client
Affects Versions: 3.6.0
Reporter: maoling
build-generated:
[javac] Compiling 2 source files to
/Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
compile:
[javac] Compiling 49 source files to
/Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
[javac]
/Users/wenba/workspaces/workspace_zookeeper/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/ClientCnxnLimitException.java:24:
警告: [serial] 可序列化类ClientCnxnLimitException没有 serialVersionUID 的定义
[javac] public class ClientCnxnLimitException extends Exception {
[javac] ^
[javac] 1 个警告
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-3322) ./zkServer.sh status failed when reconfig don't write the clientPort into the zoo.cfg
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
maoling resolved ZOOKEEPER-3322.
Resolution: Implemented
> ./zkServer.sh status failed when reconfig don't write the clientPort into the
> zoo.cfg
> -
>
> Key: ZOOKEEPER-3322
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3322
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>
> look at my zoo.cfg which don't have the clientPort value when using the
> reconfig.
> *cat ../conf/zoo.cfg*
> reconfigEnabled=true
> dataDir=../../zkdata2
> syncLimit=5
> dataLogDir=../../zkdataLog2
> initLimit=10
> tickTime=2000
> dynamicConfigFile=/data/software/zookeeper/zookeeper-test2/conf/zoo.cfg.dynamic.1f
> but look at the cmd:"./zkServer.sh status"，it needs this clientPort value
> STAT=`"$JAVA" "-Dzookeeper.log.dir=${ZOO_LOG_DIR}"
> "-Dzookeeper.root.logger=${ZOO_LOG4J_PROP}"
> "-Dzookeeper.log.file=${ZOO_LOG_FILE}" \
> -cp "$CLASSPATH" $JVMFLAGS org.apache.zookeeper.client.FourLetterWordMain \
> $clientPortAddress $clientPort srvr 2> /dev/null \
> otw, ./zkServer.sh status will fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3322) ./zkServer.sh status failed when reconfig don't write the clientPort into the zoo.cfg
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856380#comment-16856380
]
maoling commented on ZOOKEEPER-3322:
this issue had been solved by the master branch by parsing the clientPort in
the *zkServer.sh*
{code:java}
echo "Usage: $0 [--config ]
{start|start-foreground|stop|restart|status|print-cmd}" >&2
esac*)
echo "Usage: $0 [--config ]
{start|start-foreground|stop|restart|status|print-cmd}" >&2
esac
dynamicConfigFile=`$GREP "^[[:space:]]*dynamicConfigFile" "$ZOOCFG" | sed -e
's/.*=//'`
clientPortAndAddress=`$GREP "^[[:space:]]*server.$myid=.*;.*"
"$dynamicConfigFile" | sed -e 's/.*=//' | sed -e 's/.*;//'`
fi
if [ ! "$clientPortAndAddress" ] ; then
echo "Client port not found. Terminating."
exit 1
fi
if [[ "$clientPortAndAddress" =~ ^.*:[0-9]+ ]] ; then
clientPortAddress=`echo "$clientPortAndAddress" | sed -e 's/:.*//'`
fi
clientPort=`echo "$clientPortAndAddress" | sed -e 's/.*://'`
if [ ! "$clientPort" ] ; then
echo "Client port not found. Terminating."
exit 1
fi
fi
echo "Client port found: $clientPort. Client address: $clientPortAddress."
STAT=`"$JAVA" "-Dzookeeper.log.dir=${ZOO_LOG_DIR}"
"-Dzookeeper.root.logger=${ZOO_LOG4J_PROP}"
"-Dzookeeper.log.file=${ZOO_LOG_FILE}" \
-cp "$CLASSPATH" $JVMFLAGS org.apache.zookeeper.client.FourLetterWordMain \
$clientPortAddress $clientPort srvr 2> /dev/null \
| $GREP Mode`
if [ "x$STAT" = "x" ]
then
echo "Error contacting service. It is probably not running."
exit 1
else
echo $STAT
exit 0
fi{code}
> ./zkServer.sh status failed when reconfig don't write the clientPort into the
> zoo.cfg
> -
>
> Key: ZOOKEEPER-3322
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3322
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>
> look at my zoo.cfg which don't have the clientPort value when using the
> reconfig.
> *cat ../conf/zoo.cfg*
> reconfigEnabled=true
> dataDir=../../zkdata2
> syncLimit=5
> dataLogDir=../../zkdataLog2
> initLimit=10
> tickTime=2000
> dynamicConfigFile=/data/software/zookeeper/zookeeper-test2/conf/zoo.cfg.dynamic.1f
> but look at the cmd:"./zkServer.sh status"，it needs this clientPort value
> STAT=`"$JAVA" "-Dzookeeper.log.dir=${ZOO_LOG_DIR}"
> "-Dzookeeper.root.logger=${ZOO_LOG4J_PROP}"
> "-Dzookeeper.log.file=${ZOO_LOG_FILE}" \
> -cp "$CLASSPATH" $JVMFLAGS org.apache.zookeeper.client.FourLetterWordMain \
> $clientPortAddress $clientPort srvr 2> /dev/null \
> otw, ./zkServer.sh status will fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
