[jira] [Comment Edited] (ZOOKEEPER-2938) Server is unable to join quorum after connection broken to other peers

2019-06-11 Thread Sebastian Schmitz (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861638#comment-16861638
 ] 

Sebastian Schmitz edited comment on ZOOKEEPER-2938 at 6/12/19 12:51 AM:


Hey guys,

I'm running Zookeeper 3.5.5 with Kafka 2.2.1 in my Dev-Environment and got 
exactly this problem there.

And as stated above, restarting the leader fixed it. So upgrading to 3.5.5 
unfortunately doesn't fix the problem

 Logs from all nodes with restart of node2, which was the leader:
{code:java}
node 1 (not leader)
2019-06-12 00:37:51,904 [myid:1] - INFO 
[QuorumPeer[myid=1](plain=/0.0.0.0:2181)(secure=disabled):QuorumCnxManager@430] 
- Have smaller server identifier, so dropping the connection: (3, 1)
2019-06-12 00:37:51,904 [myid:1] - INFO 
[QuorumPeer[myid=1](plain=/0.0.0.0:2181)(secure=disabled):FastLeaderElection@919]
 - Notification time out: 3200
2019-06-12 00:37:55,108 [myid:1] - INFO 
[QuorumPeer[myid=1](plain=/0.0.0.0:2181)(secure=disabled):QuorumCnxManager@430] 
- Have smaller server identifier, so dropping the connection: (2, 1)
2019-06-12 00:37:55,113 [myid:1] - INFO 
[QuorumPeer[myid=1](plain=/0.0.0.0:2181)(secure=disabled):QuorumCnxManager@430] 
- Have smaller server identifier, so dropping the connection: (3, 1)
2019-06-12 00:37:55,113 [myid:1] - INFO 
[QuorumPeer[myid=1](plain=/0.0.0.0:2181)(secure=disabled):FastLeaderElection@919]
 - Notification time out: 6400
2019-06-12 00:38:01,516 [myid:1] - INFO 
[QuorumPeer[myid=1](plain=/0.0.0.0:2181)(secure=disabled):QuorumCnxManager@430] 
- Have smaller server identifier, so dropping the connection: (2, 1)
2019-06-12 00:38:01,521 [myid:1] - INFO 
[QuorumPeer[myid=1](plain=/0.0.0.0:2181)(secure=disabled):QuorumCnxManager@430] 
- Have smaller server identifier, so dropping the connection: (3, 1)
2019-06-12 00:38:01,521 [myid:1] - INFO 
[QuorumPeer[myid=1](plain=/0.0.0.0:2181)(secure=disabled):FastLeaderElection@919]
 - Notification time out: 12800
2019-06-12 00:38:14,324 [myid:1] - INFO 
[QuorumPeer[myid=1](plain=/0.0.0.0:2181)(secure=disabled):QuorumCnxManager@430] 
- Have smaller server identifier, so dropping the connection: (2, 1)
2019-06-12 00:38:14,327 [myid:1] - INFO 
[QuorumPeer[myid=1](plain=/0.0.0.0:2181)(secure=disabled):QuorumCnxManager@430] 
- Have smaller server identifier, so dropping the connection: (3, 1)
2019-06-12 00:38:14,327 [myid:1] - INFO 
[QuorumPeer[myid=1](plain=/0.0.0.0:2181)(secure=disabled):FastLeaderElection@919]
 - Notification time out: 25600
2019-06-12 00:38:39,935 [myid:1] - INFO 
[QuorumPeer[myid=1](plain=/0.0.0.0:2181)(secure=disabled):QuorumCnxManager@430] 
- Have smaller server identifier, so dropping the connection: (2, 1)
2019-06-12 00:38:40,126 [myid:1] - INFO 
[QuorumPeer[myid=1](plain=/0.0.0.0:2181)(secure=disabled):QuorumCnxManager@430] 
- Have smaller server identifier, so dropping the connection: (3, 1)
2019-06-12 00:38:40,126 [myid:1] - INFO 
[QuorumPeer[myid=1](plain=/0.0.0.0:2181)(secure=disabled):FastLeaderElection@919]
 - Notification time out: 51200
2019-06-12 00:39:31,544 [myid:1] - INFO 
[QuorumPeer[myid=1](plain=/0.0.0.0:2181)(secure=disabled):QuorumCnxManager@430] 
- Have smaller server identifier, so dropping the connection: (2, 1)
2019-06-12 00:39:31,786 [myid:1] - INFO 
[QuorumPeer[myid=1](plain=/0.0.0.0:2181)(secure=disabled):QuorumCnxManager@430] 
- Have smaller server identifier, so dropping the connection: (3, 1)
2019-06-12 00:39:31,786 [myid:1] - INFO 
[QuorumPeer[myid=1](plain=/0.0.0.0:2181)(secure=disabled):FastLeaderElection@919]
 - Notification time out: 6
2019-06-12 00:39:46,639 [myid:1] - WARN [NIOWorkerThread-1:NIOServerCnxn@370] - 
Exception causing close of session 0x0: ZooKeeperServer not running
2019-06-12 00:39:46,639 [myid:1] - WARN [NIOWorkerThread-2:NIOServerCnxn@370] - 
Exception causing close of session 0x0: ZooKeeperServer not running
2019-06-12 00:39:47,259 [myid:1] - WARN [NIOWorkerThread-3:NIOServerCnxn@370] - 
Exception causing close of session 0x0: ZooKeeperServer not running
2019-06-12 00:39:48,756 [myid:1] - WARN [NIOWorkerThread-4:NIOServerCnxn@370] - 
Exception causing close of session 0x0: ZooKeeperServer not running
2019-06-12 00:39:50,105 [myid:1] - WARN [NIOWorkerThread-1:NIOServerCnxn@370] - 
Exception causing close of session 0x0: ZooKeeperServer not running
2019-06-12 00:39:50,620 [myid:1] - WARN [NIOWorkerThread-2:NIOServerCnxn@370] - 
Exception causing close of session 0x0: ZooKeeperServer not running
2019-06-12 00:39:51,638 [myid:1] - WARN [NIOWorkerThread-3:NIOServerCnxn@370] - 
Exception causing close of session 0x0: ZooKeeperServer not running
2019-06-12 00:39:53,116 [myid:1] - WARN [NIOWorkerThread-4:NIOServerCnxn@370] - 
Exception causing close of session 0x0: ZooKeeperServer not running
2019-06-12 00:39:53,203 [myid:1] - WARN [NIOWorkerThread-1:NIOServerCnxn@370] - 
Exception causing close of session 0x0

[jira] [Commented] (ZOOKEEPER-2938) Server is unable to join quorum after connection broken to other peers

2019-06-11 Thread Sebastian Schmitz (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861638#comment-16861638
 ] 

Sebastian Schmitz commented on ZOOKEEPER-2938:
--

Hey guys,

I'm running Zookeeper 3.5.5 with Kafka 2.2.1 in my Dev-Environment and got 
exactly this problem there.

And as stated above, restarting the leader fixed it. So upgrading to 3.5.5 
unfortunately doesn't fix the problem

 

> Server is unable to join quorum after connection broken to other peers
> --
>
> Key: ZOOKEEPER-2938
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2938
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.6
>Reporter: Abhay Bothra
>Priority: Major
>
> We see the following logs in the node with {{myid: 1}}
> {code}
> 2017-11-08 15:06:28,375 [myid:1] - INFO  
> [WorkerSender[myid=1]:QuorumCnxManager@193] - Have smaller server identifier, 
> so dropping the connection: (2, 1)
> 2017-11-08 15:06:28,375 [myid:1] - INFO  
> [WorkerSender[myid=1]:QuorumCnxManager@193] - Have smaller server identifier, 
> so dropping the connection: (3, 1)
> 2017-11-08 15:07:28,375 [myid:1] - INFO  
> [WorkerReceiver[myid=1]:FastLeaderElection@597] - Notification: 1 (message 
> format version), 1 (n.leader), 0x28e000a8750 (n.zxid), 0x1 (n.round), LOOKING 
> (n.state), 1 (n.sid), 0x28e (n.peerEpoch) LOOKING (my state)
> 2017-11-08 15:07:28,375 [myid:1] - INFO  
> [WorkerSender[myid=1]:QuorumCnxManager@193] - Have smaller server identifier, 
> so dropping the connection: (2, 1)
> 2017-11-08 15:07:28,376 [myid:1] - INFO  
> [WorkerSender[myid=1]:QuorumCnxManager@193] - Have smaller server identifier, 
> so dropping the connection: (3, 1)
> 2017-11-08 15:08:28,375 [myid:1] - INFO  
> [WorkerReceiver[myid=1]:FastLeaderElection@597] - Notification: 1 (message 
> format version), 1 (n.leader), 0x28e000a8750 (n.zxid), 0x1 (n.round), LOOKING 
> (n.state), 1 (n.sid), 0x28e (n.peerEpoch) LOOKING (my state)
> 2017-11-08 15:08:28,376 [myid:1] - INFO  
> [WorkerSender[myid=1]:QuorumCnxManager@193] - Have smaller server identifier, 
> so dropping the connection: (2, 1)
> 2017-11-08 15:08:28,376 [myid:1] - INFO  
> [WorkerSender[myid=1]:QuorumCnxManager@193] - Have smaller server identifier, 
> so dropping the connection: (3, 1)
> 2017-11-08 15:09:28,376 [myid:1] - INFO  
> [WorkerReceiver[myid=1]:FastLeaderElection@597] - Notification: 1 (message 
> format version), 1 (n.leader), 0x28e000a8750 (n.zxid), 0x1 (n.round), LOOKING 
> (n.state), 1 (n.sid), 0x28e (n.peerEpoch) LOOKING (my state)
> 2017-11-08 15:09:28,376 [myid:1] - INFO  
> [WorkerSender[myid=1]:QuorumCnxManager@193] - Have smaller server identifier, 
> so dropping the connection: (2, 1)
> 2017-11-08 15:09:28,376 [myid:1] - INFO  
> [WorkerSender[myid=1]:QuorumCnxManager@193] - Have smaller server identifier, 
> so dropping the connection: (3, 1)
> 2017-11-08 15:10:28,376 [myid:1] - INFO  
> [WorkerReceiver[myid=1]:FastLeaderElection@597] - Notification: 1 (message 
> format version), 1 (n.leader), 0x28e000a8750 (n.zxid), 0x1 (n.round), LOOKING 
> (n.state), 1 (n.sid), 0x28e (n.peerEpoch) LOOKING (my state)
> 2017-11-08 15:10:28,376 [myid:1] - INFO  
> [WorkerSender[myid=1]:QuorumCnxManager@193] - Have smaller server identifier, 
> so dropping the connection: (2, 1)
> 2017-11-08 15:10:28,377 [myid:1] - INFO  
> [WorkerSender[myid=1]:QuorumCnxManager@193] - Have smaller server identifier, 
> so dropping the connection: (3, 1)
> {code}
> On the nodes with {{myid: 2}} and {{myid: 3}}, we see connection broken 
> events for {{myid: 1}}
> {code}
> 2017-11-07 02:54:32,135 [myid:2] - WARN  
> [RecvWorker:1:QuorumCnxManager$RecvWorker@780] - Connection broken for id 1, 
> my id = 2, error =
> java.net.SocketException: Connection reset
> at java.net.SocketInputStream.read(SocketInputStream.java:209)
> at java.net.SocketInputStream.read(SocketInputStream.java:141)
> at java.net.SocketInputStream.read(SocketInputStream.java:223)
> at java.io.DataInputStream.readInt(DataInputStream.java:387)
> at 
> org.apache.zookeeper.server.quorum.QuorumCnxManager$RecvWorker.run(QuorumCnxManager.java:765)
> 2017-11-07 02:54:32,135 [myid:2] - WARN  
> [RecvWorker:1:QuorumCnxManager$RecvWorker@783] - Interrupting SendWorker
> 2017-11-07 02:54:32,135 [myid:2] - WARN  
> [SendWorker:1:QuorumCnxManager$SendWorker@697] - Interrupted while waiting 
> for message on queue
> java.lang.InterruptedException
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.reportInterruptAfterWait(AbstractQueuedSynchronizer.java:2014)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2088)
> at 
> java.util.con

[jira] [Updated] (ZOOKEEPER-3427) Introduce SnapshotComparer that assists debugging with snapshots.

2019-06-11 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3427:
--
Labels: pull-request-available  (was: )

> Introduce SnapshotComparer that assists debugging with snapshots.
> -
>
> Key: ZOOKEEPER-3427
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3427
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.6.0
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Major
>  Labels: pull-request-available
>
> SnapshotComparer is a tool that loads and compares two snapshots, with 
> configurable threshold and various filters. It's useful in use cases that 
> involve snapshot analysis, such as offline data consistency checking, and 
> data trending analysis (e.g. what's growing under which zNode path during 
> when). 
> A sample output of the tool (actual numbers removed, due to sensitivity).
> {code:java}
> Successfully parsed options!
> Deserialized snapshot in snapshot.0 in  seconds
> Processed data tree in seconds
> Deserialized snapshot in snapshot.1 in  seconds
> Processed data tree in seconds
> Node count: 
> Total size: 
> Max depth: 
> Count of nodes at depth 1: 
> Count of nodes at depth 2: 
> Count of nodes at depth 3: 
> Count of nodes at depth 4: 
> Count of nodes at depth 5: 
> Count of nodes at depth 6: 
> Count of nodes at depth 7: 
> Count of nodes at depth 8: 
> Count of nodes at depth 9: 
> Count of nodes at depth 10: 
> Count of nodes at depth 11: 
> Node count: 
> Total size: 
> Max depth: 
> Count of nodes at depth 1: 
> Count of nodes at depth 2: 
> Count of nodes at depth 3: 
> Count of nodes at depth 4: 
> Count of nodes at depth 5:
> Count of nodes at depth 6:
> Count of nodes at depth 7: 
> Count of nodes at depth 8: 
> Count of nodes at depth 9: 
> Count of nodes at depth 10: 
> Count of nodes at depth 11: 
> Analysis for depth 0
> Analysis for depth 1
> Analysis for depth 2
> Analysis for depth 3
> Analysis for depth 4
> Analysis for depth 5
> Analysis for depth 6
> Analysis for depth 7
> Analysis for depth 8
> Analysis for depth 9
> Analysis for depth 10
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZOOKEEPER-3427) Introduce SnapshotComparer that assists debugging with snapshots.

2019-06-11 Thread Michael Han (JIRA)
Michael Han created ZOOKEEPER-3427:
--

 Summary: Introduce SnapshotComparer that assists debugging with 
snapshots.
 Key: ZOOKEEPER-3427
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3427
 Project: ZooKeeper
  Issue Type: Improvement
  Components: server
Affects Versions: 3.6.0
Reporter: Michael Han
Assignee: Michael Han


SnapshotComparer is a tool that loads and compares two snapshots, with 
configurable threshold and various filters. It's useful in use cases that 
involve snapshot analysis, such as offline data consistency checking, and data 
trending analysis (e.g. what's growing under which zNode path during when). 

A sample output of the tool (actual numbers removed, due to sensitivity).
{code:java}
Successfully parsed options!

Deserialized snapshot in snapshot.0 in  seconds

Processed data tree in seconds

Deserialized snapshot in snapshot.1 in  seconds

Processed data tree in seconds

Node count: 

Total size: 

Max depth: 

Count of nodes at depth 1: 

Count of nodes at depth 2: 

Count of nodes at depth 3: 

Count of nodes at depth 4: 

Count of nodes at depth 5: 

Count of nodes at depth 6: 

Count of nodes at depth 7: 

Count of nodes at depth 8: 

Count of nodes at depth 9: 

Count of nodes at depth 10: 

Count of nodes at depth 11: 


Node count: 

Total size: 

Max depth: 

Count of nodes at depth 1: 

Count of nodes at depth 2: 

Count of nodes at depth 3: 

Count of nodes at depth 4: 

Count of nodes at depth 5:

Count of nodes at depth 6:

Count of nodes at depth 7: 

Count of nodes at depth 8: 

Count of nodes at depth 9: 

Count of nodes at depth 10: 

Count of nodes at depth 11: 




Analysis for depth 0

Analysis for depth 1

Analysis for depth 2

Analysis for depth 3

Analysis for depth 4

Analysis for depth 5

Analysis for depth 6

Analysis for depth 7

Analysis for depth 8

Analysis for depth 9

Analysis for depth 10
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZOOKEEPER-3426) ZK prime_connection(the Handshake) can complete without reading all the payload.

2019-06-11 Thread Suhas Dantkale (JIRA)
Suhas Dantkale created ZOOKEEPER-3426:
-

 Summary: ZK prime_connection(the Handshake) can complete without 
reading all the payload.
 Key: ZOOKEEPER-3426
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3426
 Project: ZooKeeper
  Issue Type: Bug
  Components: c client
Reporter: Suhas Dantkale


/* returns:

 * -1 if recv call failed,

 * 0 if recv would block,

 * 1 if success

 */

static int recv_buffer(zhandle_t *zh, buffer_list_t *buff)

{

  int off = buff->curr_offset;

  int rc = 0;

[]

 if (buff == &zh->primer_buffer && rc == buff->len - 1) ++rc; <== Handshake 
prematurely complete.





On non-blocking socket, it's possible that socket has exactly "buff->len - 1" 
bytes to read.
Because of the above line, the Handshake is prematurely completed.
What this can lead to is:
There will be one outstanding byte left on the socket and it might go as part 
of next message which could get corrupted.

I think this can lead to ZRUNTIMEINCONSISTENCY issues later.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ZOOKEEPER-3391) Drop unused CSVInputArchive and XMLInputArchive

2019-06-11 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3391:
--
Labels: pull-request-available  (was: )

> Drop unused CSVInputArchive and XMLInputArchive
> ---
>
> Key: ZOOKEEPER-3391
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3391
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: jute
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
>  Labels: pull-request-available
>
> As described in
> http://zookeeper-user.578899.n2.nabble.com/Deprecated-CSVInputArchive-and-XMLInputArchive-td7584086.html
> these 2 input archives are not actively maintained and we probably don't have 
> test coverage for them either, so keeping them in the codebase could be 
> questionable.
> So this is the ticket to track dropping unused CSVInputArchive and 
> XMLInputArchive



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ZOOKEEPER-3391) Drop unused CSVInputArchive and XMLInputArchive

2019-06-11 Thread TisonKun (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

TisonKun reassigned ZOOKEEPER-3391:
---

Assignee: TisonKun

> Drop unused CSVInputArchive and XMLInputArchive
> ---
>
> Key: ZOOKEEPER-3391
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3391
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: jute
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
>
> As described in
> http://zookeeper-user.578899.n2.nabble.com/Deprecated-CSVInputArchive-and-XMLInputArchive-td7584086.html
> these 2 input archives are not actively maintained and we probably don't have 
> test coverage for them either, so keeping them in the codebase could be 
> questionable.
> So this is the ticket to track dropping unused CSVInputArchive and 
> XMLInputArchive



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZOOKEEPER-3425) ttl node should not have the children

2019-06-11 Thread maoling (JIRA)
maoling created ZOOKEEPER-3425:
--

 Summary: ttl node should not have the children
 Key: ZOOKEEPER-3425
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3425
 Project: ZooKeeper
  Issue Type: Improvement
  Components: server
Reporter: maoling
Assignee: maoling
 Fix For: 3.6.0


ttl node should not have the children



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZOOKEEPER-3424) download page file package broken

2019-06-11 Thread Wei Xin (JIRA)
Wei Xin created ZOOKEEPER-3424:
--

 Summary: download page file package broken
 Key: ZOOKEEPER-3424
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3424
 Project: ZooKeeper
  Issue Type: Bug
  Components: build
Affects Versions: 3.5.5
Reporter: Wei Xin






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Issue Comment Deleted] (ZOOKEEPER-3413) add a serialVersionUID for ClientCnxnLimitException to make compile no warning

2019-06-11 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3413:
---
Comment: was deleted

(was: [~eolivelli]

I cannot reproduce this issue anymore.this may be caused from ZOOKEEPER-3385: 
fix build break.)

> add a serialVersionUID for ClientCnxnLimitException to make compile no warning
> --
>
> Key: ZOOKEEPER-3413
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3413
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.6.0
>Reporter: maoling
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> build-generated:
>  [javac] Compiling 2 source files to 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
> compile:
>  [javac] Compiling 49 source files to 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
>  [javac] 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/ClientCnxnLimitException.java:24:
>  警告: [serial] 可序列化类ClientCnxnLimitException没有 serialVersionUID 的定义
>  [javac] public class ClientCnxnLimitException extends Exception {
>  [javac] ^
>  [javac] 1 个警告



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ZOOKEEPER-3413) add a serialVersionUID for ClientCnxnLimitException to make compile no warning

2019-06-11 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3413:
--
Labels: pull-request-available  (was: )

> add a serialVersionUID for ClientCnxnLimitException to make compile no warning
> --
>
> Key: ZOOKEEPER-3413
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3413
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.6.0
>Reporter: maoling
>Priority: Minor
>  Labels: pull-request-available
>
> build-generated:
>  [javac] Compiling 2 source files to 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
> compile:
>  [javac] Compiling 49 source files to 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
>  [javac] 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/ClientCnxnLimitException.java:24:
>  警告: [serial] 可序列化类ClientCnxnLimitException没有 serialVersionUID 的定义
>  [javac] public class ClientCnxnLimitException extends Exception {
>  [javac] ^
>  [javac] 1 个警告



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (ZOOKEEPER-3413) add a serialVersionUID for ClientCnxnLimitException to make compile no warning

2019-06-11 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling reopened ZOOKEEPER-3413:


> add a serialVersionUID for ClientCnxnLimitException to make compile no warning
> --
>
> Key: ZOOKEEPER-3413
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3413
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.6.0
>Reporter: maoling
>Priority: Minor
>
> build-generated:
>  [javac] Compiling 2 source files to 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
> compile:
>  [javac] Compiling 49 source files to 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
>  [javac] 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/ClientCnxnLimitException.java:24:
>  警告: [serial] 可序列化类ClientCnxnLimitException没有 serialVersionUID 的定义
>  [javac] public class ClientCnxnLimitException extends Exception {
>  [javac] ^
>  [javac] 1 个警告



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ZOOKEEPER-3413) add a serialVersionUID for ClientCnxnLimitException to make compile no warning

2019-06-11 Thread maoling (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860644#comment-16860644
 ] 

maoling commented on ZOOKEEPER-3413:


I found this:

[https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/3985/artifact/patchprocess/trunkJavacWarnings.txt]

> add a serialVersionUID for ClientCnxnLimitException to make compile no warning
> --
>
> Key: ZOOKEEPER-3413
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3413
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.6.0
>Reporter: maoling
>Priority: Minor
>
> build-generated:
>  [javac] Compiling 2 source files to 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
> compile:
>  [javac] Compiling 49 source files to 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/build/classes
>  [javac] 
> /Users/wenba/workspaces/workspace_zookeeper/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/ClientCnxnLimitException.java:24:
>  警告: [serial] 可序列化类ClientCnxnLimitException没有 serialVersionUID 的定义
>  [javac] public class ClientCnxnLimitException extends Exception {
>  [javac] ^
>  [javac] 1 个警告



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ZOOKEEPER-3301) Enforce the quota limit

2019-06-11 Thread maoling (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling reassigned ZOOKEEPER-3301:
--

Assignee: maoling

> Enforce the quota limit
> ---
>
> Key: ZOOKEEPER-3301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3301
> Project: ZooKeeper
>  Issue Type: Sub-task
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>
> We need a complete quota feature, not just the printing the warning logs 
> which is a bit chicken ribs.
> [zk: localhost:2181(CONNECTED) 18] setquota -n 2 /quota_test
> [zk: localhost:2181(CONNECTED) 19] create /quota_test/child_1
> Created /quota_test/child_1
> [zk: localhost:2181(CONNECTED) 20] create /quota_test/child_2
> Created /quota_test/child_2
> [zk: localhost:2181(CONNECTED) 21] create /quota_test/child_3
> Created /quota_test/child_3
> look at the following logs:
> 2019-03-07 11:22:36,680 [myid:1] - WARN [SyncThread:0:DataTree@374] - Quota 
> exceeded: /quota_test count=3 limit=2
> 2019-03-07 11:22:41,861 [myid:1] - WARN [SyncThread:0:DataTree@374] - Quota 
> exceeded: /quota_test count=4 limit=2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)