[jira] [Commented] (ZOOKEEPER-3440) Fix Apache RAT check by excluding binary files (images)
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875349#comment-16875349
]
Hudson commented on ZOOKEEPER-3440:
---
SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #426 (See
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/426/])
ZOOKEEPER-3440: Fix Apache RAT check by excluding binary files (images) (hanm:
rev 1e6edc9229c418b8bea46ccc5d603ea1c4a47a9e)
* (edit) pom.xml
* (edit) .travis.yml
> Fix Apache RAT check by excluding binary files (images)
> ---
>
> Key: ZOOKEEPER-3440
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3440
> Project: ZooKeeper
> Issue Type: Bug
> Components: build, documentation
>Affects Versions: 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Critical
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> I see this error on Jenkins as we are missing the exclusion for the images of
> the docs.
> {code:java}
> Unapproved licenses:
>
> /home/jenkins/jenkins-slave/workspace/zookeeper-master-maven/zookeeper-docs/src/main/resources/markdown/images/state_dia.dia
> {code}
> We should also add this check to the precommit job on Travis (this will be
> part of the commit) and on CI (this is a manual configuration, to be done
> after fixing this issue)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3421) Better insight into Observer connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875348#comment-16875348 ] Hudson commented on ZOOKEEPER-3421: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #426 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/426/]) ZOOKEEPER-3421: Better insight into Observer connections (hanm: rev 02c203fa486ac24553d9584768fe97960b6dec24) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Follower.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/admin/CommandsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ObserverMaster.java > Better insight into Observer connections > > > Key: ZOOKEEPER-3421 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3421 > Project: ZooKeeper > Issue Type: Wish > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > With the introduction of the Learner Master feature in ZOOKEEPER-3140, > tracking the state of the Observers synced with the voting quorum became more > difficult from an operational perspective. Observers could now be synced with > any voting member and not just the leader and to discover where an observer > was being hosted required digging in to the server logs or complex jmx > queries. > > Add commands that externalize the state of observers from the point of view > of the voting quorum. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3440) Fix Apache RAT check by excluding binary files (images)
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875332#comment-16875332
]
Hudson commented on ZOOKEEPER-3440:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #592 (See
[https://builds.apache.org/job/ZooKeeper-trunk/592/])
ZOOKEEPER-3440: Fix Apache RAT check by excluding binary files (images) (hanm:
rev 1e6edc9229c418b8bea46ccc5d603ea1c4a47a9e)
* (edit) .travis.yml
* (edit) pom.xml
> Fix Apache RAT check by excluding binary files (images)
> ---
>
> Key: ZOOKEEPER-3440
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3440
> Project: ZooKeeper
> Issue Type: Bug
> Components: build, documentation
>Affects Versions: 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Critical
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> I see this error on Jenkins as we are missing the exclusion for the images of
> the docs.
> {code:java}
> Unapproved licenses:
>
> /home/jenkins/jenkins-slave/workspace/zookeeper-master-maven/zookeeper-docs/src/main/resources/markdown/images/state_dia.dia
> {code}
> We should also add this check to the precommit job on Travis (this will be
> part of the commit) and on CI (this is a manual configuration, to be done
> after fixing this issue)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3421) Better insight into Observer connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875331#comment-16875331 ] Hudson commented on ZOOKEEPER-3421: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #592 (See [https://builds.apache.org/job/ZooKeeper-trunk/592/]) ZOOKEEPER-3421: Better insight into Observer connections (hanm: rev 02c203fa486ac24553d9584768fe97960b6dec24) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ObserverMaster.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/admin/CommandsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Follower.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java > Better insight into Observer connections > > > Key: ZOOKEEPER-3421 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3421 > Project: ZooKeeper > Issue Type: Wish > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > With the introduction of the Learner Master feature in ZOOKEEPER-3140, > tracking the state of the Observers synced with the voting quorum became more > difficult from an operational perspective. Observers could now be synced with > any voting member and not just the leader and to discover where an observer > was being hosted required digging in to the server logs or complex jmx > queries. > > Add commands that externalize the state of observers from the point of view > of the voting quorum. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ZOOKEEPER-2418) txnlog diff sync can skip sending some transactions to followers
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han reassigned ZOOKEEPER-2418: -- Assignee: Brian Nixon (was: Nicholas Wolchko) > txnlog diff sync can skip sending some transactions to followers > > > Key: ZOOKEEPER-2418 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2418 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.1 >Reporter: Nicholas Wolchko >Assignee: Brian Nixon >Priority: Critical > Labels: pull-request-available > Original Estimate: 168h > Time Spent: 50m > Remaining Estimate: 167h 10m > > If the leader is having disk issues so that its on disk txnlog is behind the > in memory commit log, it will send a DIFF that is missing the transactions in > between the two. > Example: > There are 5 hosts in the cluster. 1 is the leader. 5 is disconnected. > We commit up to zxid 1000. > At zxid 450, the leader's disk stalls, but we still commit transactions > because 2,3,4 are up and acking writes. > At zxid 1000, the txnlog on the leader has 1-450 and the commit log has > 500-1000. > Then host 5 regains its connection to the cluster and syncs with the leader. > It will receive a DIFF containing zxids 1-450 and 500-1000. > This is because queueCommittedProposals in the LearnerHandler just queues > everything within its zxid range. It doesn't give an error if there is a gap > between peerLastZxid and the iterator it is queueing from. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-3440) Fix Apache RAT check by excluding binary files (images)
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han resolved ZOOKEEPER-3440.
Resolution: Fixed
Issue resolved by pull request 998
[https://github.com/apache/zookeeper/pull/998]
> Fix Apache RAT check by excluding binary files (images)
> ---
>
> Key: ZOOKEEPER-3440
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3440
> Project: ZooKeeper
> Issue Type: Bug
> Components: build, documentation
>Affects Versions: 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Critical
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I see this error on Jenkins as we are missing the exclusion for the images of
> the docs.
> {code:java}
> Unapproved licenses:
>
> /home/jenkins/jenkins-slave/workspace/zookeeper-master-maven/zookeeper-docs/src/main/resources/markdown/images/state_dia.dia
> {code}
> We should also add this check to the precommit job on Travis (this will be
> part of the commit) and on CI (this is a manual configuration, to be done
> after fixing this issue)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-3421) Better insight into Observer connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-3421. Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 978 [https://github.com/apache/zookeeper/pull/978] > Better insight into Observer connections > > > Key: ZOOKEEPER-3421 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3421 > Project: ZooKeeper > Issue Type: Wish > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > With the introduction of the Learner Master feature in ZOOKEEPER-3140, > tracking the state of the Observers synced with the voting quorum became more > difficult from an operational perspective. Observers could now be synced with > any voting member and not just the leader and to discover where an observer > was being hosted required digging in to the server logs or complex jmx > queries. > > Add commands that externalize the state of observers from the point of view > of the voting quorum. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3448) Introduce MessageTracker to assist debug leader and leaner connectivity issues
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3448: -- Labels: Twitter pull-request-available (was: Twitter) > Introduce MessageTracker to assist debug leader and leaner connectivity issues > -- > > Key: ZOOKEEPER-3448 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3448 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Michael Han >Assignee: Michael Han >Priority: Major > Labels: Twitter, pull-request-available > > We want to have better insight on the state of the world when learners lost > connection with leader, so we need capture more information when that > happens. We capture more information through MessageTracker which will record > the last few sent and received messages at various protocol stage, and these > information will be dumped to log files for further analysis. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3448) Introduce MessageTracker to assist debug leader and leaner connectivity issues
Michael Han created ZOOKEEPER-3448: -- Summary: Introduce MessageTracker to assist debug leader and leaner connectivity issues Key: ZOOKEEPER-3448 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3448 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.6.0 Reporter: Michael Han Assignee: Michael Han We want to have better insight on the state of the world when learners lost connection with leader, so we need capture more information when that happens. We capture more information through MessageTracker which will record the last few sent and received messages at various protocol stage, and these information will be dumped to log files for further analysis. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-3445) Concurrency issue in ReferenceCountedACLCache
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Halterman resolved ZOOKEEPER-3445. --- Resolution: Invalid > Concurrency issue in ReferenceCountedACLCache > - > > Key: ZOOKEEPER-3445 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3445 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.5, 3.4.14 >Reporter: Jonathan Halterman >Priority: Critical > Labels: pull-request-available > Time Spent: 2.5h > Remaining Estimate: 0h > > While debugging some unexpected "ACL not available for long" exceptions we > were seeing, I noticed that ReferenceCountedACLCache does not mark aclIndex > as volatile, which it should since it appears to be read from multiple > threads. This may or may not be the cause of the behavior we're seeing, but > should be fixed regardless. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3440) Fix Apache RAT check by excluding binary files (images)
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874871#comment-16874871
]
Norbert Kalmar commented on ZOOKEEPER-3440:
---
This file is also available on 3.5, shouldn't this patch also go into 3.5
branch?
> Fix Apache RAT check by excluding binary files (images)
> ---
>
> Key: ZOOKEEPER-3440
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3440
> Project: ZooKeeper
> Issue Type: Bug
> Components: build, documentation
>Affects Versions: 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Critical
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I see this error on Jenkins as we are missing the exclusion for the images of
> the docs.
> {code:java}
> Unapproved licenses:
>
> /home/jenkins/jenkins-slave/workspace/zookeeper-master-maven/zookeeper-docs/src/main/resources/markdown/images/state_dia.dia
> {code}
> We should also add this check to the precommit job on Travis (this will be
> part of the commit) and on CI (this is a manual configuration, to be done
> after fixing this issue)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3447) add a doc: zookeeperMonitor.md
maoling created ZOOKEEPER-3447: -- Summary: add a doc: zookeeperMonitor.md Key: ZOOKEEPER-3447 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3447 Project: ZooKeeper Issue Type: New Feature Components: documentation Reporter: maoling Assignee: maoling Fix For: 3.6.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3400) Add documentation on local sessions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874854#comment-16874854 ] maoling commented on ZOOKEEPER-3400: I am working on working this doc.:D > Add documentation on local sessions > --- > > Key: ZOOKEEPER-3400 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3400 > Project: ZooKeeper > Issue Type: Improvement > Components: documentation >Affects Versions: 3.6.0, 3.5.6 >Reporter: Brian Nixon >Assignee: maoling >Priority: Major > > ZOOKEEPER-1147 added local sessions (client sessions not ratified by the > leader) to ZooKeeper as a lightweight augmentation of the existing global > sessions. > > Add some outward facing documentation that describes this feature > ([https://zookeeper.apache.org/doc/r3.5.5/zookeeperProgrammers.html#ch_zkSessions] > seems like a reasonable place). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3445) Concurrency issue in ReferenceCountedACLCache
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874833#comment-16874833 ] Norbert Kalmar commented on ZOOKEEPER-3445: --- Thanks for reporting this. As discussed on the PR, aclIndex is guarded by a lock. Only synchronized blocks access the variable. > Concurrency issue in ReferenceCountedACLCache > - > > Key: ZOOKEEPER-3445 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3445 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.5, 3.4.14 >Reporter: Jonathan Halterman >Priority: Critical > Labels: pull-request-available > Time Spent: 1h 40m > Remaining Estimate: 0h > > While debugging some unexpected "ACL not available for long" exceptions we > were seeing, I noticed that ReferenceCountedACLCache does not mark aclIndex > as volatile, which it should since it appears to be read from multiple > threads. This may or may not be the cause of the behavior we're seeing, but > should be fixed regardless. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
