[jira] [Updated] (ZOOKEEPER-3469) Checkstyle rules for ensure proper javadocs

2019-08-09 Thread TisonKun (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

TisonKun updated ZOOKEEPER-3469:

Summary: Checkstyle rules for ensure proper javadocs  (was: Enable 
checkEmptyJavadoc checkstyle rule)

> Checkstyle rules for ensure proper javadocs
> ---
>
> Key: ZOOKEEPER-3469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3469
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build
>Reporter: TisonKun
>Priority: Major
>
> While introducing BookKeeper checkstyle rules(see ZOOKEEPER-3431), we find it 
> worth to have a rule about javadocs of public classes. Specifically, check 
> the javadocs of public class not empty but valid.
> However, providing valid javadocs for public classes those do not have one at 
> the moment is not a trivial work. Thus we file this issue to track another 
> pass for doing so.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (ZOOKEEPER-3347) Improve PathTrie Consistency

2019-08-09 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904166#comment-16904166
 ] 

Hudson commented on ZOOKEEPER-3347:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #655 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/655/])
ZOOKEEPER-3347: Improve PathTrie Consistency (andor: rev 
04cc5cae1e7d4b007490e68109a676b88ce790a3)
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/PathTrieTest.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/common/PathTrie.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/DataTreeTest.java


> Improve PathTrie Consistency 
> -
>
> Key: ZOOKEEPER-3347
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3347
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> There is a bunch of synchronization that occurs in the {{PathTrie}}.  Each 
> node in the tree requires a lock to view its children, so to traverse a tree 
> that is 8 nodes deep, it is required to lock 8 different times.  Also, I'm 
> not really sure that the locking is consistent; a node deep in the tree can 
> be negatively impacted by another thread deleting the node's parent at the 
> same time.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (ZOOKEEPER-3347) Improve PathTrie Consistency

2019-08-09 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904158#comment-16904158
 ] 

Hudson commented on ZOOKEEPER-3347:
---

ABORTED: Integrated in Jenkins build Zookeeper-trunk-single-thread #490 (See 
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/490/])
ZOOKEEPER-3347: Improve PathTrie Consistency (andor: rev 
04cc5cae1e7d4b007490e68109a676b88ce790a3)
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/DataTreeTest.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/PathTrieTest.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/common/PathTrie.java


> Improve PathTrie Consistency 
> -
>
> Key: ZOOKEEPER-3347
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3347
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> There is a bunch of synchronization that occurs in the {{PathTrie}}.  Each 
> node in the tree requires a lock to view its children, so to traverse a tree 
> that is 8 nodes deep, it is required to lock 8 different times.  Also, I'm 
> not really sure that the locking is consistent; a node deep in the tree can 
> be negatively impacted by another thread deleting the node's parent at the 
> same time.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Created] (ZOOKEEPER-3501) unify the method:op2String()

2019-08-09 Thread maoling (JIRA) 
maoling created ZOOKEEPER-3501:
--

 Summary: unify the method:op2String()
 Key: ZOOKEEPER-3501
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3501
 Project: ZooKeeper
  Issue Type: Improvement
  Components: server
Reporter: maoling
 Fix For: 3.6.0


there were two duplicated method

*public static String op2String(int op)*

in the code base:

 
{code:java}
org.apache.zookeeper.server.TraceFormatter#op2String
org.apache.zookeeper.server.Request#op2String
{code}
 

and they are inconsistency, we should unify it and remain only one

 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)