[jira] [Commented] (ZOOKEEPER-4287) Upgrade prometheus client library version to 0.10.0

[Li Wang (Jira)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337541#comment-17337541
 ] 

Li Wang commented on ZOOKEEPER-4287:


Please note Prometheus switched to OpenMetrics data model in 0.10.0 release, 
which introduces the following changes

1. all Counter samples now have a _total suffix
2. Counter, Summary, and Histogram metrics now expose a _created sample with 
when their child was created

More details can be found in the Prometheus change logs 
https://github.com/prometheus/client_java/releases

This means that the downstream processing dashboard/alerts may need to make the 
change accordingly when upgrading ZK version.

> Upgrade prometheus client library version to 0.10.0
> ---
>
> Key: ZOOKEEPER-4287
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4287
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 3.7.0, 3.8.0
>Reporter: Li Wang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.7
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Upgrade the client library version to the latest to help investigating the 
> Prometheus impact issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ZOOKEEPER-4287) Upgrade prometheus client library version to 0.10.0

[Li Wang (Jira)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335057#comment-17335057
 ] 

Li Wang commented on ZOOKEEPER-4287:


PR submitted. https://github.com/apache/zookeeper/pull/1688

[~eolivelli] can you please review PR, so we can test ZK with latest Prometheus 
client to see if it makes any difference  in terms of perf impact?

We are testing the Zookeeper 3.7, so the changes need to go to both master and 
3.7 branches




> Upgrade prometheus client library version to 0.10.0
> ---
>
> Key: ZOOKEEPER-4287
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4287
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 3.7.0, 3.8.0
>Reporter: Li Wang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.7
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Upgrade the client library version to the latest to help investigating the 
> Prometheus impact issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)