[jira] [Commented] (IMPALA-10111) TestWebPage::test_query_stmt is flaky
[
https://issues.apache.org/jira/browse/IMPALA-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694654#comment-17694654
]
ASF subversion and git services commented on IMPALA-10111:
--
Commit 2ae0e4139c2a9cd07e32bae29a256ecc8f8424c0 in impala's branch
refs/heads/master from Gergely Fürnstáhl
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=2ae0e4139 ]
IMPALA-10111: Fix TestWebPage::test_query_stmt flakiness
A query might be logged in "in_flight_queries" even though it has
already finished. Earlier the test only looked for the executed query
in "completed_queries", after this commit it will look in both lists.
Moreover, removed unnecessary duplicated execution of the query and
added formatting to dumped response to ease debugging in the future.
Testing:
- Locally reproducible for the first test run after starting the
cluster.
- Verified that the query is found in in_flight_queries too and the
test passes in this case.
Change-Id: If25d430a871415a3884dece772b8d8105c583c05
Reviewed-on: http://gerrit.cloudera.org:8080/19524
Reviewed-by: Impala Public Jenkins
Tested-by: Impala Public Jenkins
> TestWebPage::test_query_stmt is flaky
> -
>
> Key: IMPALA-10111
> URL: https://issues.apache.org/jira/browse/IMPALA-10111
> Project: IMPALA
> Issue Type: Bug
>Reporter: Quanlong Huang
>Assignee: Tamas Mate
>Priority: Major
> Labels: broken-build, flaky
>
> Found in an unrelated patch:
> https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/3032/testReport/junit/webserver.test_web_pages/TestWebPage/test_query_stmt/
> {code:java}
> webserver/test_web_pages.py:418: in test_query_stmt
> assert check_if_contains, "No matching statement found in the jsons."
> E AssertionError: No matching statement found in the jsons.
> E assert False {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-10111) TestWebPage::test_query_stmt is flaky
[
https://issues.apache.org/jira/browse/IMPALA-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693511#comment-17693511
]
Riza Suminto commented on IMPALA-10111:
---
[~tmate] does it matter if the query statement being looked up is in
'completed_queries' or 'in_flight_queries'? Because it might still in flight
when the json page is being queried.
> TestWebPage::test_query_stmt is flaky
> -
>
> Key: IMPALA-10111
> URL: https://issues.apache.org/jira/browse/IMPALA-10111
> Project: IMPALA
> Issue Type: Bug
>Reporter: Quanlong Huang
>Assignee: Tamas Mate
>Priority: Major
> Labels: broken-build, flaky
>
> Found in an unrelated patch:
> https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/3032/testReport/junit/webserver.test_web_pages/TestWebPage/test_query_stmt/
> {code:java}
> webserver/test_web_pages.py:418: in test_query_stmt
> assert check_if_contains, "No matching statement found in the jsons."
> E AssertionError: No matching statement found in the jsons.
> E assert False {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-10111) TestWebPage::test_query_stmt is flaky
[
https://issues.apache.org/jira/browse/IMPALA-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526741#comment-17526741
]
ASF subversion and git services commented on IMPALA-10111:
--
Commit eef6eb077574b50c81510f303b90a3f69890db3c in impala's branch
refs/heads/master from Tamas Mate
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=eef6eb077 ]
IMPALA-10111: Improve TestWebPage::test_query_stmt logging
TestWebPage::test_query_stmt is flaky, to better understand the root
cause of this test failure this commit adds the web page JSON result
to the error message.
Testing:
- Executed the test locally.
Change-Id: Id7ddd04f72790440bba4546c48656c9fe68b4fd9
Reviewed-on: http://gerrit.cloudera.org:8080/18442
Reviewed-by: Wenzhe Zhou
Tested-by: Impala Public Jenkins
> TestWebPage::test_query_stmt is flaky
> -
>
> Key: IMPALA-10111
> URL: https://issues.apache.org/jira/browse/IMPALA-10111
> Project: IMPALA
> Issue Type: Bug
>Reporter: Quanlong Huang
>Assignee: Tamas Mate
>Priority: Major
> Labels: broken-build, flaky
>
> Found in an unrelated patch:
> https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/3032/testReport/junit/webserver.test_web_pages/TestWebPage/test_query_stmt/
> {code:java}
> webserver/test_web_pages.py:418: in test_query_stmt
> assert check_if_contains, "No matching statement found in the jsons."
> E AssertionError: No matching statement found in the jsons.
> E assert False {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-10111) TestWebPage::test_query_stmt is flaky
[
https://issues.apache.org/jira/browse/IMPALA-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526353#comment-17526353
]
Tamas Mate commented on IMPALA-10111:
-
This recurred 5 times this year, checked the logs of the latest failure but
nothing suspicious, the queries finished quite fast ~0.3 seconds. I think we
could print the json in case of a failure to better understand whether the
queries were in another state or aged out of the log. Created a CR for this:
[https://gerrit.cloudera.org/#/c/18442/]
> TestWebPage::test_query_stmt is flaky
> -
>
> Key: IMPALA-10111
> URL: https://issues.apache.org/jira/browse/IMPALA-10111
> Project: IMPALA
> Issue Type: Bug
>Reporter: Quanlong Huang
>Assignee: Tim Armstrong
>Priority: Major
> Labels: broken-build, flaky
>
> Found in an unrelated patch:
> https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/3032/testReport/junit/webserver.test_web_pages/TestWebPage/test_query_stmt/
> {code:java}
> webserver/test_web_pages.py:418: in test_query_stmt
> assert check_if_contains, "No matching statement found in the jsons."
> E AssertionError: No matching statement found in the jsons.
> E assert False {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-10111) TestWebPage::test_query_stmt is flaky
[
https://issues.apache.org/jira/browse/IMPALA-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234955#comment-17234955
]
Tim Armstrong commented on IMPALA-10111:
I wonder if it just aged out of the query logs and could be fixed by increasing
the query log size...
Anyway I'm not having luck reproducing it so I'll close it out.
If it reoccurs we should attach logs
> TestWebPage::test_query_stmt is flaky
> -
>
> Key: IMPALA-10111
> URL: https://issues.apache.org/jira/browse/IMPALA-10111
> Project: IMPALA
> Issue Type: Bug
>Reporter: Quanlong Huang
>Assignee: Tim Armstrong
>Priority: Major
> Labels: broken-build, flaky
>
> Found in an unrelated patch:
> https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/3032/testReport/junit/webserver.test_web_pages/TestWebPage/test_query_stmt/
> {code:java}
> webserver/test_web_pages.py:418: in test_query_stmt
> assert check_if_contains, "No matching statement found in the jsons."
> E AssertionError: No matching statement found in the jsons.
> E assert False {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
