[
https://issues.apache.org/jira/browse/IMPALA-12904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828197#comment-17828197
]
ASF subversion and git services commented on IMPALA-12904:
----------------------------------------------------------
Commit 2c4d84b1e11ae1f8857abebf7e7983e7449ff3e1 in impala's branch
refs/heads/master from Zoltan Borok-Nagy
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=2c4d84b1e ]
IMPALA-12904: test_type_conversions_hive3 silently passes because of wrongly
defined test dimensions
test_type_conversions_hive3 silently passes because we are not creating
the test dimenstion for query option orc_shema_resolution correctly. If
we set orc_shema_resolution correctly, i.e. to also exercise the
name-based schema resolution, the test fails. The cause of the failure
is that the ill-typed tables have dummy column names like 'c1', 'c2',
etc. These are completely fine for position-based schema resolution,
but it is not OK for name-based schema resolution.
The test just wants to check error messages related to type errors,
the column names are irrelevant, so we can just use the correct
names.
Change-Id: I786a5eaae9243b4728484f3f3b1427b20a1d2d28
Reviewed-on: http://gerrit.cloudera.org:8080/21151
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> test_type_conversions_hive3 silently passes because of wrongly defined test
> dimensions
> --------------------------------------------------------------------------------------
>
> Key: IMPALA-12904
> URL: https://issues.apache.org/jira/browse/IMPALA-12904
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Reporter: Zoltán Borók-Nagy
> Assignee: Zoltán Borók-Nagy
> Priority: Major
>
> test_type_conversions_hive3 silently passes because we are not creating the
> test dimenstion for query option orc_shema_resolution correctly.
> Instead of:
>
> {noformat}
> cls.ImpalaTestMatrix.add_dimension(ImpalaTestDimension('orc_schema_resolution',
> 0, 1)){noformat}
> We should do the following:
> {noformat}
> add_exec_option_dimension(cls, 'orc_schema_resolution', [0, 1]){noformat}
> We should fix how we add the test dimension, and also fix the underlying bug
> it reveals.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
