[
https://issues.apache.org/jira/browse/IMPALA-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828196#comment-17828196
]
ASF subversion and git services commented on IMPALA-12914:
----------------------------------------------------------
Commit caf136fae4951a6eb5216f897d18d313f94ddd83 in impala's branch
refs/heads/master from Michael Smith
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=caf136fae ]
IMPALA-12914: TestBannedLogMessages no longer requires running cluster
Updates test_banned_log_messages.py to no longer require a running
cluster, as it only checks files on disk. This fixes running custom
cluster tests that end with shutting down the cluster via
run-all-tests.sh.
Tested locally with
FE_TEST=false BE_TEST=false EE_TEST=false JDBC_TEST=false\
JS_TEST=false CLUSTER_TEST_FILES=custom_cluster/test_coordinators.py\
::TestCoordinators::test_exclusive_coordinator_plan run-all-tests.sh
Change-Id: Icfa7d5925bf724d714eaa7fa606defae0822cf93
Reviewed-on: http://gerrit.cloudera.org:8080/21152
Reviewed-by: Riza Suminto <riza.sumi...@cloudera.com>
Tested-by: Michael Smith <michael.sm...@cloudera.com>
> test_banned_log_messages fails if Impala is not running
> -------------------------------------------------------
>
> Key: IMPALA-12914
> URL: https://issues.apache.org/jira/browse/IMPALA-12914
> Project: IMPALA
> Issue Type: Task
> Components: Infrastructure
> Reporter: Michael Smith
> Assignee: Michael Smith
> Priority: Major
>
> {{run-all-tests.sh}} fails at the end - in test_banned_log_messages.py - if
> used to test a custom cluster test that finishes with Impala stopped, such as
> {{custom_cluster/test_coordinators.py::TestCoordinators::test_exclusive_coordinator_plan}}.
> The error is
> {code}
> verifiers/test_banned_log_messages.py::TestBannedLogMessages::test_no_inaccessible_objects
> ERROR
> verifiers/test_banned_log_messages.py::TestBannedLogMessages::test_no_unsupported_operations
> ERROR
> generated xml file:
> /data/jenkins/workspace/impala-private-basic-parameterized/repos/Impala/logs/verifiers/TEST-impala-verifiers.xml
>
> =========================== short test summary info
> ============================
> ERROR
> verifiers/test_banned_log_messages.py::TestBannedLogMessages::()::test_no_inaccessible_objects
> ERROR
> verifiers/test_banned_log_messages.py::TestBannedLogMessages::()::test_no_unsupported_operations
> ==================================== ERRORS
> ====================================
> _____ ERROR at setup of TestBannedLogMessages.test_no_inaccessible_objects
> _____
> common/impala_test_suite.py:226: in setup_class
> cls.create_impala_clients()
> common/impala_test_suite.py:327: in create_impala_clients
> cls.client = cls.create_impala_client(protocol='beeswax')
> common/impala_test_suite.py:310: in create_impala_client
> client.connect()
> common/impala_connection.py:196: in connect
> self.__beeswax_client.connect()
> beeswax/impala_beeswax.py:166: in connect
> raise ImpalaBeeswaxException(self.__build_error_message(e), e)
> E ImpalaBeeswaxException: ImpalaBeeswaxException:
> E INNER EXCEPTION: <class
> 'thrift.transport.TTransport.TTransportException'>
> E MESSAGE: Could not connect to any of [('::1', 21000, 0, 0),
> ('127.0.0.1', 21000)]
> ---------------------------- Captured stderr setup
> -----------------------------
> SET
> client_identifier=verifiers/test_banned_log_messages.py::TestBannedLogMessages::()::test_no_inaccessible_objects;
> -- connecting to: localhost:21000
> -- 2024-03-15 12:08:43,506 INFO MainThread: Could not connect to ('::1',
> 21000, 0, 0)
> Traceback (most recent call last):
> File
> "/data0/jenkins/workspace/impala-private-basic-parameterized/repos/Impala/infra/python/env-gcc10.4.0/lib/python2.7/site-packages/thrift/transport/TSocket.py",
> line 137, in open
> handle.connect(sockaddr)
> File
> "/data/jenkins/workspace/impala-private-basic-parameterized/Impala-Toolchain/toolchain-packages-gcc10.4.0/python-2.7.16/lib/python2.7/socket.py",
> line 228, in meth
> return getattr(self._sock,name)(*args)
> error: [Errno 111] Connection refused
> -- 2024-03-15 12:08:43,506 INFO MainThread: Could not connect to
> ('127.0.0.1', 21000)
> Traceback (most recent call last):
> File
> "/data0/jenkins/workspace/impala-private-basic-parameterized/repos/Impala/infra/python/env-gcc10.4.0/lib/python2.7/site-packages/thrift/transport/TSocket.py",
> line 137, in open
> handle.connect(sockaddr)
> File
> "/data/jenkins/workspace/impala-private-basic-parameterized/Impala-Toolchain/toolchain-packages-gcc10.4.0/python-2.7.16/lib/python2.7/socket.py",
> line 228, in meth
> return getattr(self._sock,name)(*args)
> error: [Errno 111] Connection refused
> -- 2024-03-15 12:08:43,506 ERROR MainThread: Could not connect to any of
> [('::1', 21000, 0, 0), ('127.0.0.1', 21000)]
> ____ ERROR at setup of TestBannedLogMessages.test_no_unsupported_operations
> ____
> common/impala_test_suite.py:226: in setup_class
> cls.create_impala_clients()
> common/impala_test_suite.py:327: in create_impala_clients
> cls.client = cls.create_impala_client(protocol='beeswax')
> common/impala_test_suite.py:310: in create_impala_client
> client.connect()
> common/impala_connection.py:196: in connect
> self.__beeswax_client.connect()
> beeswax/impala_beeswax.py:166: in connect
> raise ImpalaBeeswaxException(self.__build_error_message(e), e)
> E ImpalaBeeswaxException: ImpalaBeeswaxException:
> E INNER EXCEPTION: <class
> 'thrift.transport.TTransport.TTransportException'>
> E MESSAGE: Could not connect to any of [('::1', 21000, 0, 0),
> ('127.0.0.1', 21000)]
> =========================== 2 error in 0.18 seconds
> ============================
> {code}
> This test only checks that logs on disk do not contain specific messages, and
> should not require a running cluster.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
