[jira] [Commented] (IMPALA-6802) Clean up tests in AuthorizationTest
[ https://issues.apache.org/jira/browse/IMPALA-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791323#comment-16791323 ] ASF subversion and git services commented on IMPALA-6802: - Commit 139f3b7351bf6a45689b670fa3d388d56cf4cc72 in impala's branch refs/heads/2.x from Fredy Wijaya [ https://gitbox.apache.org/repos/asf?p=impala.git;h=139f3b7 ] IMPALA-6802 (part 6): Clean up authorization tests This is the last part of the authorization test clean up. This patch rewrites the following tests: - alter database - explain - comment on - function - alter table/view This patch also adds the following authorization tests: - update - upsert - delete The tests in AuthorizationTest.java that have been rewritten into AuthorizationStmtTest.java are removed. Cherry-picks: not for 2.x Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55 Reviewed-on: http://gerrit.cloudera.org:8080/10841 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins Reviewed-on: http://gerrit.cloudera.org:8080/12722 Reviewed-by: Fredy Wijaya > Clean up tests in AuthorizationTest > --- > > Key: IMPALA-6802 > URL: https://issues.apache.org/jira/browse/IMPALA-6802 > Project: IMPALA > Issue Type: Improvement > Components: Infrastructure >Reporter: Fredy Wijaya >Assignee: Fredy Wijaya >Priority: Critical > Labels: security > Fix For: Impala 2.13.0, Impala 3.1.0 > > > The tests in AuthorizationTest can be refactored to be more condensed. We > also need to increase the code coverage. It is also a good idea to refactor > these tests to provide flexibility in supporting tests for user-level > privileges in the future: https://issues.apache.org/jira/browse/IMPALA-6794 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-6802) Clean up tests in AuthorizationTest
[ https://issues.apache.org/jira/browse/IMPALA-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790809#comment-16790809 ] ASF subversion and git services commented on IMPALA-6802: - Commit 24348615f7a783d7e410ab0f3f9488088c8e3b2e in impala's branch refs/heads/2.x from Fredy Wijaya [ https://gitbox.apache.org/repos/asf?p=impala.git;h=2434861 ] IMPALA-6802 (part 5): Clean up authorization tests The fifth part of this patch is to rewrite the following authorization tests: - compute/drop stats - create database/table/view - drop database/table/view Cherry-picks: not for 2.x Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526 Reviewed-on: http://gerrit.cloudera.org:8080/10799 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins Reviewed-on: http://gerrit.cloudera.org:8080/12712 Reviewed-by: Fredy Wijaya > Clean up tests in AuthorizationTest > --- > > Key: IMPALA-6802 > URL: https://issues.apache.org/jira/browse/IMPALA-6802 > Project: IMPALA > Issue Type: Improvement > Components: Infrastructure >Reporter: Fredy Wijaya >Assignee: Fredy Wijaya >Priority: Critical > Labels: security > Fix For: Impala 3.1.0 > > > The tests in AuthorizationTest can be refactored to be more condensed. We > also need to increase the code coverage. It is also a good idea to refactor > these tests to provide flexibility in supporting tests for user-level > privileges in the future: https://issues.apache.org/jira/browse/IMPALA-6794 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-6802) Clean up tests in AuthorizationTest
[ https://issues.apache.org/jira/browse/IMPALA-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790087#comment-16790087 ] ASF subversion and git services commented on IMPALA-6802: - Commit e75a5b1f3faf371b75ae980b2ae511ec55b44057 in impala's branch refs/heads/2.x from Fredy Wijaya [ https://gitbox.apache.org/repos/asf?p=impala.git;h=e75a5b1 ] IMPALA-6802 (part 2): Clean up authorization tests The second part of this patch is to rewrite the following authorization tests: - insert - truncate - load - use Testing: - Added new authorization tests - Ran all front-end tests Cherry-picks: not for 2.x Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b Reviewed-on: http://gerrit.cloudera.org:8080/10269 Reviewed-by: Alex Behm Tested-by: Impala Public Jenkins Reviewed-on: http://gerrit.cloudera.org:8080/12709 Reviewed-by: Fredy Wijaya > Clean up tests in AuthorizationTest > --- > > Key: IMPALA-6802 > URL: https://issues.apache.org/jira/browse/IMPALA-6802 > Project: IMPALA > Issue Type: Improvement > Components: Infrastructure >Reporter: Fredy Wijaya >Assignee: Fredy Wijaya >Priority: Critical > Labels: security > Fix For: Impala 3.1.0 > > > The tests in AuthorizationTest can be refactored to be more condensed. We > also need to increase the code coverage. It is also a good idea to refactor > these tests to provide flexibility in supporting tests for user-level > privileges in the future: https://issues.apache.org/jira/browse/IMPALA-6794 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-6802) Clean up tests in AuthorizationTest
[ https://issues.apache.org/jira/browse/IMPALA-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790086#comment-16790086 ] ASF subversion and git services commented on IMPALA-6802: - Commit b320fcd593489b279871866114ac91b775044f69 in impala's branch refs/heads/2.x from Fredy Wijaya [ https://gitbox.apache.org/repos/asf?p=impala.git;h=b320fcd ] IMPALA-6802 (part 1): Clean up authorization tests The first patch of this patch is to introduce a new mechanism of testing authorization that tests authorization at every hierarchy. This patch rewrites the authorization tests for select statements. Testing: - Added new authorization tests - Ran all front-end tests Cherry-picks: not for 2.x Change-Id: I9cd5713607c423f644451af5ebb3494d3a728e3b Reviewed-on: http://gerrit.cloudera.org:8080/10135 Reviewed-by: Alex Behm Tested-by: Impala Public Jenkins Reviewed-on: http://gerrit.cloudera.org:8080/12708 Reviewed-by: Fredy Wijaya > Clean up tests in AuthorizationTest > --- > > Key: IMPALA-6802 > URL: https://issues.apache.org/jira/browse/IMPALA-6802 > Project: IMPALA > Issue Type: Improvement > Components: Infrastructure >Reporter: Fredy Wijaya >Assignee: Fredy Wijaya >Priority: Critical > Labels: security > Fix For: Impala 3.1.0 > > > The tests in AuthorizationTest can be refactored to be more condensed. We > also need to increase the code coverage. It is also a good idea to refactor > these tests to provide flexibility in supporting tests for user-level > privileges in the future: https://issues.apache.org/jira/browse/IMPALA-6794 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-6802) Clean up tests in AuthorizationTest
[ https://issues.apache.org/jira/browse/IMPALA-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790088#comment-16790088 ] ASF subversion and git services commented on IMPALA-6802: - Commit 74c7e42962e1d29fa9414d7893d3f1f4e7a4ba76 in impala's branch refs/heads/2.x from Fredy Wijaya [ https://gitbox.apache.org/repos/asf?p=impala.git;h=74c7e42 ] IMPALA-6802 (part 3): Clean up authorization tests The third part of this patch is to rewrite the following authorization tests: - with - union - reset metadata - show Testing: - Added new authorization tests - Ran all front-end tests Change-Id: I9681cc3c7094db33ab7c5caa69b99dd803b908b7 Cherry-picks: not for 2.x Reviewed-on: http://gerrit.cloudera.org:8080/10358 Reviewed-by: Alex Behm Tested-by: Impala Public Jenkins Reviewed-on: http://gerrit.cloudera.org:8080/12710 Reviewed-by: Fredy Wijaya > Clean up tests in AuthorizationTest > --- > > Key: IMPALA-6802 > URL: https://issues.apache.org/jira/browse/IMPALA-6802 > Project: IMPALA > Issue Type: Improvement > Components: Infrastructure >Reporter: Fredy Wijaya >Assignee: Fredy Wijaya >Priority: Critical > Labels: security > Fix For: Impala 3.1.0 > > > The tests in AuthorizationTest can be refactored to be more condensed. We > also need to increase the code coverage. It is also a good idea to refactor > these tests to provide flexibility in supporting tests for user-level > privileges in the future: https://issues.apache.org/jira/browse/IMPALA-6794 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-6802) Clean up tests in AuthorizationTest
[ https://issues.apache.org/jira/browse/IMPALA-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790089#comment-16790089 ] ASF subversion and git services commented on IMPALA-6802: - Commit 80fa7bb5a093c3f0c248b1612d8c25f9e887 in impala's branch refs/heads/2.x from Adam Holley [ https://gitbox.apache.org/repos/asf?p=impala.git;h=80fa7bb ] IMPALA-6802 (part 4): Clean up authorization tests The fourth part of this patch is to rewrite the following authorization tests: - describe Testing: - Added new authorization tests - Ran all front-end tests Cherry-picks: not for 2.x Change-Id: Ic4cf3a4751b41908ef81ec35d89a2713d9fa0dc4 Reviewed-on: http://gerrit.cloudera.org:8080/10442 Tested-by: Impala Public Jenkins Reviewed-by: Vuk Ercegovac Reviewed-on: http://gerrit.cloudera.org:8080/12711 Reviewed-by: Fredy Wijaya > Clean up tests in AuthorizationTest > --- > > Key: IMPALA-6802 > URL: https://issues.apache.org/jira/browse/IMPALA-6802 > Project: IMPALA > Issue Type: Improvement > Components: Infrastructure >Reporter: Fredy Wijaya >Assignee: Fredy Wijaya >Priority: Critical > Labels: security > Fix For: Impala 3.1.0 > > > The tests in AuthorizationTest can be refactored to be more condensed. We > also need to increase the code coverage. It is also a good idea to refactor > these tests to provide flexibility in supporting tests for user-level > privileges in the future: https://issues.apache.org/jira/browse/IMPALA-6794 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-6802) Clean up tests in AuthorizationTest
[ https://issues.apache.org/jira/browse/IMPALA-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528476#comment-16528476 ] ASF subversion and git services commented on IMPALA-6802: - Commit 5c880e52bc82270588496817fbbf1fb62ad2ef0d in impala's branch refs/heads/master from [~fredyw] [ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=5c880e5 ] IMPALA-6802 (part 6): Clean up authorization tests This is the last part of the authorization test clean up. This patch rewrites the following tests: - alter database - explain - comment on - function - alter table/view This patch also adds the following authorization tests: - update - upsert - delete The tests in AuthorizationTest.java that have been rewritten into AuthorizationStmtTest.java are removed. Cherry-picks: not for 2.x Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55 Reviewed-on: http://gerrit.cloudera.org:8080/10841 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins > Clean up tests in AuthorizationTest > --- > > Key: IMPALA-6802 > URL: https://issues.apache.org/jira/browse/IMPALA-6802 > Project: IMPALA > Issue Type: Improvement > Components: Infrastructure >Reporter: Fredy Wijaya >Assignee: Fredy Wijaya >Priority: Critical > Labels: security > > The tests in AuthorizationTest can be refactored to be more condensed. We > also need to increase the code coverage. It is also a good idea to refactor > these tests to provide flexibility in supporting tests for user-level > privileges in the future: https://issues.apache.org/jira/browse/IMPALA-6794 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-6802) Clean up tests in AuthorizationTest
[ https://issues.apache.org/jira/browse/IMPALA-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523828#comment-16523828 ] ASF subversion and git services commented on IMPALA-6802: - Commit 011acd073ae275baedc02f960beaebfc2035a8e5 in impala's branch refs/heads/master from [~fredyw] [ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=011acd0 ] IMPALA-6802 (part 5): Clean up authorization tests The fifth part of this patch is to rewrite the following authorization tests: - compute/drop stats - create database/table/view - drop database/table/view Cherry-picks: not for 2.x Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526 Reviewed-on: http://gerrit.cloudera.org:8080/10799 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins > Clean up tests in AuthorizationTest > --- > > Key: IMPALA-6802 > URL: https://issues.apache.org/jira/browse/IMPALA-6802 > Project: IMPALA > Issue Type: Improvement > Components: Infrastructure >Reporter: Fredy Wijaya >Assignee: Fredy Wijaya >Priority: Critical > Labels: security > > The tests in AuthorizationTest can be refactored to be more condensed. We > also need to increase the code coverage. It is also a good idea to refactor > these tests to provide flexibility in supporting tests for user-level > privileges in the future: https://issues.apache.org/jira/browse/IMPALA-6794 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-6802) Clean up tests in AuthorizationTest
[ https://issues.apache.org/jira/browse/IMPALA-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522553#comment-16522553 ] Fredy Wijaya commented on IMPALA-6802: -- [https://git-wip-us.apache.org/repos/asf?p=impala.git;a=commit;h=4cfd40cef8ff1df1efe301894dc7425513dd1f74] IMPALA-6802 (part 4): Clean up authorization tests The fourth part of this patch is to rewrite the following authorization tests: - describe Testing: - Added new authorization tests - Ran all front-end tests Cherry-picks: not for 2.x Change-Id: Ic4cf3a4751b41908ef81ec35d89a2713d9fa0dc4 Reviewed-on: http://gerrit.cloudera.org:8080/10442 Tested-by: Impala Public Jenkins Reviewed-by: Vuk Ercegovac > Clean up tests in AuthorizationTest > --- > > Key: IMPALA-6802 > URL: https://issues.apache.org/jira/browse/IMPALA-6802 > Project: IMPALA > Issue Type: Improvement > Components: Infrastructure >Reporter: Fredy Wijaya >Assignee: Fredy Wijaya >Priority: Critical > Labels: security > > The tests in AuthorizationTest can be refactored to be more condensed. We > also need to increase the code coverage. It is also a good idea to refactor > these tests to provide flexibility in supporting tests for user-level > privileges in the future: https://issues.apache.org/jira/browse/IMPALA-6794 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-6802) Clean up tests in AuthorizationTest
[ https://issues.apache.org/jira/browse/IMPALA-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476774#comment-16476774 ] ASF subversion and git services commented on IMPALA-6802: - Commit 75a10a3dda80137120ecb9c1871e6bdfb74f6522 in impala's branch refs/heads/master from [~fredyw] [ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=75a10a3 ] IMPALA-6802 (part 3): Clean up authorization tests The third part of this patch is to rewrite the following authorization tests: - with - union - reset metadata - show Testing: - Added new authorization tests - Ran all front-end tests Change-Id: I9681cc3c7094db33ab7c5caa69b99dd803b908b7 Cherry-picks: not for 2.x Reviewed-on: http://gerrit.cloudera.org:8080/10358 Reviewed-by: Alex Behm Tested-by: Impala Public Jenkins > Clean up tests in AuthorizationTest > --- > > Key: IMPALA-6802 > URL: https://issues.apache.org/jira/browse/IMPALA-6802 > Project: IMPALA > Issue Type: Improvement > Components: Infrastructure >Reporter: Fredy Wijaya >Assignee: Fredy Wijaya >Priority: Critical > > The tests in AuthorizationTest can be refactored to be more condensed. We > also need to increase the code coverage. It is also a good idea to refactor > these tests to provide flexibility in supporting tests for user-level > privileges in the future: https://issues.apache.org/jira/browse/IMPALA-6794 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-6802) Clean up tests in AuthorizationTest
[ https://issues.apache.org/jira/browse/IMPALA-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469047#comment-16469047 ] ASF subversion and git services commented on IMPALA-6802: - Commit 19752af1fdce9f6946d3136cdecb4ff4498032ca in impala's branch refs/heads/master from [~fredyw] [ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=19752af ] IMPALA-6802 (part 2): Clean up authorization tests The second part of this patch is to rewrite the following authorization tests: - insert - truncate - load - use Testing: - Added new authorization tests - Ran all front-end tests Cherry-picks: not for 2.x Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b Reviewed-on: http://gerrit.cloudera.org:8080/10269 Reviewed-by: Alex Behm Tested-by: Impala Public Jenkins > Clean up tests in AuthorizationTest > --- > > Key: IMPALA-6802 > URL: https://issues.apache.org/jira/browse/IMPALA-6802 > Project: IMPALA > Issue Type: Improvement > Components: Infrastructure >Reporter: Fredy Wijaya >Assignee: Fredy Wijaya >Priority: Critical > > The tests in AuthorizationTest can be refactored to be more condensed. We > also need to increase the code coverage. It is also a good idea to refactor > these tests to provide flexibility in supporting tests for user-level > privileges in the future: https://issues.apache.org/jira/browse/IMPALA-6794 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-6802) Clean up tests in AuthorizationTest
[ https://issues.apache.org/jira/browse/IMPALA-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459781#comment-16459781 ] ASF subversion and git services commented on IMPALA-6802: - Commit 671de258f29d31d280defe989af261fdbd9182ae in impala's branch refs/heads/master from [~fredyw] [ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=671de25 ] IMPALA-6802 (part 1): Clean up authorization tests The first patch of this patch is to introduce a new mechanism of testing authorization that tests authorization at every hierarchy. This patch rewrites the authorization tests for select statements. Testing: - Added new authorization tests - Ran all front-end tests Cherry-picks: not for 2.x Change-Id: I9cd5713607c423f644451af5ebb3494d3a728e3b Reviewed-on: http://gerrit.cloudera.org:8080/10135 Reviewed-by: Alex Behm Tested-by: Impala Public Jenkins > Clean up tests in AuthorizationTest > --- > > Key: IMPALA-6802 > URL: https://issues.apache.org/jira/browse/IMPALA-6802 > Project: IMPALA > Issue Type: Improvement > Components: Infrastructure >Reporter: Fredy Wijaya >Assignee: Fredy Wijaya >Priority: Critical > > The tests in AuthorizationTest can be refactored to be more condensed. We > also need to increase the code coverage. It is also a good idea to refactor > these tests to provide flexibility in supporting tests for user-level > privileges in the future: https://issues.apache.org/jira/browse/IMPALA-6794 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
