[jira] [Commented] (IMPALA-8338) Check CREATION_TIME of databases in event processor to avoid incorrect/redundant invalidates

2019-04-16 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/IMPALA-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819461#comment-16819461
 ] 

ASF subversion and git services commented on IMPALA-8338:
-

Commit 55881609f1c21eb7a59c383de60171ffa8943db8 in impala's branch 
refs/heads/master from Bharath Krishna
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=5588160 ]

IMPALA-8338 : Check CREATION_TIME while processing DROP_DATABASE events.

Process the drop database event only if the CREATION_TIME of the
catalog's database object is lesser than or equal to that of the
database object present in the notification event. If the
CREATION_TIME in the notification event object is lesser than
the catalog's DB object, it means that the Database object
present in the catalog is the latest and we can skip the event
instead.

Testing :
 - Added unit tests in MetastoreEventsProcessorTest.
 - Enabled testCreateDropCreateDatabaseFromImpala as
   we now have CREATION_TIME in the notification events.

Change-Id: I8fd3685cf7261e4953f4f884850489a47c5bbd6c
Reviewed-on: http://gerrit.cloudera.org:8080/12938
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 


> Check CREATION_TIME of databases in event processor to avoid 
> incorrect/redundant invalidates
> 
>
> Key: IMPALA-8338
> URL: https://issues.apache.org/jira/browse/IMPALA-8338
> Project: IMPALA
>  Issue Type: Sub-task
>Reporter: Bharathkrishna Guruvayoor Murali
>Assignee: Bharathkrishna Guruvayoor Murali
>Priority: Major
>
> HIVE-21077 adds CREATION_TIME to Database, and it will be available in the 
> metastore notifications. Hence,
>  # For CREATE_DATABASE events, we should compare the creationTime of the 
> Database in catalog with the Database in the event to make sure we are 
> ignoring the event only if catalog has the latest Database object.
>  # For DROP_DATABASE events, we should check that creation time of database 
> in the notification and the catalog match to make sure that we are removing 
> the correct database object.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org



[jira] [Commented] (IMPALA-8338) Check CREATION_TIME of databases in event processor to avoid incorrect/redundant invalidates

2019-04-11 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/IMPALA-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815688#comment-16815688
 ] 

ASF subversion and git services commented on IMPALA-8338:
-

Commit 50e259e3691b7de36f58408bde6413880c74845e in impala's branch 
refs/heads/master from Bharath Krishna
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=50e259e ]

Bump CDH_BUILD_NUMBER to 1009254

This change bumps the CDH_BUILD_VERSION to a version that includes
the change to have full-thrift object for DropDatabaseMessage in
Metastore notifications, added in HIVE-21526. This change is needed
for the upcoming patch for IMPALA-8338.

Testing:
- Ran a full exhaustive build using the impala-private-parameterized job.

Change-Id: Id38bae921c4d93421c6c72cdccef6a4783e2588e
Reviewed-on: http://gerrit.cloudera.org:8080/12965
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 


> Check CREATION_TIME of databases in event processor to avoid 
> incorrect/redundant invalidates
> 
>
> Key: IMPALA-8338
> URL: https://issues.apache.org/jira/browse/IMPALA-8338
> Project: IMPALA
>  Issue Type: Sub-task
>Reporter: Bharathkrishna Guruvayoor Murali
>Assignee: Bharathkrishna Guruvayoor Murali
>Priority: Major
>
> HIVE-21077 adds CREATION_TIME to Database, and it will be available in the 
> metastore notifications. Hence,
>  # For CREATE_DATABASE events, we should compare the creationTime of the 
> Database in catalog with the Database in the event to make sure we are 
> ignoring the event only if catalog has the latest Database object.
>  # For DROP_DATABASE events, we should check that creation time of database 
> in the notification and the catalog match to make sure that we are removing 
> the correct database object.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org