Re: [PATCH] Implement hashed passwords for SQLite3 storage
Dnia 2013-10-30, śro o godzinie 03:37 -0200, Sergio Durigan Junior pisze: The patch is indeed a copy-and-paste of the code which adds this security in other backends. I also made a little cleanup in the check_password function of the SQLite3 backend (obvious). I tested the patch by creating several users and logging into the server with them afterwards. Everything succeeded. Thanks. :-) Merged: https://github.com/jabberd2/jabberd2/commit/3e207cfc08efdafe9a9e75dc580dd9c5bfe59554 -- Tomasz Sterna @ http://abadcafe.pl/ @ http://www.xiaoka.com/
Re: sm/router: XML parser error
Thanks, I got a debug log by specifying a debug path in router.xml, but it doesn't say XML parser error; am I missing something from stderr that doesn't make it to the logfile? Or, if that file has everything, could I mail you the relevant section surrounding from this morning? I can't find anything obviously broken. Justin On Sun, Oct 27, 2013 at 10:03:34PM +0100, Tomasz Sterna wrote: Dnia 2013-10-25, pią o godzinie 14:17 -0700, Justin T Pryzby pisze: router: Fri Oct 25 11:45:48 2013 [notice] error from router: XML parse error (junk after document element) That could be related to bad data in AD, but I don't believe any users were changed by anyone but myself, and don't see anything wrong. Here's what I do, to debug such obscure issues: 1. rebuild jabberd with --enable-debug 2. hang router and sm on screen with -D enabled 3. wait for a crash Usually there is an offending stanza visible right after I reattach to the screen of crashed process. I've caught several parser/serializer bugs using this method.
Re: sm/router: XML parser error
Dnia 2013-10-30, śro o godzinie 10:28 -0700, Justin T Pryzby pisze: Thanks, I got a debug log by specifying a debug path in router.xml, but it doesn't say XML parser error; am I missing something from stderr that doesn't make it to the logfile? This is logged in the normal, not debug log. Check standard log to see when that happens and send me few screens of debug log before that happened. It should help me debug and fix your issue.
Re: [PATCH] Implement hashed passwords for SQLite3 storage
On Wednesday, October 30 2013, Tomasz Sterna wrote: Dnia 2013-10-30, śro o godzinie 03:37 -0200, Sergio Durigan Junior pisze: The patch is indeed a copy-and-paste of the code which adds this security in other backends. I also made a little cleanup in the check_password function of the SQLite3 backend (obvious). I tested the patch by creating several users and logging into the server with them afterwards. Everything succeeded. Thanks. :-) Merged: https://github.com/jabberd2/jabberd2/commit/3e207cfc08efdafe9a9e75dc580dd9c5bfe59554 Wow, that was fast! Thanks a lot :-). Eventually, I intend to start working on the libdbi integration (see https://github.com/jabberd2/jabberd2/issues/28). Is anyone else working on this? Maybe we could join efforts :-). Thanks, -- Sergio
