Re: [jira] Commented: (LUCENE-1208) Deadlock case in IndexWriter on exception just before flush
OK I've backported fixes for these issues to the 2.3 branch! Mike Michael Busch wrote: Michael McCandless (JIRA) wrote: [ https://issues.apache.org/jira/browse/LUCENE-1208? page=com.atlassian.jira.plugin.system.issuetabpanels:comment- tabpanel&focusedCommentId=12576941#action_12576941 ] Michael McCandless commented on LUCENE-1208: Agreed. I'm thinking these issues should be ported to 2.3.2: LUCENE-1191 LUCENE-1197 LUCENE-1198 LUCENE-1199 LUCENE-1200 LUCENE-1208 (this issue) LUCENE-1210 +1 -Michael - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [jira] Commented: (LUCENE-1208) Deadlock case in IndexWriter on exception just before flush
OK I'll backport. Mike Michael Busch wrote: Michael McCandless (JIRA) wrote: [ https://issues.apache.org/jira/browse/LUCENE-1208? page=com.atlassian.jira.plugin.system.issuetabpanels:comment- tabpanel&focusedCommentId=12576941#action_12576941 ] Michael McCandless commented on LUCENE-1208: Agreed. I'm thinking these issues should be ported to 2.3.2: LUCENE-1191 LUCENE-1197 LUCENE-1198 LUCENE-1199 LUCENE-1200 LUCENE-1208 (this issue) LUCENE-1210 +1 -Michael - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [jira] Commented: (LUCENE-1208) Deadlock case in IndexWriter on exception just before flush
Michael McCandless (JIRA) wrote: > [ > https://issues.apache.org/jira/browse/LUCENE-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576941#action_12576941 > ] > > Michael McCandless commented on LUCENE-1208: > > > Agreed. I'm thinking these issues should be ported to 2.3.2: > > LUCENE-1191 > LUCENE-1197 > LUCENE-1198 > LUCENE-1199 > LUCENE-1200 > LUCENE-1208 (this issue) > LUCENE-1210 > +1 -Michael - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LUCENE-1208) Deadlock case in IndexWriter on exception just before flush
[ https://issues.apache.org/jira/browse/LUCENE-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577073#action_12577073 ] Michael Busch commented on LUCENE-1208: --- We had seen this deadlock problem in our tests. I reran all tests with Lucene 2.3.1 + LUCENE-1208 and didn't see the problem again so far! > Deadlock case in IndexWriter on exception just before flush > --- > > Key: LUCENE-1208 > URL: https://issues.apache.org/jira/browse/LUCENE-1208 > Project: Lucene - Java > Issue Type: Bug > Components: Index >Affects Versions: 2.3, 2.3.1 >Reporter: Michael McCandless >Assignee: Michael McCandless >Priority: Minor > Fix For: 2.4 > > Attachments: LUCENE-1208.patch > > > If a document hits a non-aborting exception, eg something goes wrong > in tokenStream.next(), and, that document had triggered a flush > (due to RAM or doc count) then DocumentsWriter will deadlock because > that thread marks the flush as pending but fails to clear it on > exception. > I have a simple test case showing this, and a fix fixing it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LUCENE-1208) Deadlock case in IndexWriter on exception just before flush
[ https://issues.apache.org/jira/browse/LUCENE-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576941#action_12576941 ] Michael McCandless commented on LUCENE-1208: Agreed. I'm thinking these issues should be ported to 2.3.2: LUCENE-1191 LUCENE-1197 LUCENE-1198 LUCENE-1199 LUCENE-1200 LUCENE-1208 (this issue) LUCENE-1210 > Deadlock case in IndexWriter on exception just before flush > --- > > Key: LUCENE-1208 > URL: https://issues.apache.org/jira/browse/LUCENE-1208 > Project: Lucene - Java > Issue Type: Bug > Components: Index >Affects Versions: 2.3, 2.3.1 >Reporter: Michael McCandless >Assignee: Michael McCandless >Priority: Minor > Fix For: 2.4 > > Attachments: LUCENE-1208.patch > > > If a document hits a non-aborting exception, eg something goes wrong > in tokenStream.next(), and, that document had triggered a flush > (due to RAM or doc count) then DocumentsWriter will deadlock because > that thread marks the flush as pending but fails to clear it on > exception. > I have a simple test case showing this, and a fix fixing it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LUCENE-1208) Deadlock case in IndexWriter on exception just before flush
[ https://issues.apache.org/jira/browse/LUCENE-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576933#action_12576933 ] Michele Bini commented on LUCENE-1208: -- As with LUCENE-1210, shouldn't the patch be committed in the 2.3 branch, too, as it affects 2.3.1? Other issues, such as the speedups in LUCENE-1211, although useful, can be left out as they are not bugs. But fix for deadlocks seem worthwhile for 2.3.x, too. > Deadlock case in IndexWriter on exception just before flush > --- > > Key: LUCENE-1208 > URL: https://issues.apache.org/jira/browse/LUCENE-1208 > Project: Lucene - Java > Issue Type: Bug > Components: Index >Affects Versions: 2.3, 2.3.1 >Reporter: Michael McCandless >Assignee: Michael McCandless >Priority: Minor > Fix For: 2.4 > > Attachments: LUCENE-1208.patch > > > If a document hits a non-aborting exception, eg something goes wrong > in tokenStream.next(), and, that document had triggered a flush > (due to RAM or doc count) then DocumentsWriter will deadlock because > that thread marks the flush as pending but fails to clear it on > exception. > I have a simple test case showing this, and a fix fixing it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]