[jira] Commented: (LUCENE-1228) IndexWriter.commit() does not update the index version
[ https://issues.apache.org/jira/browse/LUCENE-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12578649#action_12578649 ] Michael McCandless commented on LUCENE-1228: {quote} Does SegmentInfos really need both version and generation? Is generation sufficient? {quote} I believe they are in fact redundant. I tested this with a small change to just return generation when getVersion is called and all tests pass. I'll open a new issue. IndexWriter.commit() does not update the index version --- Key: LUCENE-1228 URL: https://issues.apache.org/jira/browse/LUCENE-1228 Project: Lucene - Java Issue Type: Bug Components: Index Affects Versions: 2.4 Reporter: Doron Cohen Assignee: Doron Cohen Attachments: lucene-1228-commit-reopen.patch IndexWriter.commit() can update the index *version* and *generation* but the update of *version* is lost. As result added documents are not seen by IndexReader.reopen(). (There might be other side effects that I am not aware of). The fix is 1 line - update also the version in SegmentsInfo.updateGeneration(). (Finding this line involved more lines though... :-) ) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LUCENE-1228) IndexWriter.commit() does not update the index version
[ https://issues.apache.org/jira/browse/LUCENE-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12578472#action_12578472 ] Michael McCandless commented on LUCENE-1228: Good catch Doron, thanks! This only affects trunk (2.4). IndexWriter.commit() does not update the index version --- Key: LUCENE-1228 URL: https://issues.apache.org/jira/browse/LUCENE-1228 Project: Lucene - Java Issue Type: Bug Components: Index Affects Versions: 2.3, 2.3.1, 2.4 Reporter: Doron Cohen Assignee: Doron Cohen Attachments: lucene-1228-commit-reopen.patch IndexWriter.commit() can update the index *version* and *generation* but the update of *version* is lost. As result added documents are not seen by IndexReader.reopen(). (There might be other side effects that I am not aware of). The fix is 1 line - update also the version in SegmentsInfo.updateGeneration(). (Finding this line involved more lines though... :-) ) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LUCENE-1228) IndexWriter.commit() does not update the index version
[ https://issues.apache.org/jira/browse/LUCENE-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12578475#action_12578475 ] Doron Cohen commented on LUCENE-1228: - Oh good, less migration to do. Mmm.. so it is not related to Daniel's Document ID shuffling under 2.3.x in the user list. IndexWriter.commit() does not update the index version --- Key: LUCENE-1228 URL: https://issues.apache.org/jira/browse/LUCENE-1228 Project: Lucene - Java Issue Type: Bug Components: Index Affects Versions: 2.4 Reporter: Doron Cohen Assignee: Doron Cohen Attachments: lucene-1228-commit-reopen.patch IndexWriter.commit() can update the index *version* and *generation* but the update of *version* is lost. As result added documents are not seen by IndexReader.reopen(). (There might be other side effects that I am not aware of). The fix is 1 line - update also the version in SegmentsInfo.updateGeneration(). (Finding this line involved more lines though... :-) ) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LUCENE-1228) IndexWriter.commit() does not update the index version
[ https://issues.apache.org/jira/browse/LUCENE-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12578518#action_12578518 ] Ning Li commented on LUCENE-1228: - Does SegmentInfos really need both version and generation? Is generation sufficient? IndexWriter.commit() does not update the index version --- Key: LUCENE-1228 URL: https://issues.apache.org/jira/browse/LUCENE-1228 Project: Lucene - Java Issue Type: Bug Components: Index Affects Versions: 2.4 Reporter: Doron Cohen Assignee: Doron Cohen Attachments: lucene-1228-commit-reopen.patch IndexWriter.commit() can update the index *version* and *generation* but the update of *version* is lost. As result added documents are not seen by IndexReader.reopen(). (There might be other side effects that I am not aware of). The fix is 1 line - update also the version in SegmentsInfo.updateGeneration(). (Finding this line involved more lines though... :-) ) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]