[jira] Commented: (LUCENE-1571) DistanceFilter problem with deleted documents
[ https://issues.apache.org/jira/browse/LUCENE-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12719258#action_12719258 ] Michael McCandless commented on LUCENE-1571: Indeed, this bug looks like it's still present, in LatLongDistanceFilter.java. That bits() method simply iterates through all docs, looking up parsing lat/lng. I'll change it to use a TermDocs(null) iter instead, which won't visit deleted docs. DistanceFilter problem with deleted documents - Key: LUCENE-1571 URL: https://issues.apache.org/jira/browse/LUCENE-1571 Project: Lucene - Java Issue Type: Bug Components: contrib/spatial Environment: N/A Reporter: Phillip Rhodes Fix For: 2.9 I know this is the locallucene lib, but wanted to make sure we don't get this bug when it gets into lucene contrib. I suspect that the issue is that deleted documents are trying to be evaluated by the filter. I did some debugging and I confirmed that it is bombing on a document that is marked as deleted (using Luke). Thanks! Using the locallucene library 1.51, I get a NullPointerException at line 123 of DistanceFilter The method is public BitSet bits(IndexReader reader) The line is double x = NumberUtils.SortableStr2double(sx); The stack trace is: java.lang.NullPointerException at org.apache.solr.util.NumberUtils.SortableStr2long(NumberUtils.java:149) at org.apache.solr.util.NumberUtils.SortableStr2double(NumberUtils.java:104) at com.pjaol.search.geo.utils.DistanceFilter.bits(DistanceFilter.java:123) at org.apache.lucene.search.Filter.getDocIdSet(Filter.java:49) at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:140) at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:112) at org.apache.lucene.search.Hits.getMoreDocs(Hits.java:113) at org.apache.lucene.search.Hits.init(Hits.java:90) at org.apache.lucene.search.Searcher.search(Searcher.java:72) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-1571) DistanceFilter problem with deleted documents
[ https://issues.apache.org/jira/browse/LUCENE-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12719272#action_12719272 ] patrick o'leary commented on LUCENE-1571: - patch looks good to me, tests passed as well DistanceFilter problem with deleted documents - Key: LUCENE-1571 URL: https://issues.apache.org/jira/browse/LUCENE-1571 Project: Lucene - Java Issue Type: Bug Components: contrib/spatial Environment: N/A Reporter: Phillip Rhodes Assignee: Michael McCandless Fix For: 2.9 Attachments: LUCENE-1571.patch I know this is the locallucene lib, but wanted to make sure we don't get this bug when it gets into lucene contrib. I suspect that the issue is that deleted documents are trying to be evaluated by the filter. I did some debugging and I confirmed that it is bombing on a document that is marked as deleted (using Luke). Thanks! Using the locallucene library 1.51, I get a NullPointerException at line 123 of DistanceFilter The method is public BitSet bits(IndexReader reader) The line is double x = NumberUtils.SortableStr2double(sx); The stack trace is: java.lang.NullPointerException at org.apache.solr.util.NumberUtils.SortableStr2long(NumberUtils.java:149) at org.apache.solr.util.NumberUtils.SortableStr2double(NumberUtils.java:104) at com.pjaol.search.geo.utils.DistanceFilter.bits(DistanceFilter.java:123) at org.apache.lucene.search.Filter.getDocIdSet(Filter.java:49) at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:140) at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:112) at org.apache.lucene.search.Hits.getMoreDocs(Hits.java:113) at org.apache.lucene.search.Hits.init(Hits.java:90) at org.apache.lucene.search.Searcher.search(Searcher.java:72) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-1571) DistanceFilter problem with deleted documents
[ https://issues.apache.org/jira/browse/LUCENE-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12719290#action_12719290 ] Michael McCandless commented on LUCENE-1571: OK thanks for reviewing Patrick. I'll commit shortly... DistanceFilter problem with deleted documents - Key: LUCENE-1571 URL: https://issues.apache.org/jira/browse/LUCENE-1571 Project: Lucene - Java Issue Type: Bug Components: contrib/spatial Environment: N/A Reporter: Phillip Rhodes Assignee: Michael McCandless Fix For: 2.9 Attachments: LUCENE-1571.patch I know this is the locallucene lib, but wanted to make sure we don't get this bug when it gets into lucene contrib. I suspect that the issue is that deleted documents are trying to be evaluated by the filter. I did some debugging and I confirmed that it is bombing on a document that is marked as deleted (using Luke). Thanks! Using the locallucene library 1.51, I get a NullPointerException at line 123 of DistanceFilter The method is public BitSet bits(IndexReader reader) The line is double x = NumberUtils.SortableStr2double(sx); The stack trace is: java.lang.NullPointerException at org.apache.solr.util.NumberUtils.SortableStr2long(NumberUtils.java:149) at org.apache.solr.util.NumberUtils.SortableStr2double(NumberUtils.java:104) at com.pjaol.search.geo.utils.DistanceFilter.bits(DistanceFilter.java:123) at org.apache.lucene.search.Filter.getDocIdSet(Filter.java:49) at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:140) at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:112) at org.apache.lucene.search.Hits.getMoreDocs(Hits.java:113) at org.apache.lucene.search.Hits.init(Hits.java:90) at org.apache.lucene.search.Searcher.search(Searcher.java:72) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-1571) DistanceFilter problem with deleted documents
[ https://issues.apache.org/jira/browse/LUCENE-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12718276#action_12718276 ] Mark Miller commented on LUCENE-1571: - Can someone that knows LocalLucene comment on whether this needs to be fixed for 2.9? DistanceFilter problem with deleted documents - Key: LUCENE-1571 URL: https://issues.apache.org/jira/browse/LUCENE-1571 Project: Lucene - Java Issue Type: Bug Components: contrib/spatial Environment: N/A Reporter: Phillip Rhodes Fix For: 2.9 I know this is the locallucene lib, but wanted to make sure we don't get this bug when it gets into lucene contrib. I suspect that the issue is that deleted documents are trying to be evaluated by the filter. I did some debugging and I confirmed that it is bombing on a document that is marked as deleted (using Luke). Thanks! Using the locallucene library 1.51, I get a NullPointerException at line 123 of DistanceFilter The method is public BitSet bits(IndexReader reader) The line is double x = NumberUtils.SortableStr2double(sx); The stack trace is: java.lang.NullPointerException at org.apache.solr.util.NumberUtils.SortableStr2long(NumberUtils.java:149) at org.apache.solr.util.NumberUtils.SortableStr2double(NumberUtils.java:104) at com.pjaol.search.geo.utils.DistanceFilter.bits(DistanceFilter.java:123) at org.apache.lucene.search.Filter.getDocIdSet(Filter.java:49) at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:140) at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:112) at org.apache.lucene.search.Hits.getMoreDocs(Hits.java:113) at org.apache.lucene.search.Hits.init(Hits.java:90) at org.apache.lucene.search.Searcher.search(Searcher.java:72) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
