[jira] Commented: (LUCENE-1885) NativeFSLockFactory.makeLock(...).isLocked() does not work
[ https://issues.apache.org/jira/browse/LUCENE-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750841#action_12750841 ] Uwe Schindler commented on LUCENE-1885: --- The new patch in LUCENE-1877 changes the isLocked() method to shortcut, if no lock file is present. In this case, without a lockfile, it cannot be not locked. This prevent NativeFSLock for creating the lock short time without really using it. > NativeFSLockFactory.makeLock(...).isLocked() does not work > -- > > Key: LUCENE-1885 > URL: https://issues.apache.org/jira/browse/LUCENE-1885 > Project: Lucene - Java > Issue Type: Bug >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Fix For: 2.9 > > > IndexWriter.isLocked() or IndexReader.isLocked() do not work with > NativeFSLockFactory. > The problem is, that the method NativeFSLock.isLocked() just checks if the > same lock instance was locked before (lock != null). If the LockFactory > created a new lock instance, this always returns false, even if its locked. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-1885) NativeFSLockFactory.makeLock(...).isLocked() does not work
[ https://issues.apache.org/jira/browse/LUCENE-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750610#action_12750610 ] Uwe Schindler commented on LUCENE-1885: --- Thanks! It was not so hard. After changing the default lock factory, a lot of tests were failing because of this. > NativeFSLockFactory.makeLock(...).isLocked() does not work > -- > > Key: LUCENE-1885 > URL: https://issues.apache.org/jira/browse/LUCENE-1885 > Project: Lucene - Java > Issue Type: Bug >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Fix For: 2.9 > > > IndexWriter.isLocked() or IndexReader.isLocked() do not work with > NativeFSLockFactory. > The problem is, that the method NativeFSLock.isLocked() just checks if the > same lock instance was locked before (lock != null). If the LockFactory > created a new lock instance, this always returns false, even if its locked. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-1885) NativeFSLockFactory.makeLock(...).isLocked() does not work
[ https://issues.apache.org/jira/browse/LUCENE-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750590#action_12750590 ] Michael McCandless commented on LUCENE-1885: Nice catch Uwe! > NativeFSLockFactory.makeLock(...).isLocked() does not work > -- > > Key: LUCENE-1885 > URL: https://issues.apache.org/jira/browse/LUCENE-1885 > Project: Lucene - Java > Issue Type: Bug >Reporter: Uwe Schindler >Assignee: Uwe Schindler >Priority: Blocker > Fix For: 2.9 > > > IndexWriter.isLocked() or IndexReader.isLocked() do not work with > NativeFSLockFactory. > The problem is, that the method NativeFSLock.isLocked() just checks if the > same lock instance was locked before (lock != null). If the LockFactory > created a new lock instance, this always returns false, even if its locked. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
